Otherwise there is an error:
In file included from ../../extensions/common/url_pattern.cc:19:
In file included from ../../extensions/common/constants.h:10:
In file included from gen/components/services/app_service/public/mojom/types.mojom.h:34:
In file included from gen/ui/gfx/image/mojom/image.mojom.h:31:
In file included from gen/ui/gfx/image/mojom/image.mojom-forward.h:41:
In file included from ../../ui/gfx/image/mojom/image_skia_mojom_traits.h:12:
In file included from ../../skia/public/mojom/bitmap_skbitmap_mojom_traits.h:14:
In file included from ../../skia/public/mojom/image_info_mojom_traits.h:12:
../../third_party/skia/include/core/SkImageInfo.h:11:10: fatal error: 'include/core/SkColorSpace.h' file not found
No longer needs `thread` param.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/16395195c71cc831e85e10524f2c18311b325df5
commit 16395195c71cc831e85e10524f2c18311b325df5
Author: Clark DuVall <cduvall@chromium.org>
Date: Tue Jul 30 18:04:24 2019 +0000
Remove unused IOThreadExtensionFunction
This also merges UIThreadExtensionFunction and ExtensionFunction since
there's no need for them to be separate anymore. This was made possible
because WebRequest has moved to the UI thread, and it was the only API
using IOThreadExtensionFunction.
Follow up CL will remove references to UIThreadExtensionFunction.
Bug: 980774
The method now returns a struct instrad of having mutliple out params.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/4ed01619c8ae43d3a1ef1f8acd713aa6aaa3530b
commit 4ed01619c8ae43d3a1ef1f8acd713aa6aaa3530b
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Thu Jul 18 17:41:55 2019 +0000
[Extensions Bindings] Return a struct from APISignature parsing methods
Make APISignature::ParseArgumentsToJSON(),
APISignature::ParseArgumentsToV8(), and
APISignature::ConvertArgumentsIgnoringSchema() return a struct
containing the parse results, including arguments, error, and
async response type (callback if one were provided).
This will make it easier when we need to provide additional information
about if a promise should be returned.
No behavior change is expected.
Bug: 978538
Newly addied apis set content settings to user preference instead of
ContentSettingsStore.
Also, previously set value in extension's ContentSettingsStore is
deleted when user changes current setting.
Mark Pilgrim