- renaming PageController => JSHandler
- fixing guard usage (leaving TODOs where work required)
- pref_names split into 2 files
- BraveVpnServiceDesktop now gets passed pending remote and binds
- SKU mojom ref in VPN (desktop) will now rebind if connection broken
- Updated comments (documentation)
- Fixed callback usage in SkusServiceImpl
- Fixed gn_check violations
- Default SKU feature to true on iOS
- Have a common preferences registration (avoid iOS duplicating)
- Fixup iOS naming to match renamed service
- Fixup! Missed iOS changes that didn't get commited
- Fixup iOS build and switch factory to use mojo PendingRemote
- Fixup iOS headers and correct Swift name for SkusServiceFactory
- Fixup iOS factory to check nullability of GetServiceForBrowserState
- Fixup iOS factory name
- Update SimpleURLLoader response to pass thru error code and properly handle body
- Update SimpleURLLoader to use `DownloadToStringOfUnboundedSizeUntilCrashAndDie`
instead of expecting an arbitrary response size
- Renaming and lint fixes
- fix macos static linking errors
- add missing macos guard
- strip unused symbols from the rust lib so we can use lld
- more ios and mac rust build fixes
This method will go away soon, so we get rid of Brave-specific
instances now to prepare for the future.
For now, this patch just makes sure we don't call the deprecated
method, but ideally we should probably make deeper changes not to
use a GURL as the type for origins, and use url::Origin instead.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/e439902e17bbd1f540f7dc7f6e3e153871c76b34
commit e439902e17bbd1f540f7dc7f6e3e153871c76b34
Author: Matt Menke <mmenke@chromium.org>
Date: Thu Oct 21 18:04:42 2021 +0000
Reporting: Remove use of GURL::DeprecatedGetOriginAsURL().
In some places this was called only to eventually convert the result
to an Origin.
Also make reporting APIs that were taking a URL only to convert it to
an origin take origins instead.
Bug: 512374
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/800532c0bf6712ea4ab5928da9e776d6607a10b1
commit 800532c0bf6712ea4ab5928da9e776d6607a10b1
Author: Mike West <mkwst@chromium.org>
Date: Thu Oct 14 09:26:52 2021 +0000
Deprecate returning a GURL from GURL::GetOrigin().
This patch renames `GURL::GetOrigin()` to
`GURL::DeprecatedGetOriginAsURL()`. A subsequent patch will
reintroduce a `GURL::GetOrigin()` that returns a `url::Origin`
rather than a `GURL`.
This patch was brought to you by sed, followed by a little manual
work to deal with look-alike methods (most notably
`CascadePriority::GetOrigin()` and `NudgeTracker::GetOrigin()`) and
two or three spots that held pointers to GURLs:
```
git grep -n -l ".GetOrigin(" | \
xargs -L1 sed -i '' \
-e 's/\.GetOrigin(/.DeprecatedGetOriginAsURL(/g'
```
Bug: 512374
Chromium change:
https://chromium.googlesource.com/chromium/src/+/39810e70da06baca176c0cdbc93164be1f980f59
commit 39810e70da06baca176c0cdbc93164be1f980f59
Author: Patrick Monette <pmonette@chromium.org>
Date: Thu Oct 14 18:06:59 2021 +0000
Reland "Move task-related files from base/ to base/task/"
This is a reland of 092c30c5fd4def5a0c63d6f3a8953bd07768dd44
The 2 problematic subrepos have been migrated and a couple late
addition of the old headers were migrated.
Original change's description:
> Move task-related files from base/ to base/task/
>
> The forward headers are updated to point to the new location, and the
> header guards were fixed.
>
> Bug: 1255932
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/fee67eecab685e91b34ca9587a976257a56e4455
commit fee67eecab685e91b34ca9587a976257a56e4455
Author: Caitlin Fischer <caitlinfischer@google.com>
Date: Thu Sep 23 20:01:00 2021 +0000
Move the call to FieldTrialList::EnableBenchmarking() earlier.
This call is being moved from VariationsFieldTrialCreator
::SetupFieldTrials() to MetricsStateManager::InstantiateFieldTrialList()
because EnableBenchmarking should be called as soon as the list exists.
This is because when benchmarking is enabled, field trials default
groups are chosen. The situation in which the list is instantiated,
a field trial is then set up and used, and benchmarking is later enabled
should be avoided.
This change also does the following:
- Removes SetupFieldTrials' kEnableFeatures and kDisableFeatures params.
The call sites all appear to be using the switches in base/switches.h
although this wasn't always the case, e.g. on iOS, crrev.com/c/773080.
- Improves some FieldTrial API comments.
- Updates ShellContentBrowserClient::SetUpFieldTrials(), which is for
testing only. The order in this function now matches what most
platforms do: (1) create the MetricsStateManager, (2) call
InstantiateFieldTrialList(), and (3) set up field trials.
Bug: 1246410, 1251484
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/b1d0f28aa93e62bc81959e0b62158c800a46b85d
commit b1d0f28aa93e62bc81959e0b62158c800a46b85d
Author: Caitlin Fischer <caitlinfischer@google.com>
Date: Fri Sep 17 04:54:04 2021 +0000
Perform CleanExitBeacon init steps after creating the FieldTrialList.
The motivation behind this change and crrev.com/c/3160866 is being able
to assign clients to experiment groups when the CleanExitBeacon init
steps occur, as in crrev.com/c/3120545.
Bug: 1246410
Mario Sanchez Prada