Commit Graph
19 Commits
Author SHA1 Message Date
AlexeyBarabash dcae460360 Update python version to 3 for tools/android/generate_breakpad_symbols.py
fixes brave/brave-browser#17809

Related Chromium change https://source.chromium.org/chromium/chromium/src/+/0470f485e51e6ebb07cb96a64fd077fb3e5ff9ee :

build: remove is_python2.py

_is_python2 is always false now.

Bug: 1112471
Change-Id: I049610e59c7f51472b6326a7fcdd82c732725cec
2021-09-13 14:53:49 -04:00
AlexeyBarabash 2fc4fb4dea Generating breakpad symbols for Android libs 2021-08-30 15:39:39 +03:00
Max a59d5c6361 Merge pull request #9290 from brave/maxk-cr92-followup-fix-mac-signing
[cr92 followup] Fixes MacOS signing.
2021-07-01 01:50:03 -04:00
mkarolin ec520f09ea [cr92 followup] Fixes MacOS signing. 2021-06-30 20:47:28 -04:00
mkarolin 05310298d2 [cr92 followup] Fixes signing on Windows.
Fixes brave/brave-browser#16718
2021-06-30 19:56:22 -04:00
Max Karolinskiy 02c12f1ac9 Fixes buffer size warning for generate_breakpad_symbols.py.
The warning is:
/usr/lib/python3.8/subprocess.py:844: RuntimeWarning: line buffering
(buffering=1) isn't supported in binary mode, the default buffer size
will be used self.stdout = io.open(c2pread, 'rb', bufsize)

Removed bufsize=1 parameter from subprocess.Popen. Also, used
subprocess.DEVNULL param for stderr instead of opening os.devnull
explicitly in the script.
2021-06-29 16:37:38 -04:00
mkarolin f6be036729 [Win] Fixes generate_breakpad_symbols.py 2021-06-29 16:37:36 -04:00
mkarolin 0ba8e778ea [Pylint] Use 'with' syntax for opening files. 2021-06-29 16:37:31 -04:00
mkarolin fdb55066a1 [Pylint] various fixes. 2021-06-29 16:37:31 -04:00
mkarolin a70b15f758 [Pylint] optparse is deprecated -> argparse. 2021-06-29 16:37:30 -04:00
mkarolin 6c479e329e [Pylint] Fixes indent. 2021-06-29 16:37:30 -04:00
mkarolin 64579a42f4 Update headers of scripts transitioned to python3. 2021-06-29 16:37:27 -04:00
mkarolin 99f1577287 Revert "Revert "Adapts several py scripts to python3.""
This reverts commit 5540de29f0.

These script run under python3 again.
2021-06-29 16:37:25 -04:00
Matt Bacchi a32c8a5808 Generate symbols using single thread
On the Windows x86 platform we saw a large performance
degradation when using multiple threads for the
generate_breakpad_symbols target. If we run it single
threaded instead it runs in less than two minutes
vs. over two hours multi-threaded.

Also add elapsed time taken for each symbol file generated.

Python GIL info has been added to the
[devops wiki](https://github.com/brave/devops/wiki/Python-GIL).

Fixes: https://github.com/brave/devops/issues/889
2019-09-04 14:36:06 -06:00
AlexeyBarabash 572cb6528f wrapped with try finally to avoid infinite wait on failure 2018-02-14 19:18:03 +02:00
Brian R. Bondy 00a8d69831 Build dump_syms for Windows too 2018-02-11 11:28:14 -05:00
Brian R. Bondy 43c4fcbc94 Add create_dist and symbol build config 2018-02-09 13:45:46 -05:00
AlexeyBarabash 6b2310de87 Revert "Add create_dist and symbol build config"
This reverts commit 10819c1926.
2018-02-08 19:54:27 +02:00
Brian R. Bondy 10819c1926 Add create_dist and symbol build config 2018-02-06 22:20:05 -05:00