Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
62,142 Commits 1 Branch 0 Tags
5e26b1ecff4507b58f4eeb8db39a31efd74a2a7b
Commit Graph
4037 Commits
Author SHA1 Message Date
Artem Samoilenko 5e26b1ecff [Android] ShowScrollableMVTOnNTP feature was removed 
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/d864e62dddc14e305f0a274f6058ab082ad2b99a

[SurfacePolish][CleanUp] Clean up surface polish code for MVT (Part 5)

This CL represents part 5 of the cleanup for the surface polish code in
the MVT, focusing on refining the code associated most visited tiles
layout. The update removes the grid layout from most visited tiles and
renames the most visited tiles carousel layout to simply most visited
tiles layout.

Bug: 331667743
 2024-06-25 13:13:13 +01:00
Artem Samoilenko 882a482c62 [Android] Minor code adjustments to the C127 upstream changes 2024-06-25 13:13:11 +01:00
Artem Samoilenko f3c143416f [Android] Remove getLastUsedRegularProfile from TabSwitcherActionMenuCoordinator 
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/42b4616046112d454bb06bc82a872b625d483b36

Remove getLastUsedRegularProfile from TabSwitcherActionMenuCoordinator.

Bug: 40254448
 2024-06-25 13:13:09 +01:00
Artem Samoilenko 15d8a7f8a5 [Android] Fix for missing override lint warning 2024-06-25 13:13:08 +01:00
Artem Samoilenko f8a902e5fa [Android] Split SearchActivityUtils part 2: isolate Client logic 
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/8607f4c52155209d87fe2beb46c680bafcb68d13

Split SearchActivityUtils part 2: isolate Client logic (and tests).

There's no functional changes. The code is simply moved around.
Even static method continue to be static to simplify review.

Bug: 329663295
 2024-06-25 13:13:07 +01:00
Artem Samoilenko 1b7accf1f5 [Android] Stop accepting fragment as raw string in SettingsLauncher API 
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/a132d3713b07b5e78f3c7a0d4b1b0fc9401f4214

Stop accepting fragment as raw string in SettingsLauncher API

No behavior change. Before this CL, the SettingsLauncher API used to
take fragments as 3 different types.
1) Fragment class
2) SettingsFragment enum
3) String for class name of the fragment

2 and 3 are used when the calling code is modularized but not the
corresponding fragment. 3 is less safe than 2 (think features
breaking because the fragment got renamed or changed packages). So
this CL drops 3 and adopts only 2.

Long term, it would be good to unify more, i.e. either
- Modularize all settings fragments and only use 1.
- Only use 2.
But that work is beyond this CL.

Change-Id: I1d2c99aa60bc0393f514a9e10d895185be399196
 2024-06-25 13:13:07 +01:00
AlexeyBarabashandDeep Pandya 9c96ab17a5 Android - Display Sync code expiry when showing the pairing codes (#23051) 
* Android - Display Sync code expiry when showing the pairing codes

fixes brave/brave-browser#37725

Co-authored-by: Deep Pandya <5146988+deeppandya@users.noreply.github.com>
 2024-06-20 16:05:10 +03:00
Anton Paymyshev 0b50112d2d Remove KeyedService from some wallet services (#24220) 2024-06-20 12:03:56 +07:00
Simone Arpe 4667e2e2c7 (Wallet) Tweak onboarding layouts and styles following updated Figma design (#24063) 
* Fix network selection default networks
* Improve layouts and text styles based on updated Figma design
* Replace color name with Nala color name
 2024-06-12 19:01:32 +02:00
Anton Paymyshev 6e7b58f5b7 Refactor wallet networks (#23954) 2024-06-11 17:13:28 +07:00
deeppandya 5567417f63 Update behaviour for removing AC layout 
Rename function for AC visibility
 2024-06-10 12:27:48 -04:00
deeppandya a97fd598f4 Remove AC for web3 only publisher 2024-06-10 12:27:43 -04:00
Nick von Pentz 3248b2f695 Add Solana priority fees (#23214) 
Add support for Solana priority fees
 2024-06-10 11:06:39 -04:00
Simone Arpe c0c45c682d (Wallet) Fix Bitcoin transactions (#24062) 
* Add Bitcoin error provider
* Implement bitcoin data extraction
* Calculate Bitcoin fee
* Add BTC and FIL when extracting coin type from `TxDataUnion`
 2024-06-07 18:31:49 +02:00
deeppandya a12e559677 Remove unused kill switch image resource 
Change image resource order
 2024-06-06 02:16:05 -04:00
deeppandya a99f6f33ff Remove kill switch changes 2024-06-06 00:37:23 -04:00
Simone Arpe 7ff01743f0 (Wallet) Implement network configuration settings (#23937) 
Implements network settings and shows hidden networks and custom networks for Ethereum, Filecoin, Solana and Bitcoin. Adopted the same logic as Desktop for most parts.
 2024-06-03 16:23:25 +02:00
samartnik ceda17eb28 Merge pull request #23944 from brave/android_leo_menu_fix 
[Android] Follow up fix for menu position after opening Leo
 2024-05-31 18:08:48 -04:00
Artem Samoilenko 6411b28178 [Android] Follow up fix for menu position after opening Leo 2024-05-31 16:20:39 -04:00
Deep Pandya ec3d4db880 Merge pull request #23929 from brave/option_to_update_filter_list_android 
Option to update filter list android
 2024-05-31 14:12:47 -04:00
Deep Pandya 64ac4c84d6 Merge pull request #23927 from brave/resolve_shields_url_ellip_android 
Update ellipsize from end to start
 2024-05-31 13:06:44 -04:00
deeppandya 6e6a4e5b76 Update filterList after successful update 2024-05-31 13:05:57 -04:00
deeppandya e4b3bbba27 Add toast for the response 
Change behaviour for update action button for filterlist
 2024-05-31 13:05:55 -04:00
deeppandya 5200098ff9 Add fucntion for update filter list 2024-05-31 13:05:52 -04:00
AlexeyBarabash f24f36de6b Fixed color of switch at Shields and content filters (#23910) 
Fixed color of switch at Shields and content filters
 2024-05-30 17:10:47 +03:00
AlexeyBarabash de75edfe8e Force export passwords to local storage on Android; fixes brave/brave… (#23901) 
Force export passwords to local storage on Android

fixes brave/brave-browser#38655
 2024-05-30 00:58:27 +03:00
deeppandya e626c0777f Update ellipsize from end to start 2024-05-29 11:24:13 -04:00
Serg 0c7a86865a Removes an unneeded assert in BraveToolbarManager 2024-05-28 15:20:14 -04:00
AlexeyBarabash c5bda79168 Check for null Activity to prevent cras (#23864) 
Check for null Activity to prevent crash; fixes brave/brave-browser#38618
 2024-05-28 15:49:17 +03:00
Serg 7090bf6e46 Merge pull request #23855 from brave/android_pip_crash 
Ignores setPictureInPictureParams IllegalStateException when pip Activity is not in an appropriate state on Android
 2024-05-27 16:28:23 -04:00
Serg 70ed26ab17 Ignores setPictureInPictureParams IllegalStateException when pip Activity is not in an appropriate state on Android 2024-05-27 15:30:11 -04:00
Simone Arpe d6ea9451d8 (Wallet) Fix NOTREACHED on Android Wallet (#23843) 
* Fix NOTREACHED on Android Wallet
* Set ETH as a default network after restoring
 2024-05-27 18:23:26 +02:00
AlexeyBarabash 1f4f6c0039 TopToolbarCoordinator.ctor has no shouldCreateLogoInStartToolbar arg 
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/a90215339806ae4f6a512a63d84fa06063c7f3ff

	[SurfacePolish][CleanUp] Clean up surface polish code related with SURFACE_POLISH_LESS_BRAND_SPACE_PARAM parameter.

	Clean up surface polish code related with
	SURFACE_POLISH_LESS_BRAND_SPACE_PARAM parameter.

	Bug: 331667743
	Change-Id: Id575285bd8d903e067e4c8c7a8edf6a433cafa16
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5530104
 2024-05-24 09:45:12 -04:00
AlexeyBarabash 861d775e6d NewTabPageLayout.initialize has no isSurfacePolishLessBrandSpaceEnabled parameter anymore 
Related Chromium change:
	[SurfacePolish][CleanUp] Clean up surface polish code related with SURFACE_POLISH_LESS_BRAND_SPACE_PARAM parameter.

	Clean up surface polish code related with
	SURFACE_POLISH_LESS_BRAND_SPACE_PARAM parameter.

	Bug: 331667743
	Change-Id: Id575285bd8d903e067e4c8c7a8edf6a433cafa16
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5530104
 2024-05-24 09:45:12 -04:00
AlexeyBarabash 3e8402f4c7 TabManagementDelegate.createTabGroupUi now has modalDialogManager 
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/44f20aacfd674f255d403fc693669d86bf5fae1e

	Show a dialog when ungrouping the last tab(s).

	Bug: 324935631
	Change-Id: I4bd56ac21f4e1eca795001dcbff9c2662e312f71
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5516444
 2024-05-24 09:44:12 -04:00
AlexeyBarabash e453efdf1b NewTabPageLayout.initialize doesn't have isSurfacePolishOmniboxColorEnabled arg 
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/a90215339806ae4f6a512a63d84fa06063c7f3ff

	[SurfacePolish][CleanUp] Clean up surface polish code related with SURFACE_POLISH_LESS_BRAND_SPACE_PARAM parameter.

	Clean up surface polish code related with
	SURFACE_POLISH_LESS_BRAND_SPACE_PARAM parameter.

	Bug: 331667743
	Change-Id: Id575285bd8d903e067e4c8c7a8edf6a433cafa16
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5530104
 2024-05-24 09:44:12 -04:00
AlexeyBarabash 7505fcef17 HomepageManager.shouldCloseAppWithZeroTabs is non-static now 
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/618819a4be308d02459fb6b06df5a00515b5ee26

	Convert static methods in HomepageManager to non-static.

	This works towards passing in a Profile into HomepageManager
	and remove the static Profile access internally.

	Bug: 338276230
	Change-Id: Ib20372f0494cf2fc75d3a51c03fa31e7d7b587f5
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5507082
 2024-05-24 09:44:09 -04:00
AlexeyBarabash a4cfcc93d1 TopToolbarCoordinator.initializeWithNative now has Profile argument 
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/3c8f4d81103b902a3957a15315b59d082f8789da

	Remove getLastUsedRegularProfile from ToolbarPhone.

	Bug: 40254448
	Change-Id: Iefb4d474c2e03314841be2f38a7c415c9ca4c4c0
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505737
 2024-05-24 09:44:09 -04:00
AlexeyBarabash 8f6c310392 TopToolbarCoordinator.ctor has no desktopWindowModeSupplier arg anymore 
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/d294821b0548c2021e27ea625f9f4230d556ffbf

	[TSLO] Update MultiInstanceManagerApi31 to use
	DesktopWindowStateProvider

	This CL removes the boolean desktop window mode supplier used by
	MultiInstanceManager and injects a DesktopWindowStateProvider supplier
	instead, since the latter is instantiated after MultiInstanceManager
	on startup.

	Bug: 325351108
	Change-Id: Ibe3c7cbb66cc0a31459d705e86ca69313d99b63a
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503037
 2024-05-24 09:44:09 -04:00
AlexeyBarabash 11e16c3386 Changed parameter at MultiInstanceManagerApi31.ctor 
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/d294821b0548c2021e27ea625f9f4230d556ffbf

	[TSLO] Update MultiInstanceManagerApi31 to use
	DesktopWindowStateProvider

	This CL removes the boolean desktop window mode supplier used by
	MultiInstanceManager and injects a DesktopWindowStateProvider supplier
	instead, since the latter is instantiated after MultiInstanceManager
	on startup.

	Bug: 325351108
	Change-Id: Ibe3c7cbb66cc0a31459d705e86ca69313d99b63a
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503037
 2024-05-24 09:44:08 -04:00
AlexeyBarabash 46690e17a3 HomepageManager.isHomepageEnabled() is not static now 
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/618819a4be308d02459fb6b06df5a00515b5ee26

	Convert static methods in HomepageManager to non-static.

	This works towards passing in a Profile into HomepageManager
	and remove the static Profile access internally.

	Bug: 338276230
	Change-Id: Ib20372f0494cf2fc75d3a51c03fa31e7d7b587f5
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5507082
 2024-05-24 09:44:08 -04:00
AlexeyBarabash 9659c6ed50 Additional parameters at ToolbarLayout.initialize 
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/3c8f4d81103b902a3957a15315b59d082f8789da

	Remove getLastUsedRegularProfile from ToolbarPhone.

	Bug: 40254448
	Change-Id: Iefb4d474c2e03314841be2f38a7c415c9ca4c4c0
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5505737
 2024-05-24 09:44:08 -04:00
AlexeyBarabash eab53f1a31 Removed IncognitoNewTabPageManager.shouldShowRevampedIncognitoNtp method 
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/01bbc848cd2b08fa83a0fc0cdfef94e21c37dffc

	[Code Health][Clank] Clean up unused feature Incognito NTP

	Bug: 40258200, 40838267, 335440649
	Change-Id: I8ae1135c0e1a195607e39a808a771a4ed32a6a51
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5490088
 2024-05-24 09:44:03 -04:00
AlexeyBarabash 420094797e Additional parameter at TopToolbarCoordinator.ctor 
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/94794635ed8558f2892ff4055c93239492448e68

	[TabTearing] Restrict closing empty window after tab reparenting to
	desktop windowing mode

	Currently, when the only tab in a Chrome window is dragged out and into
	another Chrome window in multiwindow mode, the empty source window is
	closed. Restrict closing the empty window to desktop windowing mode,
	such a window should continue to exist in split screen after tab
	reparenting.

	Bug: 333411285
	Change-Id: I71c694f4c7fdb311a455b5c4b80cf21de806a3eb
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5436853
 2024-05-24 09:44:02 -04:00
AlexeyBarabash d2c466aea0 Changed type of contextualSearchManagerSupplier at TabbedRootUiCoordinator.ctor 
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/cc4bc09f39ff16e6ed59d95920c1afb7260dffe3

	Wire overlay panel visibility and color to BottomAttachedUiObserver

	https://screencast.googleplex.com/cast/NjI1ODA3OTU5NDE4NDcwNHw2ZTllOGQ5Yy1iYg

	Bug: 329287585
	Change-Id: Id7d85a762d827ffad24f651767db7e2d9b7623e8
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5472457
 2024-05-24 09:44:02 -04:00
AlexeyBarabash 208c9927a9 Upstream removed NotificationSettingsBridge.getChannelStatus 
this commit is just a stub, work is in progress

Related Chromium PR:
https://source.chromium.org/chromium/chromium/src/+/f1f760c66d99f75606c077ceb4264057b0f39566

Use Async calls for NotificationChannelsProviderAndroid

NotificationManager APIs can block the main thread. So I am working on
moving all notification related calls to async. This CL will change
all method in NotificationChannelsProviderAndroid to async.

Because of the asynchronous calls, NotificationChannelProviderAndroid::GetRuleIterator() will no longer update the cached channels synchronously. Instead, GetRuleIterator() will schedule a async call to update channels, so later on all the observers will get notified. Additionally, SetWebsiteSettings() may have a delayed impact on GetRuleIterator(), as all the tasks are asynchronous.

Will change the java side class to call the async APIs in next CL.

Bug: b:242038130, b:242028843
Change-Id: Iccbac30846e83681411831c0c2e0fadda48487d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5341621
 2024-05-24 09:41:23 -04:00
AlexeyBarabash ee01b3a0c0 Upstream's NewTabPageLayout.setSearchProviderTopMargin and NewTabPageLayout.setSearchProviderBottomMargin are private now, so apply Java asm patching for proper inheritance at NewTabPageLayout. 
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/4dd30b9213c2d36bf2f4d4e4cf60ad57adf8901b

	[LogoPolish] Only enable Logo Polish for Google doodle on NTP.

	This CL only enables the logo polish and adjust the logo size on NTP
	when the logo is a Google doodle.
	The behavior will look like this:
	For Phone:
	https://drive.google.com/file/d/1Sanx-LqGhzA9NjX9RZaKc4JGFyizQm8O/view?usp=sharing&resourcekey=0-G8NxGsD0ZMiwzPdkcb1jxA
	For Tablet:
	https://drive.google.com/file/d/1mQKFDLFHh8wEbrbvXAIXApiT-jC-Ykup/view?usp=sharing&resourcekey=0-Tk6_0wGgcjLRqTS1aUjVoQ

	Bug: 335276342
	Change-Id: I3ed9235003633fa5a1d8437f7c36dc4ba91c01f6
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463034
 2024-05-24 12:58:07 +01:00
AlexeyBarabash 743753f614 Changed BraveToolbarManager.ctor last argument from appHeaderCoordinatorSupplier to desktopWindowStateProvider after upstream 
Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/f9ddbefd1d9a684771841f9b72753270ecc4120c

[TSLO] Add AppHeaderStateProvider interface

Introduce AppHeaderStateProvider interface to detangle dependencies over AppHeaderCoordinator.

Bug: 332784708
Change-Id: I367e0be5ed4fde09e063625b6782030c86599bd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5430978
 2024-05-24 12:58:07 +01:00
samartnik ca7912f8b4 Merge pull request #23796 from brave/android_edit_url_suggestion_fix 
[Android] Fix for missing edit url suggestion on url focus
 2024-05-23 09:11:44 -04:00
Deep Pandya 92dfc0dc6b Merge pull request #23727 from brave/in_app_update_android_13_and_below 
Enable in app update dialog for < android 14 devices
 2024-05-23 01:18:47 -04:00