Broken due to Chromium change:
https://chromium.googlesource.com/chromium/src/+/016b18a82b6b94c9244d2aa2be0c7af8826d1f8b
commit 016b18a82b6b94c9244d2aa2be0c7af8826d1f8b
Author: Theresa Wellington <twellington@chromium.org>
Date: Wed Nov 13 19:14:49 2019 +0000
Move chrome/android/.../appmenu/ to its own build target
Move chrome/android/java/.../appmenu/ (excluding a handful of classes)
to its chrome/browser/ui/android/appmenu/ and create a separate build
target for the app menu.
Also splits appmenu classes and resources between public and internal/
BUG=966644
Chromium change:
https://chromium.googlesource.com/chromium/src/+/97fd6bcffbe752b404b4664f2314f6045095ba69
commit 97fd6bcffbe752b404b4664f2314f6045095ba69
Author: Natalie Chouinard <chouinard@chromium.org>
Date: Wed Oct 23 21:28:19 2019 +0000
Add isManagedPreference to PrefServiceBridge
Add a generic isManagedPreference method to PrefServiceBridge, making
use of the prefs.h enums.
Migrate Java usages of prefs::kSearchSuggestEnabled to use the generic
methods as a sample (more to follow).
Bug: 1016957
Chromium change:
https://chromium.googlesource.com/chromium/src/+/eb7da349e164fb82fe1f68f9cb2591852e977480
commit eb7da349e164fb82fe1f68f9cb2591852e977480
Author: Theresa Wellington <twellington@chromium.org>
Date: Wed Oct 30 18:33:45 2019 +0000
Introduce appmenu.CustomViewBinder interface for update menu item
Introduce a new CustomViewBinder interface that allows
AppMenuPropertiesDelegates to handle binding for custom menu items.
This interface is used to provide a custom binder for the update menu
item, which relies on UpdateMenuItemHelper methods/classes that will not
be moved to the appmenu/ package when its modularized.
Bug: 966644
The only functionality in there was for a method used in FeatureUtilities,
which no longer imports ChromePreferenceManager. Also, moved keys to a
separate class similarly to Chromium - BravePreferenceKeys.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/545eecd948d81dc98904e8f39a75df7acb50668c
commit 545eecd948d81dc98904e8f39a75df7acb50668c
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Fri Nov 8 15:28:57 2019 +0000
Move remaining SharedPreferences keys to ChromePreferenceKeys.
Bug: 1022107
Chromium change:
https://chromium.googlesource.com/chromium/src/+/9b9170600e22b6a51be6183a46f9f93d203de061
commit 9b9170600e22b6a51be6183a46f9f93d203de061
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Sun Nov 24 01:23:13 2019 +0000
Android: Tab interface
This CL defines Tab as an interface, and provides a concrete
implementation of it (TabImpl). Initially the codebase switches to
TabImpl for accessing non-public interface methods. The interface
starts with a subset of methods and gradually includes more,
and eventually replace all the references of TabImpl with Tab.
See https://bit.ly/2WibHVy for the design proposal.
Bug: 995903
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/0b4e397d6bcb90f40bbe44bd10f6f3a5c64201dd
commit 0b4e397d6bcb90f40bbe44bd10f6f3a5c64201dd
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Thu Oct 24 16:30:06 2019 +0000
Create chrome.browser.ui.widget.styles.
Initially, it contains:
- ChromeColors (was part of ColorUtils)
- @color
- toolbar_background_primary
- toolbar_background_primary_dark
- standard_mode_tint
- tint_on_dark_bg
Shared resources that correspond to Chrome style should be moved here.
Bug: 995916
https://chromium.googlesource.com/chromium/src/+/e79684562f1eeb693cc475acf99611f6a78c29ff
commit e79684562f1eeb693cc475acf99611f6a78c29ff
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Thu Oct 17 15:29:50 2019 +0000
Create ToolbarColors in chrome/browser/toolbar.
Move some methods from ColorUtils to it:
- getTextBoxColorForToolbarBackground()
- getToolbarSceneLayerBackground()
- getTextBoxAlphaForToolbarBackground()
- isUsingDefaultToolbarColor()
- getThemedToolbarIconTintRes()
- getThemedToolbarIconTint()
This breaks the dependency from ColorUtils to Tab and NewTabPage.
Bug: 995916
https://chromium.googlesource.com/chromium/src/+/26abb7309105ddb3f393f1558adb265bd559e54b
commit 26abb7309105ddb3f393f1558adb265bd559e54b
Author: Lijin Shen <lazzzis@google.com>
Date: Mon Nov 4 19:32:02 2019 +0000
Fix URL bar background flash on swiping tabs and entering/exiting tab switcher
The background of URL bar is not displayed on swiping tabs or entering/existing
tab switcher. This CL is trying to correct location bar background color by
detecting whether it is an NTP and location bar is on top of the NTP or not.
Bug: 874101
Chromium change:
https://chromium.googlesource.com/chromium/src/+/016b18a82b6b94c9244d2aa2be0c7af8826d1f8b
commit 016b18a82b6b94c9244d2aa2be0c7af8826d1f8b
Author: Theresa Wellington <twellington@chromium.org>
Date: Wed Nov 13 19:14:49 2019 +0000
Move chrome/android/.../appmenu/ to its own build target
Move chrome/android/java/.../appmenu/ (excluding a handful of classes)
to its chrome/browser/ui/android/appmenu/ and create a separate build
target for the app menu.
Also splits appmenu classes and resources between public and internal/
BUG=966644
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/4b1887815272e0870334035e0788bb6a3c2ec162
commit 4b1887815272e0870334035e0788bb6a3c2ec162
Author: Natalie Chouinard <chouinard@chromium.org>
Date: Wed Nov 27 20:29:55 2019 +0000
Separate preferences and settings subpackages
Move all classes under org.chromium.chrome.browser.preferences which are
related to Android settings screens (rather than the underlying
preferences persistence layers) to org.chromium.chrome.browser.settings
instead.
This disambiguation was decided in go/clank-preferences-refactor.
Dependent downstream change: https://crrev.com/i/2222930
Bug: 1027271
https://chromium.googlesource.com/chromium/src/+/6f29369b254c8f82a23c2583d6fcc2dfe585c547
commit 6f29369b254c8f82a23c2583d6fcc2dfe585c547
Author: Natalie Chouinard <chouinard@chromium.org>
Date: Tue Dec 3 19:24:25 2019 +0000
Rename PreferenceUtils to SettingsUtils
This is a purely mechanical rename done with Android Studio.
This class is being renamed to adhere to the conventions described in
go/clank-preferences-refactor.
TBR=gogerald@chromium.org
Bug: 1029146
chrome/android/java/strings -> chrome/browser/ui/android/strings
Moved android_brave_strings.grd to the same location.
Moved XTBs as well.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/c5ff0bef24795c5e26308674f015ea75cc17225f
commit c5ff0bef24795c5e26308674f015ea75cc17225f
Author: Theresa Wellington <twellington@chromium.org>
Date: Thu Nov 7 02:08:21 2019 +0000
[Android] Create shared strings module
Move android_chrome_strings.grd to its own separate build target
and merge ui widget strings back into android_chrome_strings.grd.
BUG=1002534
Max Karolinskiy