* [Android] Fix for crash after cr128 upgrade when pressing back at tab switcher
Forced invoke of `createTabSwitcherPaneCoordinator` before `TabSwitcherPaneBase.requestAnimationData()` to avoid null access crash.
Fixesbrave/brave-browser#40422
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/57a7761b2055997dccd9b566e1c42226734a1dbe
[Tab Group] Fix getTabGroupCount for tab groups with size 1
TabGroupModelFilter wasn't correctly tracking tab groups with size 1.
Increment when:
* Creating a single tab group.
* Adding a single tab that is in a tab group.
Decrement when:
* Closing the last tab in a group rather than when size becomes 1.
* Removing the last tab from a tab group with size 1.
Modify logic when adding a tab to the tab model as part of a group
so that the group is created later and we can properly signal if a
new group was created or not.
Bug: 41496693
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/4dfe0238c9391e5b9a4284072e7d07926171215b
[Tab Groups] add Token-based ID support behind flag
Add and manage Token-based TabGroupIds for Tabs in TabGroupModelFilter.
RootId must be the TabId of one of the tabs in the group. This is
unstable because if the Tab with the TabId corresponding to the RootId
of the group is removed from the group the group must elect a new
TabId from among its tabs to be the new RootId. This leads to issues
with managing the state of a tab group over time.
Under the RootId paradigm every tab was associated with a TabGroup
object and only tab groups with > 1 tab were considered "real" tab
groups. In an effort to support tab groups with a single tab it is
necessary to come up with a new approach.
This CL introduces TabGroupId. This ID is stable in that it is tied
to the group the tabs are in and can only be destroyed if all tabs
are removed from the tab group OR two groups with TabGroupIds are
merged resulting in one of the two TabGroupIds going away.
Tabs only have a TabGroupId if they are associated with a "real"
tab group of size 1 or larger. Otherwise this field will be null.
This means that TabGroup objects will only contain tabs with a
TabGroupId if the group is > size 1 OR that single tab is to be
treated as a real tab group.
If the flag AndroidTabGroupStableIds is enabled then after
tab state initialization all tabs that are part of "real" tab
groups under the old definition will be allocated TabGroupIds
in a 1:1 manner with old RootIds. When the flag is disabled
the TabGroupIds will all be reset instead.
Logic for maintaining TabGroupIds is as follows:
* A Tab Group Id is allocated when:
* A single tab is turned into a single tab group.
* A single tab is merged with another single tab to form a
group.
* A list of tabs is merged to a single tab to form a group.
If a group is merged to a single tab its Tab Group Id is
preserved.
* Tab Group Ids are removed from tabs when:
* Ungrouping a tab from a group.
* Tab Group Ids are lost entirely when:
* Merging two tab groups both with tab group ids (only one ID will
continue to exist).
* Removing the last tab from a group.
* Deleting an entire tab group.
Bug: b/41496693
Chromium change:
https://github.com/brave/chromium/commit/2dde79ed20e6534fca02aa1216541df76f14c589
Delete IntentHandlerDelegate
processUrlViewIntent was only implemented by ChromeTabbedActivity and so
having ChromeActivity call IntentHandler#onNewIntent was confusing and
hard to reason about.
This change moves the ChromeTabbedActivity-only code from IntentHandler
into ChromeTabbedActivity.
Change-Id: I38e46830f66488a822ab3e2ec85d4f90d4fd9a52
Chromium change:
https://github.com/brave/chromium/commit/aa78b431380e08988cccde7e6e2a167568da64a9
[Tab Groups] Remove auto creation and menu order params
Remove tab group auto creation and menu order params as these are
launched in their current and final states.
Tab Group Auto Creation is disabled.
New Tab In Group is first in the context menu.
Bug: 1188370
Keep `HideBottomViewOnScrollBehavior` class that was removed by Proguard optimizations.
This class is referenced in an XML layout under the attribute `app:layout_behavior`, in particular in the main Brave Wallet layout (`activity_brave_wallet.xml`).
Proguard is not able to determine whether this class is used and was removing it in release builds only.
Otherwise there is an error:
Warning in ../../brave/android/java/proguard.flags at line 46, column 1:
Proguard configuration rule does not match anything: `-keep,allowrepackaging,allowobfuscation,allowshrinking class * extends com.google.gson.reflect.TypeToken {
<init>();
}`
Chromium changes:
chromium/chromium@f40ea91
Remove hardcoded profile from android TemplateUrlServiceFactory.
Migrates the easier (e.g. already had an Profile reference) usages
to the new method that takes a Profile.
Adds a PRESUBMIT to try and prevent additional getLastUsedRegularProfile()
calls.
BUG=1410601
Change-Id: I65a63d02eacb3459367ad3e6cf056d346aac8044
chromium/chromium@05f85c3
Pass an explicit Profile reference to TemplateUrlServiceFactory
from SearchEngine settings.
BUG=1410601
Change-Id: Id6dbf39632d028838acefb529e029eb0d447cda5
AlexeyBarabash