This lowers 1.34.x l10n update for 1.33.x release. This change removes
the original commit's changes to upstream localization files because
1.34.x has Cr96 and this commit is intended for Cr97.
Fixesbrave/brave-browser#20029
From cr97 on, having this feature enabled means that the browser will
attempt to reach the Optimization Guide Server every now and then at
the https://optimizationguide-pa.googleapis.com endpoint, as it was
detected by the npm run network-audit command:
[:ERROR:brave_network_audit_browsertest.cc(151)] NETWORK AUDIT FAIL:https://optimizationguide-pa.googleapis.com/v1:GetModels?key=dummytoken
[:ERROR:brave_network_audit_browsertest.cc(151)] NETWORK AUDIT FAIL:https://optimizationguide-pa.googleapis.com/v1:GetModels?key=dummytoken
[...]
[:ERROR:brave_network_audit_browsertest.cc(151)] NETWORK AUDIT FAIL:https://optimizationguide-pa.googleapis.com/v1:GetModels?key=dummytoken
../../brave/browser/net/brave_network_audit_browsertest.cc:249: Failure
Value of: PerformNetworkAuditProcess(events)
Actual: false
Expected: true
network-audit FAILED. Import /home/mario/work/brave-rebases/brave-browser/src/network_log.json in chrome://net-internals for more details.
Stack trace:
#0 0x55f213f6cc10 brave::(anonymous namespace)::BraveNetworkAuditTest::TearDownInProcessBrowserTestFixture()
#1 0x55f215bda3be content::BrowserTestBase::SetUp()
#2 0x55f215bd741e InProcessBrowserTest::SetUp()
This patch disables the kkOptimizationHints feature. TBD if this is
needed.
This patch disables the kRemoteOptimizationGuideFetching features that
are otherwise enabled by default, avoiding this URL requests.
PS: I couldn't pinpoint yet where exactly in Chromium 97 this started
happening, but I can consistently reproduce it on my local cr97 branch
setting kMaxTimeoutPerLoadedURL in brave_network_audit_browsertest.cc
to at least 20 seconds, while this doesn't happen on cr96 even when
using the default timeout of 5 minutes, so it's cr97-related.
This feature has launched by default upstream but we still need to
disable it as per request from the Security team, so we basically
bring back the previous behaviour via a chromium_src override, plus
a small patch to adapt javascript_frameworks_ukm_observer.cc.
Chromium change:
https://github.com/chromium/chromium/commit/34af795689999a2670d0238dedb5892b35e1642b
commit 34af795689999a2670d0238dedb5892b35e1642b
Author: Nicolás Peña Moreno <npm@chromium.org>
Date: Wed Oct 27 21:22:47 2021 +0000
Remove flag for framework detection
The feature is enabled by default, and the flag is no longer needed.
Bug: 1006274
This feature is now being enabled by default for Linux, Windows and
Mac, which is interfering with Brave's own internal tranlate engine,
so we now need to explicitly disable it.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/15e59cc7caed2b3e0401bcc6b8b4fa3fa94a07f9
commit 15e59cc7caed2b3e0401bcc6b8b4fa3fa94a07f9
Author: mcrouse <mcrouse@google.com>
Date: Wed Oct 20 17:38:30 2021 +0000
[LangID] Enable TFLite Language Detection by default on Desktop.
This enables language detection by default on desktop.
Note: This also changes how tests for translate browsertests works
in cases that relying on content/language detection is not necessary.
This makes the test more reliable and less bulky. We likely want
to improve this over time but this gets us to a point we can
enable the model on ToT.
This is fully behind Finch control and we will keep it
that way for safety for a few milestones.
Bug: 1159144
Feature switch has been removed.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/1746a920a7ddafcff0f8ea5ddb6d75e54cb7a21a
commit 1746a920a7ddafcff0f8ea5ddb6d75e54cb7a21a
Author: David Benjamin <davidben@chromium.org>
Date: Thu Oct 14 17:16:57 2021 +0000
Unwind kLegacyTLSEnforced feature flag
The feature shipped, so we no longer need the flag. This doesn't change
behavior, just unwinds the old feature flag to toggle the existing
interstitial.
Bug: 1044750
Chromium change:
https://chromium.googlesource.com/chromium/src/+/1307bd02195bd73a52ab0651ef3d629d619deb33
commit 1307bd02195bd73a52ab0651ef3d629d619deb33
Author: Tommy Steimel <steimel@chromium.org>
Date: Mon Oct 18 18:52:40 2021 +0000
GMC: Rename chrome/app/global_media_controls_strings to avoid collision
With the addition of the new global media controls component, we now
have two different grdp files named global_media_controls_strings:
components/global_media_controls_strings.grdp and
chrome/app/global_media_controls_strings.grdp
This CL renames the chrome/app one to gmc_strings.grdp
Bug: 1260955
* Add support for default feature state override.
* Convert runtime feature overrides to static overrides.
* Support overrides set via a single macro instantiation.
* Remove unused include.
The buttons used for the Brave VPN in the toolbar and app menu were
lacking an accessible name, which was triggering a crash on startup
on DCHECK-enabled builds.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/a62d2cead48795f0cfc53d35dcdca66f4e236bb3
commit a62d2cead48795f0cfc53d35dcdca66f4e236bb3
Author: Peter Boström <pbos@chromium.org>
Date: Thu Oct 7 21:14:44 2021 +0000
Reland "Enable Views OnPaint() A11y DCHECKs"
This reverts commit 32985fb4404d1c7aa41053d8f4d21ed729afbb98.
Reason for revert: Relanding with additional skip-check annotations.
Original change's description:
> Revert "Enable Views OnPaint() A11y DCHECKs"
>
> This reverts commit c95dcbbb8ef6577342acfd2d9a3a0af9ee54502b.
>
> Reason for revert: Suspected culprit for failures on linux-chromeos-dbg. https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/25787/overview
>
>
> Original change's description:
> > Enable Views OnPaint() A11y DCHECKs
> >
> > This annotates MessageBoxView which was the hard-to-find culprit of
> > ChromeDriverTest.testSendTextToAlert. Presumably the test is set up to
> > generate display a zero-length message?
> >
> > This change is likely to get reverted as more issues are found in the
> > field. If you see this commit because your specific UI/dialog started
> > crashing, please see views::kSkipAccessibilityPaintChecks to temporarily
> > disable the DCHECK for your UI rather than reverting the mechanism for
> > detecting these errors. Do follow that up with removal of that property
> > and make sure that focusable UI always has accessible names that can be
> > read by screenreaders.
> >
> > Bug: 1218186
> > Change-Id: Id5e19fa7ccca844c599740b6849a3721604a5ee8
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3209106
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Commit-Queue: Scott Violet <sky@chromium.org>
> > Commit-Queue: Peter Boström <pbos@chromium.org>
> > Auto-Submit: Peter Boström <pbos@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#928920}
>
> Bug: 1218186
> Change-Id: I9abaef4c2abfa1d853be8933d700e11a727dbc97
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3210369
> Reviewed-by: Meredith Lane <meredithl@chromium.org>
> Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
> Owners-Override: Meredith Lane <meredithl@chromium.org>
> Auto-Submit: Meredith Lane <meredithl@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#929035}
Bug: 1218186
Per security team.
Also, disables origin trials and a related
kSpeculationRulesPrefetchProxy feature.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/d22042e30d6dc42081b01d0c0cc31f9f49dd2d64
commit d22042e30d6dc42081b01d0c0cc31f9f49dd2d64
Author: Simon Pelchat <spelchat@chromium.org>
Date: Thu Sep 30 19:57:51 2021 +0000
Enable SpeculationRulesPrefetchProxy by default on Android only.
Note that this feature is still gated behind origin trial and has not actually been launched.
Bug: 1022055
Per security team.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/4359c5ebd238c93c22e69d369cbe813ae3081b6c
commit 4359c5ebd238c93c22e69d369cbe813ae3081b6c
Author: Brandon Maslen <brandm@microsoft.com>
Date: Mon Sep 27 20:32:05 2021 +0000
Rename InterestGroup API flag for common use and add flag for PARAKEET impl
Update the FledgeInterestGroupAPI flag/policy to be a more generic
AdInterestGroupAPI for shared usage between multiple ad serving features.
Updates the FledgeInterestGroups flag for backend storage to be
a more generic 'InterestGroupStorage'.
Also splits the specific ad serving API methods under two new runtime
flags 'Fledge', blink::features::kFledge, and 'Parakeet',
blink::features::kParakeet. For PARAKEET the method stubs have been
added but will be fully fleshed out with proper types in a subsequent
change.
Test collateral has been updated to ensure the new surface area is
available and callable.
Bug: 1249186
Per security team.
Enterprise policy override switch is NOT disabled.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/fec3a66ed2a6db4729060315db9120f91b44bf4b
commit fec3a66ed2a6db4729060315db9120f91b44bf4b
Author: Ari Chivukula <arichiv@chromium.org>
Date: Mon Sep 27 22:04:11 2021 +0000
[WebSQL] (1) Add feature to disable third party context WebSQL
In preparation for M96 we want to add a flag to disable third party
WebSQL (which defaults to off) and an enterprise policy that can
override that. In M97 this flag will default to enabled.
(1) Add feature to disable third party context WebSQL
(2) Add enterprise policy to restore third party context WebSQL
Bug: 1212491
Similarly to what happened in the past for Windows, Mac and Android
when upstream enabled DoH by default on all those platforms [1], we
now need to adapt to that locally as we did in the past [2].
This time the result is nicer, though, because we don't need to make
any per-platform exception and can simply drop one branch of the #if.
[1] https://crrev.com/c//2429243
[2] https://github.com/brave/brave-core/commit/816a34c394
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/5f6a91993f14cab4f9c53384dd95e78a8f6ffe75
commit 5f6a91993f14cab4f9c53384dd95e78a8f6ffe75
Author: Eric Orth <ericorth@chromium.org>
Date: Fri Oct 1 14:57:15 2021 +0000
Enable DoH for linux by default in code
Same as when this was previously done for other platforms (in
crrev.com/c/2429243), leave the fieldtrial testing config stuff as-is
because it is testing the still-manipulated-via-feature-param
"DisabledProviders" list.
Bug: 1127671
These features are kAdInterestGroupAPI and kInterestGroupStorage now.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/4359c5ebd238c93c22e69d369cbe813ae3081b6c
commit 4359c5ebd238c93c22e69d369cbe813ae3081b6c
Author: Brandon Maslen <brandm@microsoft.com>
Date: Mon Sep 27 20:32:05 2021 +0000
Rename InterestGroup API flag for common use and add flag for PARAKEET impl
Update the FledgeInterestGroupAPI flag/policy to be a more generic
AdInterestGroupAPI for shared usage between multiple ad serving features.
Updates the FledgeInterestGroups flag for backend storage to be
a more generic 'InterestGroupStorage'.
Also splits the specific ad serving API methods under two new runtime
flags 'Fledge', blink::features::kFledge, and 'Parakeet',
blink::features::kParakeet. For PARAKEET the method stubs have been
added but will be fully fleshed out with proper types in a subsequent
change.
Test collateral has been updated to ensure the new surface area is
available and callable.
Bug: 1249186
We only referenced it to disable the feature, but we also disable the
SignedExchangeSubresourcePrefetch one, so we can simply drop that now.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/81c6aac468434ae4b96442ce11745e1ef828da04
commit 81c6aac468434ae4b96442ce11745e1ef828da04
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Tue Sep 21 02:10:28 2021 +0000
Remove SignedExchangePrefetchCacheForNavigations flag
This feature was merged into SignedExchangeSubresourcePrefetch.
Bug: 968427
This feature only enables the section related to FLoC in the settings
page brave://settings/privacySandbox, but such section is inaccessible
due to previous changes we made in cr95 to prevent Brave from enabling
prefs::{kPrivacySandboxApisEnabled,kPrivacySandboxFlocEnabled}, so
there's no functional change for us by simply letting it go.
In other words, the FLoC-related section will be visible if you
manually load brave://settings/privacySandbox[*], but you won't ever
be able to use it since you'd first need to enable the privacy sandbox
trials section, which can't be enabled now.
[*] There's no link to brave://settings/privacySandbox from Brave
settings UI, the user would need to manually load that URL.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/f7a688a187c6a18aa7b0e7d18d1a262c09089234
commit f7a688a187c6a18aa7b0e7d18d1a262c09089234
Author: Theodore Olsauskas-Warren <sauski@google.com>
Date: Mon Sep 13 09:08:58 2021 +0000
Privacy Sandbox 2: Remove flag & solidify code
CL removes the Privacy Sandbox 2 flag, which has been launched, and
solidifes the code paths controlled by the flag into their launched
state.
Bug: 1205781
PathService::Override() requires that the new target path exists,
and tries to create it if it doesn't. Since the user doesn't have
permission to create `/etc/brave` the override fails if an
administrator hadn't already installed something there, and the
original `/etc/chromium` path for policy files remains active.
Current uses of this path are few and seem to be robust against
the directory not existing, so this seems a safer fix than patching
the upstream default.
Closesbrave/brave-browser#19052
mkarolin