Previously, trying to generate a delta update with
--last_chrome_installer from the same source and target versions gave:
...
Did not find an archive input file for ".../chrome.dll"
Now we get:
Cannot create delta update files between the same source and target
version 99.1.38.5. Please increment the Chrome version (for
instance by rebasing your changes against a later upstream
version). Or pass files representing a lower version to
--last_chrome_installer.
This commit also fixes some pylint errors in the affected code.
This file is being copied over to Chromium's src/ directory as part
of the build process (i.e. the updateBranding step), and so checking
it is not needed.
Adapt the chromium_src overrides to the new locations under the common/
and public/common/ directories in Blink, add BLINK_COMMON_EXPORT to the
Brave-specific functions added to blink::origin_trials:: and fix the
paths in the script/check_chromium_src.py script.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/e4b14e32105c5a6912f5b1ff736ecbb796e2741b
commit e4b14e32105c5a6912f5b1ff736ecbb796e2741b
Author: Jason Chase <chasej@chromium.org>
Date: Mon Jan 17 16:00:25 2022 +0000
Move static origin_trials functions to blink/common
As in crbug.com/1227440, correctly checking if an origin trial is
enabled needs logic only available in the renderer. This CL is a first
step to make the logic available in the browser.
This CL moves the static functions in origin_trials.h|cc, including:
- Move origin_trials.h into blink/public/common
(and changes to Chromium types from WTF)
- Move generated origin_trials.cc file into blink/common
- Move navigation_origin_trials_features.cc into blink/common, keeping
the unique security owners
- Extract the generated OriginTrialFeature enum into its own header file
- Update all references to the moved files, removing any includes that
are no longer needed
Bug: 1227440
This first version provides the user a feature to add custom feed urls
to their preferences via the NTP "customize" button. Once added, feed
content will be downloaded on the same schedule as the current "combined
sources" single remote feed. The "direct feed" items will be scored using
approximately the same algorithm as the existing items, and displayed
using the existing Brave News feed view.
This PR does not introduce the relevant UI for Android, only Desktop.
Emerick Rogul