- The timing of registration is controlled by core backend
- Remove RegisterWalletDataFilesComponentOnDemand in Android
- Remove wallet_data_files_installer_android_util
Authored by @AlexeyBarabash:
- Added Android onboaring page fragment
- Removed unused staff around Android's percentage progress while download Wallet component
Chromium change:
https://github.com/brave/chromium/commit/d2cf18e9828940db691acf1aba1d90ecf12b848a
[Android] Move SharedPreferencesManager to //base
SharedPreferencesManager only needed to be //chrome-layer because
it has lists of the SharedPrefs keys used in Chrome. This CL:
- Detaches the key registry from the key checking
- Moves SharedPreferencesManager and Base/ChromePreferenceKeyChecker
to //base
- Leaves behind a temporary facade where //chrome
SharedPreferencesManager is until the migration is finished.
- Implements checking that all PreferenceKeyRegistries are
listed in AllPreferenceKeyRegistries
- Modifies ChromePreferenceKeysTest to check uniqueness across
all known registries
See go/base-shared-preferences for more details.
Bug: 1069897,1483469
There is no more glitch on Paint Preview from the upstream, so this
patch is obsolete.
Chromium change:
https://github.com/brave/chromium/commit/bc0349169ff178b7a3adbc127ef3e4db3e23824c
cleanup: Remove StartupPaintPreviewHelper.isEnabled
The method isEnabled() always returns true, and there is no plan to
change it. Remove the method and its callsite and beautify one unrelated
assert slightly.
Bug: 1321121
Chromium change:
brave/chromium@b244bd1
[Android] Assorted refactors of SharedPreferencesManager
- Make BaseChromePreferenceKeyChecker into a PreferenceKeyChecker
interface + NoOp impl for clarity.
- Simplify selection of which PreferenceKeyChecker to use.
- Remove StrictModeContext exceptions since there's another mechanism
to disable them for SharedPreferences.
- Other minor tweaks.
Preparing for move to //base.
Bug: 1483409
Chromium change:
https://github.com/brave/chromium/commit/2a587a94d143f4b3ffedf4e5d88d6b074d47f4fb
[DSE] Hide Feeds and its header according to DSE.
In this CL, Feeds and its header will be completely hidden if swapping
out NTP is enabled and DSE isn't Google. Therefore, the following
changes are made in FeedSurfaceMediator:
1. Add Pref:EnableSnippetsByDse to track whether the DSE is Google.
2. Once this pref is changed, we hide or show Feeds and its header.
3. Keep an observer of TemplateUrlService even when Feeds isn't
visible. Updates the pref value when DSE is changed.
Demo:
https://drive.google.com/file/d/1Q6MV5B2Fh79hyt0lbBaYoSO01H7ngxJP/view?usp=drive_link
Bug: 1475011
Chromium change:
https://github.com/brave/chromium/commit/2dde79ed20e6534fca02aa1216541df76f14c589
Delete IntentHandlerDelegate
processUrlViewIntent was only implemented by ChromeTabbedActivity and so
having ChromeActivity call IntentHandler#onNewIntent was confusing and
hard to reason about.
This change moves the ChromeTabbedActivity-only code from IntentHandler
into ChromeTabbedActivity.
Change-Id: I38e46830f66488a822ab3e2ec85d4f90d4fd9a52
Chromium change:
https://github.com/brave/chromium/commit/ddfa614c3740b47df416e7a944e4086f281c1bae
Relocate query extraction for SRO Query Edit to Native code.
The change is functionally a no-op.
Note: the change drops verification of validity of destination url in
native code. This is because the mechanism used to classify matches
has been replaced over the last few years with one that no longer
rewrites entire AutocompleteMatch.
Change-Id: I815dabcf16bca0cdffd8755f6aa54da17ad7e7a4
Chromium change:
https://github.com/brave/chromium/commit/74c1833620fbc342306cf9e1df0c457c8a2fa253
Make IntentHandler stateless
IntentHandler is made more confusing by most of it being stateless
statics, and some of it being stateful for an Activity. There's no
reason for it to be stateful, so simplify by making it stateless.
Change-Id: Ic4d6e3c823c149f2a0ae027503dc4c7516cceaaa
Darnell Andries