Commit Graph
1913 Commits
Author SHA1 Message Date
samartnik 897e2cdc44 [Android] Fixed colors for tab overview mode
Chromium change:
https://github.com/chromium/chromium/commit/7d60b1c52274b1b525a36db0986a1ea57c7ebf62

Enable DynamicColors through material_java.
Binary-Size: This is already being paid in downstream.
Bug: 1279417
2022-02-17 14:03:13 -05:00
samartnik 619db7dc77 [Android] Reverted some color changes
Chromium change:
https://github.com/chromium/chromium/commit/c722273c50f107eb62bd783505f1f19df7cb60ac

Revert "[GMNext] Migrate default_bg_color_dark_elev_N"
This reverts commit 391590f.

Reason for revert: crbug.com/1287000 , messages crash.

Original change's description:
> [GMNext] Migrate default_bg_color_dark_elev_N
>
>
> [GMNext] Migrate default_bg_color_light_elev_N to dynamic colors
>
> Migrate default_bg_color_light_elev_N to dynamic colors.
>
> Only usage can be handled with the SurfaceColorDrawable.
>
> Will handle night mode version in followup CL migrating
> default_bg_color_dark_elev_N.
>
> Bug: 1270911
> Change-Id: Id2931d815de83f3d0a57bbd104a65d2cd85c8f8b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343448
> Reviewed-by: Sky Malice <skym@chromium.org>
> Reviewed-by: Sinan Sahin <sinansahin@google.com>
> Reviewed-by: Theresa Sullivan <twellington@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Commit-Queue: Neil Coronado <nemco@google.com>
> Cr-Commit-Position: refs/heads/main@{#957734}

Bug: 1270911
2022-02-17 14:03:13 -05:00
samartnik 93d026a030 [Android] EnhancedProtectionPromo was removed
Chromium change:
https://github.com/chromium/chromium/commit/41634da65a822150bd1588d356ec0a57a1867f34

Remove code for EnhancedProtectionPromoCard on Android.
We have seen unexpected spike of the ESB promo monthly. Since the promo
has ended for several months, remove the source code in this CL.

Bug: 1269574
2022-02-17 14:03:07 -05:00
samartnik 17f9e76a0d [Android] Permissions link was removed from search engines
Chromium change:
https://github.com/chromium/chromium/commit/5b05dd6d54ca92c8e00ef8ce74f822cd722b8b3f

Cleanup autogranted DSE permissions
Since the work to revert DSE permissions has moved to 100% (cl/412714386)
there is no need to keep the logic that autogrants permissions to the
DSE.

This CL cleans all of the related logic, leaving only the bit that
reverts the autogranted permissions (if they are present) and bits
related to the DSE origin that don't have anything to do with the
permissions specifically (which are still used for the X-Geo) header.

Bug: 1270216
2022-02-17 14:03:06 -05:00
samartnik 2fb34a1937 [Android] New option in privacy section
Chromium change:
https://github.com/chromium/chromium/commit/bca0e9d42ddad33535f57be581a4e62febcc609f

webauthn: add setting for clearing linked phones on Android.
This change adds an entry to Clank's privacy settings for clearing
linked desktops after the phone has been used as a security key. (See
mocks[1].) The entry is guarded by a feature flag and is invisible for
now.

https://docs.google.com/presentation/d/1zZcfcIN2QxxHDBqQt0SJ8UtSPwgPmJx_3MwkOFpOQf8/edit#slide=id.gf8628bc8ab_1_156

Change-Id: I5a9b9ca352e825c5ec976826a5ee61e8cbc4e56a
2022-02-17 14:03:06 -05:00
samartnik 068aa1e838 [Android] Fixed broken new tab page
Chromium change:
https://github.com/chromium/chromium/commit/d90bd15798ffa73e85b33139ae1b71561398aafa

Remove mStream and scrollviewforpolicy from FeedSurfaceCoordinator
Bug: b/202872534
2022-02-17 14:03:05 -05:00
samartnik 4722f4ebc3 [Android] Modularized logo
Chromium change:
https://github.com/chromium/chromium/commit/de614aadd072a1cc42e4be84508d22706aa07804

Modularize logo/
See go/clank-modularization-logo for more info.

Bug: 1261631
2022-02-17 14:03:04 -05:00
samartnik 7627ed5873 [Android] Fixes for removed and renamed resources 2022-02-17 14:03:00 -05:00
samartnik f965f2e73e [Android] Tab overview animation was simplified
Chromium change:
https://github.com/chromium/chromium/commit/94a231f90d89f9af2996172fae508f9472d573cb

Remove unused rendering code in TabLayout
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/3388174
and continues to simplify the Tab rendering logic for phones.

Also deletes anything related to tilting/rotating and card backs for the
tabs.

Bug: 1287653
2022-02-17 14:03:00 -05:00
samartnik 1d93f69ea0 [Android] New c-tor signature for LayoutManagerChrome
Chromium change:
https://github.com/chromium/chromium/commit/0d0895af67ad844e5292c4640a3b0fffbdf44839

[Jank] Make LayerTitleCache Tablet-only.
Noticed while looking at a startup/jank issue that we were creating the
LayerTitleCache. Now that we only ever use the java tab-switcher on
Phones, I opted to nuke it entirely from non-tablet UI.

Along the way, I moved ownership entirely out of CompostorViewHolder and
into LayoutManagerChromeTablet.

Change-Id: Ifaff8a7fc6eb507d0b7edd688a493103a55d2730
2022-02-17 14:02:59 -05:00
samartnik 126b4c13f2 [Android] New functions in SigninManager
Chromium change:
https://github.com/chromium/chromium/commit/85aab36a5628ebd3ab259068954f982eeff2b1bc

Update SigninChecker to not enable sync for Unicorn users
This updates the SigninChecker implementation to not enable sync when
signing in a Unicorn user in the background (flag-guarded).

Later CLs will update SyncController.java and the FRE screens to also
not force enable sync.

Bug: 1285310
2022-02-17 14:02:58 -05:00
samartnik 4812cec3aa [Android] Tab switcher top toolbar code reorganization
Chromium change:
https://github.com/chromium/chromium/commit/b0c82063f830bba93b58db749855cef8f16d6c02

[Refactor] Rename tab switcher top toolbar to not be phone specific
Bug: 1286780
2022-02-17 14:02:57 -05:00
samartnik 23bceb6c36 [Android] createChromeContext was moved
Chromium change:
https://github.com/chromium/chromium/commit/2a774859aecae9ae788ef3a07e5294bf2d265e51

Move SplitCompatUtils into //base
This needs to be moved so it can be used by the autofill_assistant
component. The createChromeContext method was moved into
SplitChromeApplication.

A follow up will remove the old SplitCompatUtils class once all internal
references are removed.

Bug: b/183478921
2022-02-17 14:02:56 -05:00
samartnik b7a9a8156b [Android] logo_card_back was removed
Chromium change:
https://github.com/chromium/chromium/commit/94a231f90d89f9af2996172fae508f9472d573cb

Remove unused rendering code in TabLayout
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/3388174
and continues to simplify the Tab rendering logic for phones.

Also deletes anything related to tilting/rotating and card backs for the
tabs.

Bug: 1287653
2022-02-17 14:02:56 -05:00
samartnik 9f8078280d [Android] Added usage of ChromiumNetworkAdapter
This fixes these warnings:
../../brave/android/java/org/chromium/chrome/browser/rate/RateFeedbackUtils.java:76: warning: [UseNetworkAnnotations] Direct use of URL#openConnection() is forbidden in Chromium. Use ChromiumNetworkAdapter#openConnection() instead.

			urlConnection = (HttpURLConnection) url.openConnection();

			                                                     ^

    (see https://bugs.chromium.org/p/chromium/issues/detail?id=1231780)

../../brave/android/java/org/chromium/chrome/browser/shields/BraveShieldsUtils.java:124: warning: [UseNetworkAnnotations] Direct use of URL#openConnection() is forbidden in Chromium. Use ChromiumNetworkAdapter#openConnection() instead.

                urlConnection = (HttpURLConnection) url.openConnection();

                                                                      ^

    (see https://bugs.chromium.org/p/chromium/issues/detail?id=1231780)

In addition properly formatted RateFeedbackUtils.java file

Chromium change:
https://chromium-review.googlesource.com/c/chromium/src/+/3321445

[Net][Android] Add and use ChromiumNetworkAdapter

This is a wrapper around URL#openConnection() that requires a
NetworkTrafficAnnotationTag, which is used for static analysis.
A future change will add compile-time checks to prevent direct usage
of URL#openConnection().

Replace all URL#openConnection() calls with
ChromiumNetworkAdapter#openConnection().

More blocklisted methods are likely to be added in the future.

Bug: 1231780
2022-02-17 14:02:44 -05:00
samartnik c453fc3987 [Android] Adjusted code for new color management
Chromium change:
https://chromium-review.googlesource.com/c/chromium/src/+/3351221

Reland "[GMNext] Update ThemeColorProvider to use OmniboxTheme"

This is a reland of 16fdb849a961bef58fb236a12ecb9ad7727c1a6d

Original change's description:
> [GMNext] Update ThemeColorProvider to use OmniboxTheme
>
> This CL updates the icon tint in some classes to follow OmniboxTheme
> instead of the simple light/dark tint. It also moves OmniboxTheme out
> of chrome/browser/omnibox to be able to use it in classes outside
> omnibox/.
>
> Bug: 1233725, 1114183
2022-02-17 14:02:43 -05:00
samartnik 8ccf80a958 [Android] Removed obsolete param for TabModel setIndex 2022-02-17 14:02:37 -05:00
samartnik 48d9d8860b [Android] Changes for accent1 color
Chromium change:
https://chromium-review.googlesource.com/c/chromium/src/+/3331374

[GMNext] Make primary inverse text colors dynamic

Bug: 1233703, 1241971
2022-02-17 14:02:36 -05:00
samartnik 31f19a4653 [Android] New param for updateBookmarkMenuItemShortcut
Chromium change:
https://chromium-review.googlesource.com/c/chromium/src/+/3296726

Make bookmark shortcut appear in custom tab

When customizing the app menu for Reading List the bookmark button was
dropped from the app menu list for custom tabs.

Bug: 1265745
2022-02-17 14:02:35 -05:00
Anirudha Bose 211783b70d Merge pull request #12267 from brave/f/wallet/arbitrum-bug
Fix incorrect gas limit computation on Arbitrum
2022-02-16 23:10:57 +05:30
Anirudha Bose 6d3596e5fc feat(wallet): bubble up ApproveTransaction error message to clients 2022-02-16 16:17:00 +05:30
Serg eeda0826f8 Adds a check on add EVM error when chain_id isn't exist on Android 2022-02-15 22:46:25 -05:00
Jocelyn Liu 8ad00551bd Fix android build to use TxService and EthTxManagerProxy interfaces 2022-02-15 10:17:33 -08:00
alexsafe 6b99c00598 Merge pull request #12255 from brave/bravenews-android-bg-position
[Android] - Brave news fixes for background image crop and cards positioning
2022-02-15 12:32:35 -05:00
Kamil Jozwiak 7119d9b7b1 Merge pull request #12250 from brave/98.0.4758.102_master
Upgrade from Chromium 98.0.4758.87 to Chromium 98.0.4758.102.
2022-02-15 11:55:42 -05:00
Alex C 4c89f5bcc1 [Android] - Brave news fixes for background image crop and cards positioning 2022-02-15 11:30:16 -05:00
Jocelyn Liu a99b2b06c7 Fix java build errors after change TransactionInfo.txData to an union 2022-02-14 20:21:26 -08:00
samartnik 049761ea44 [Android] New c-tor signatures for various classes 2022-02-14 20:27:24 -05:00
Pavneet Singh c2e0a8c85d Merge pull request #12225 from brave/restore-wallet-option-visual-changes
visuals udpates of restore wallet option
2022-02-15 01:13:49 +05:30
Anthony Tseng 50230a4644 Fix revealing private key for non ETH keyrings 2022-02-11 17:13:02 -08:00
Deep Pandya 550b1a674d Merge pull request #12179 from brave/update_auto_contribution_summury
Resolve auto contribution summary
2022-02-11 09:37:11 -05:00
Deep Pandya 4051b0e135 Merge pull request #12197 from brave/hide_rewards_from_ads_for_disconnected_state
Hide rewards from ads for diconnected state
2022-02-11 09:36:58 -05:00
Deep Pandya 96a60b5481 Merge pull request #12182 from brave/resolve_rewards_icon_issue
Resolve rewards icon issue
2022-02-11 09:35:32 -05:00
wchen342 61b5ffd739 Merge pull request #12209 from brave/nw_swap_tofrom_fix
Fix Swap from can be same as swap to
2022-02-11 15:25:01 +02:00
Pavneet-Sing 282e48cc8f visuals udpates of restore wallet option 2022-02-11 18:24:11 +05:30
wchen342 cd34a8ddbe Fix Swap from can be same as swap to 2022-02-11 14:29:52 +02:00
Anthony Tseng 93aa6bc186 1. ImportAccount now requires CoinType
2. Add importing Solana private key support (without UI hookup)
2022-02-10 21:30:42 -08:00
Deep eaa489de7b Migrate pref 2022-02-10 15:46:10 -05:00
Tapan Modh 26500ac420 Merge pull request #12191 from brave/set_default_browser_followup_android
Set default browser followup android
2022-02-11 00:16:00 +05:30
Serg 76b9fc7246 Fixes after code review 2022-02-10 08:19:19 -05:00
Serg e358ffbb8a Various fixes for Android EVM networks feature 2022-02-09 21:58:53 -05:00
tapanmodh c9afb8c699 Show in app set default with rolemanager in case of onboarding only 2022-02-10 03:33:12 +05:30
tapanmodh 83a999782d Show in app set default with rolemanager in case of onboarding only 2022-02-10 02:04:54 +05:30
Deep b4fad2047d Hide rewards from ads for diconnected state 2022-02-09 12:42:20 -05:00
wchen342 7afac0a768 Merge pull request #12186 from brave/nw_token_populate
[Android] Auto populate custom token info
2022-02-09 19:23:22 +02:00
wchen342 a558e7ed98 Add custom asset query 2022-02-09 16:39:56 +02:00
Deep c9f225b8e3 Resolve rewards icon issue 2022-02-08 11:19:21 -05:00
tapanmodh f19b70b1e5 cleanup 2022-02-08 21:33:13 +05:30
tapanmodh e0c2e3dfad Show in app set default with rolemanager in case of onboarding only 2022-02-08 21:26:19 +05:30
Deep f56afa6c56 Resolve auto contribution summary 2022-02-08 10:21:28 -05:00