Commit Graph
108 Commits
Author SHA1 Message Date
samartnik b097f5cad4 [Android] Added check for Tab switcher on return flag 2022-09-19 17:27:52 -04:00
tapanmodh 48776e9daf fix crash omnibox search banner android 2022-08-30 15:53:06 +05:30
tapanmodh 093146ccd8 QR code scanner in addressbar android 2022-08-25 11:07:41 +05:30
samartnik daba95ebfe [Android] Removed unused proguard rules for tests 2022-08-23 00:19:32 -04:00
tapanmodh ed85fae506 fix bytecode test error 2022-08-05 19:06:03 +05:30
tapanmodh f79921977b move BraveFeatureList class to base package 2022-08-05 02:22:26 +05:30
tapanmodh 54c44d2352 Address PR Comments 2022-08-04 13:34:05 +05:30
tapanmodh b5beef9b6a omnibox brave search promo banner android 2022-08-03 01:43:35 +05:30
deep d11e04015d ADd proguard rule for bytecode tests 2022-07-27 02:58:27 -04:00
samartnik b9f42a42b4 [Android] Changes for NTP tile placeholder visibility
Chromium change:
https://github.com/chromium/chromium/commit/3398005c11bdb96e470cb07a5dca2636ca2284ca

[Feed Position] Implement Feed position experiment.
Screenshots: go/feed-position
Design: https://www.figma.com/file/SpRarIfqrDIEu4qPJkZPJv/Clank-Start-Next?node-id=2%3A251

Bug: 1329288
2022-07-22 13:33:54 +01:00
samartnik 72383792c3 [Android] Partnerbookmarks removed from AppHooks
Chromium change:
https://github.com/chromium/chromium/commit/8e847d0c7d98bedcf2972f02e92ea607885dd396

Remove partnerbookmarks from AppHooks
Bug: 1291655
2022-07-22 13:33:54 +01:00
samartnik 1d46128834 [Android] New UI for send tab to self
Chromium change:
https://github.com/chromium/chromium/commit/8f81d7723f510c99bb651770b6d731d2fdf486c1

[send-tab-to-self/android] Add account UI to "no target devices" sheet
Behavior changes are behind a feature flag disabled by default.
This footer was already present in the device picker, now it's present
on the "no target devices" UI too.
Mock is "Option 2" here: https://docs.google.com/presentation/d/1w4me9wINwMW2UD-uuSQGMKiWuqkX9GDfAFvSM74Pt00/edit#slide=id.ge2c74ccf3a_0_4

Bug: 1219434
2022-07-22 13:33:53 +01:00
samartnik edd2a3de51 [Android] Adjustments for the new NTP logic
Chromium change:
https://github.com/chromium/chromium/commit/7cb8a555783cc1f16b556f48ea38a4fa4007fd26

Privacy Sandbox Settings: Add NTP trigger logic
Context: https://docs.google.com/presentation/d/1TCC2O1IxK21KRQhc5uFkIvM4c7VIalZi_nLhb7w5pik/edit?resourcekey=0-4tlhVROV5bI0owhRo9pMAw#slide=id.g12547eb8187_0_18

Bug: 1286276
2022-07-22 13:33:53 +01:00
samartnik 12cdbcc6e6 [Android] Potential fix for crash on attempting to upload minidump 2022-07-19 10:19:18 -04:00
samartnik f0337cf558 [Android] Made simplified view popup to respect accessibility option 2022-07-05 08:23:12 -04:00
AlexeyBarabash d3fa383510 Disable reading list sync preference on Android
fixes brave/brave-browser#23084

Related Chromium change:
https://github.com/chromium/chromium/commit/92c74c166b472ff78318ac1fa3b86f83c0ae2090

[M103] Add missing READING_LIST toggle to Android sync settings
More details on the linked bug. This is only a temporary solution, the
long-term one should be to address crbug.com/1067282, i.e. auto-generate
the UI from the UserSelectableType enum.

Desktop and iOS follow no particular order for the toggles, so this
CL picks something close to the desktop order crbug.com/1326825#c1.

(cherry picked from commit c4ebfbf)

Fixed: 1326825
Change-Id: I185984fc154eb222bf9a09210d2b3face4884bea
2022-06-10 05:58:25 -04:00
samartnik 23e0f15b34 [Android] New changes for FeedSurfaceCoordinator
Chromium change:
https://github.com/chromium/chromium/commit/ff81de2378f2e5b5842d0b21d2adf75dbaa0ca7f

Feed: add logging for more feed launch cancel cases
* NAVIGATED_AWAY_IN_APP: logged when the user follows a non-feed-content link during the feed launch. For the NTP it is logged from our TabObserver.onPageLoadStarted(); it will need to be done differently for Start Surface since the feed isn't in a tab.
* NAVIGATED_BACK: logged when "back" is pressed causing the feed surface to disappear during feed launch. A later change will log it for NTP and Start.
* NAVIGATED_TO_ANOTHER_TAB: User went to another tab during feed launch. This isn't normally what we mean by "navigate" but the name came from logging in the other Discover surfaces.

The NTP and Start changes in this CL just plumb a TabModelSelector to FeedSurfaceCoordinator. Later CLs will hook up the specific logging described above for each surface.

Bug: 1195940
2022-06-10 05:58:24 -04:00
samartnik 8ff8bf141d [Android] New UI for most visited sites II
Chromium change:
chromium/chromium@a8e63bc

Refactor most visited tiles codes and make it MVCed.
See go/refactor-mvt for more info.

Bug: 1303459
2022-06-10 05:58:23 -04:00
samartnik 14332c6520 [Android] Fixes for unit tests 2022-06-10 05:58:23 -04:00
samartnik f9391cd4b8 [Android] OverviewMode* classes were removed
Chromium change:
https://github.com/chromium/chromium/commit/596552c5837326e9858d5d30974ebfa1235c6ff9

Remove OverviewMode* classes
This patch removes OverviewModeBehavior and its observers. Code that
was still using these classes had easy access to the LayoutManager
which could be used in its place.

Bug: 1108496
2022-06-10 05:58:22 -04:00
samartnik b6b99ccc10 [Android] Polish toolbar for first relaunch and a11y switcher
Chromium change:
https://github.com/chromium/chromium/commit/1b9e3f25fadc72b743c4529e1870453f594b9d86

[TabletGTS] Fix polish toolbar for first relaunch and a11y switcher
Fix polish toolbar for first relaunch and a11y switcher.
-Pass both the fullscreen and non-fullscreen tab switcher toolbar stubs
 when the polished tablet GTS is enabled.
-Choose which one to use based on our flag and if the a11y list switcher
 is enabled.

(cherry picked from commit 50515c1)

Bug: 1312980, 1317611
2022-05-13 18:01:44 +01:00
samartnik 852a600f71 [Android] Fixed assert on url bar focus change
Chromium change:
https://github.com/chromium/chromium/commit/b964b99f01113d8f0107f81cbdea03c98429e874

Add logic to track suggestions list scroll events.
This change allows us to learn how frequently our users need to
scroll the suggestions list in order to find what they are looking
for.

Bug: 1291761
2022-05-13 18:01:44 +01:00
samartnik a65564459a [Android] Changes for partner customizations
Chromium change:
https://github.com/chromium/chromium/commit/254d31968ece2b5bb58984ed2f79ae01d001c9d1

Remove partnercustomizations AppHooks dep and modularize code
* Remove AppHooks dependency for partnercustomizations.
* Move partnercustomizations code to its own module.
* Move test rules to the partnercustomizations module and setup BUILD.
* Move tests to the partnercustomizations module.

Bug: 1291657
2022-04-15 18:26:38 -04:00
samartnik 144dd60425 [Android] Fixed crash on sending tabs to another device 2022-04-06 15:27:56 -04:00
Serg 95eac8e507 Adds Android unit tests for some mojo structures that we use 2022-03-24 12:09:16 -04:00
Serg d3692f8872 Fixes a crash on Edit visible assets button click and adds a test for new fields in BlockchainToken structure 2022-03-24 12:02:10 -04:00
samartnik ba2f8712ef [Android] Fixes for unit tests 2022-03-18 20:04:07 -04:00
samartnik bc5bd48e26 [Android] Updated Android sync setting
Chromium change:
https://github.com/chromium/chromium/commit/e570e9fcc8636087a0ac7cd09b6f9cfb5b142c1d

Update Android sync dashboard text to match Desktop and ChromeOS
This string change brings Android in sync with the Desktop and ChromeOS
string (see IDS_SETTINGS_NEW_MANAGE_SYNCED_DATA_TITLE_UNIFIED_CONSENT).

Bug: 1295309
2022-03-18 20:04:05 -04:00
samartnik f3c190a17c [Android] AndroidSyncSettings was removed
Chromium change:
https://github.com/chromium/chromium/commit/6b20a8bea7e759dad5741b7cffcb5d563be92c32

Remove shallow AndroidSyncSettings
No behavior is changed. The class doesn't contain any logic anymore
following crrev.com/c/2988181.
Just replace calls to it with the underlying SyncService calls.

Bug: 1107904
2022-03-18 20:03:54 -04:00
samartnik b236c82562 [Android] Fixed variations server for FRT pre-fetching data 2022-02-18 14:42:01 -05:00
samartnik e3abd222d4 [Android] Removed stack layout code
Resolves https://github.com/brave/brave-browser/issues/21005

Chromium change:
https://github.com/chromium/chromium/commit/94a231f90d89f9af2996172fae508f9472d573cb

Remove unused rendering code in TabLayout
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/3388174
and continues to simplify the Tab rendering logic for phones.

Also deletes anything related to tilting/rotating and card backs for the
tabs.

Bug: 1287653
2022-02-17 14:03:25 -05:00
samartnik 897e2cdc44 [Android] Fixed colors for tab overview mode
Chromium change:
https://github.com/chromium/chromium/commit/7d60b1c52274b1b525a36db0986a1ea57c7ebf62

Enable DynamicColors through material_java.
Binary-Size: This is already being paid in downstream.
Bug: 1279417
2022-02-17 14:03:13 -05:00
samartnik 93d026a030 [Android] EnhancedProtectionPromo was removed
Chromium change:
https://github.com/chromium/chromium/commit/41634da65a822150bd1588d356ec0a57a1867f34

Remove code for EnhancedProtectionPromoCard on Android.
We have seen unexpected spike of the ESB promo monthly. Since the promo
has ended for several months, remove the source code in this CL.

Bug: 1269574
2022-02-17 14:03:07 -05:00
samartnik 17f9e76a0d [Android] Permissions link was removed from search engines
Chromium change:
https://github.com/chromium/chromium/commit/5b05dd6d54ca92c8e00ef8ce74f822cd722b8b3f

Cleanup autogranted DSE permissions
Since the work to revert DSE permissions has moved to 100% (cl/412714386)
there is no need to keep the logic that autogrants permissions to the
DSE.

This CL cleans all of the related logic, leaving only the bit that
reverts the autogranted permissions (if they are present) and bits
related to the DSE origin that don't have anything to do with the
permissions specifically (which are still used for the X-Geo) header.

Bug: 1270216
2022-02-17 14:03:06 -05:00
samartnik 068aa1e838 [Android] Fixed broken new tab page
Chromium change:
https://github.com/chromium/chromium/commit/d90bd15798ffa73e85b33139ae1b71561398aafa

Remove mStream and scrollviewforpolicy from FeedSurfaceCoordinator
Bug: b/202872534
2022-02-17 14:03:05 -05:00
samartnik 4812cec3aa [Android] Tab switcher top toolbar code reorganization
Chromium change:
https://github.com/chromium/chromium/commit/b0c82063f830bba93b58db749855cef8f16d6c02

[Refactor] Rename tab switcher top toolbar to not be phone specific
Bug: 1286780
2022-02-17 14:02:57 -05:00
samartnik d27bb48aab Revert "[Android] Made context menu option 'Open in new tab' visible"
This reverts commit 924427f4a3.
2022-02-03 14:41:19 -05:00
samartnik 924427f4a3 [Android] Made context menu option 'Open in new tab' visible 2022-02-03 09:17:02 -05:00
Tapan Modh 7093cba800 Merge pull request #12093 from brave/set_default_browser_android
Set default browser improvements android
2022-02-03 02:39:32 +05:30
tapanmodh 817e37ee73 added method defination in proguard for BytecodeTest 2022-02-03 01:47:28 +05:30
samartnik 35d8af6e4c [Android] Fixed NTP with Google as dse 2022-01-27 17:15:46 -05:00
samartnik 770ffce1bf [Android] Added option that controls url bar suggestions 2022-01-07 20:17:03 -05:00
samartnik 86959248bf [Android] Reorganized code to avoid patching for bytecode warnings
This reverts previous commit:

[Android] Filter warning after bytecode pacthing
With new R8 library there is a warning related to our bytecode patching:
Warning: Missing method void Lg2.d() (referenced from: void Vf2.run())

Without obfuscation it looks like this:
Warning: Missing method void org.chromium.chrome.browser.toolbar.ToolbarManager.$invoke$special$updateButtonStatus() (referenced from: void org.chromium.chrome.browser.toolbar.ToolbarManager$$ExternalSyntheticLambda3.run())

We do change invoke special to invoke virtual for this method and this is expected.

Chromium change:
chromium/chromium@e3db48a

Android: Stop disabling R8's allowaccessmodification -keep semantics
Causes a 5.5kb regression, but brings us closer to stock R8, and will
ensure visibility of test @rule fields are not changed, thus avoiding
bugs like bug 1265431.

Bug: 1265431
2021-12-07 14:45:58 -05:00
samartnik fc713f6102 [Android] Changes for FeedSurfaceCoordinator
Chromium change:
https://github.com/chromium/chromium/commit/902c97b0859b9a0126bc6dfd5f1b0f5e3897a031

feed modularization: move ntp.snippets to feed.sections
Also:
* removed the obsolete '!mHasHeader' logic in start
  surface.
* Moved creation of section header view into
  FeedSurfaceCoordinator.

Bug: 1254437
2021-12-07 14:45:11 -05:00
samartnik ec4506cca7 [Android] Adjusted position for autofill suggestions 2021-11-19 13:14:00 -05:00
samartnik 7c57d3b276 [Android] Fixes for new tab overview theme
Chromium change:
https://github.com/chromium/chromium/commit/b364155d8f3c7e0085f510d7d0c6b9f5c9cf0a0a

Enable ThemeRefactorAndroid by default.
Bug: 1251194
2021-11-02 12:38:04 -04:00
samartnik 594ca313a1 [Android] Added proguard rules for tests 2021-10-04 17:05:23 -04:00
wchen342 d21977e52d patch and bytecode test fixes 2021-09-27 21:40:21 +03:00
samartnik 1bafd71181 [Android] Added option to disable sharing hub 2021-09-24 16:41:56 -04:00
samartnik 0b57ee430d [Android] Changes for toolbar color retrieval
Chromium change:
https://chromium.googlesource.com/chromium/src/+/020d9a658e7ae62272fcbcf66868c51c13b9779b

Update omnibox with dynamic colors

This CL updates methods that provide the primary color or the background
in utility classes such as ChromeColors and ThemeUtils to use Context
instead of Resources.

Bug: 1217157
2021-09-13 14:53:32 -04:00