Commit Graph
10 Commits
Author SHA1 Message Date
Artem Samoilenko ff0709ce40 [Android] Enabled private tabs lock with UI changes 2023-10-30 08:12:59 -04:00
Artem Samoilenko b09d7ac360 [Android] Disable Baseline Surface Colors
These colors mess up with Brave theme, so we disable them for now.

Chromium change:
https://github.com/chromium/chromium/commit/994591b18af84bbbc21d8549d6f3dc97b767c3a5

[BaselineSurfaceColors] Enable Baseline Surface Colors change by default
Enable Baseline Surface Colors change by default.

See 100% stable approval at http://launch/4218139. Will enable by
default on ToT to provide max_version for finch experiment.

Will cleanup flag checks, etc. separately.

Bug: 1451864
2023-07-26 16:50:42 -04:00
Artem Samoilenko 26668ce390 [Android] Changes for CachedFlag IsEnabled method
Chromium change:
https://github.com/chromium/chromium/commit/1ce30b46f0d225c5063d0db14d423df8d8ea230e

[Android] Move lists of CachedFlags from ChromeCachedFlags
ChromeFeatureList now contains the lists of CachedFlags (and the
CachedFlags themselves).

It is necessary to have a list of all CachedFlags in
ChromeFeatureList, since we need to map the feature name to the
legacy shared preference key in the CachedFlag when:
1. Setting up test values via @EnableFeatures/@DisableFeatures
    * Currently done through CachedFeatureFlags#setForTesting, but
      requires CachedFeatureFlags to know legacy SharedPrefs key
      overrides, which blocks its migration to //base.
2. Called via Java_CachedFeatureFlags_IsEnabled()
    * Currently uses the default from native passed as a param through
      JNI.

This also adds a test to ensure flags aren't declared and not cached,
which is a common pitfall.

Bug: 1442347
2023-06-19 16:00:17 -04:00
Artem Samoilenko bf529821bc [Android] Java code adjustments to C115 upstream changes 2023-06-19 16:00:16 -04:00
Artem Samoilenko 0290152611 [Android] Temporarily disable lock for private tabs feature
Disable until we sort out UI issues https://github.com/brave/brave-browser/issues/29688
2023-04-17 11:46:48 -04:00
Simone Arpe 39cf09370b Fix copyright header (#18011)
Replaces `http` protocol with `https` in the copyright header for Java and XML files.
2023-04-12 15:10:02 +02:00
Artem Samoilenko b709c0c510 [Android] Enable lock for private tabs feature 2023-04-05 12:08:26 -04:00
samartnik af82aedaaf [Android] Disabled StartSurfaceAndroid II
We don't nedd it as we implement NTP in our own way

Chromium change:
chromium/chromium@8d376e3

Reland: [Start] Enable feature StartSurfaceAndroid by default.
The original CL got reverted due to test failures: crbug.com/1359954.
These failing tests are fixed in:
1. https://chromium-review.googlesource.com/c/chromium/src/+/3880682
2. https://chromium-review.googlesource.com/c/chromium/src/+/3877423
3. https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/4971322
4. https://chromium-review.googlesource.com/c/chromium/src/+/3888100

Bug: 1356180, 1359954
2022-10-13 16:51:36 -04:00
samartnik d27bb48aab Revert "[Android] Made context menu option 'Open in new tab' visible"
This reverts commit 924427f4a3.
2022-02-03 14:41:19 -05:00
samartnik 924427f4a3 [Android] Made context menu option 'Open in new tab' visible 2022-02-03 09:17:02 -05:00