-Validate exclusions.
-Do not skip #defines that have no replacement values.
-Expect #define to be at the beginning of the line.
-Check for corresponding #undef.
-Check for #defines that are used internally in the override and ignore
those.
-Always check #includes.
-v8/src #includes can start wit src.
-Return success/error code.
-Strip comments from sources and overrides to avoid finding symbols in comments.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/79ca9265d25f26dd9dc3c8fad2a72241054e14ae
commit 79ca9265d25f26dd9dc3c8fad2a72241054e14ae
Author: Henrique Ferreiro <hferreiro@igalia.com>
Date: Wed Aug 23 10:17:33 2023 +0000
Simplify the build for branded strings
Branded strings are defined in *chromium_strings.grd and
*google_chrome_strings.grd files. Both kind of files contain different
messages for the same ids. Those ids are compiled into generated header
files by their corresponding targets. Both the targets and the header
files are named differently, similarly to the grd files. This requires
that the correct target and header file is used depending on the build
but, in practice, most code sites just depend on both targets and
include both header files.
This CL merges those targets so that from now on only the chromium
version is used (e.g.
//chrome/app:chromium_strings and chrome/grit/chromium_strings.h,
//components/strings/component_chromium_strings and
components/strings/grit/components_chromium_strings.h, etc.). The
targets are parameterized by `branding_path_product` so that the correct
grd and pak filenames are used.
Future CLs will change the targets and generated files to be named
*branded_strings.
Bug: 1470725
Upstream has added support to multiple license files per library, which
requires we change our own list of license paths to be a list.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/96c24160096388835ce0e46deb1beff3c9ce1b5e
commit 96c24160096388835ce0e46deb1beff3c9ce1b5e
Author: Anne Redulla <aredulla@google.com>
Date: Mon Jun 26 01:13:43 2023 +0000
[ssci] licenses.py to handle multiple license files
Bug: b:288202522
Move bip39wally-core-native to third_party/
This change moves bip39wally-core-native to be under third_part, to
avoid clang plugin checks from being enforced on this library's code.
This is in preparation for the switching on of `raw_ptr<T>` checks in
M114.
The reason for the bug was that GetPrevVersion in create_installer_archive.py
extracts the previous version's chrome.dll file *into the staging directory*.
This has the side effect of placing the .dll into chrome.7z, which serves as the
target during delta update generation. When the (first) delta then gets applied,
the old .dll gets placed in chrome.7z in Brave's installation directory. When
the second delta then runs, it sees an unexpected hash of chrome.7z and fails.
This commit replaces the implementation of GetPrevVersion with one that does not
have the unwanted side effect.
The code in challange bypass was attempting to emulate exceptions by
having an error stored in a global local thread state. This is
undesirable, and we should prefer to have failure signaled through
constructs like `base::expected`.
This commit adjusts the return types of all functions that are expected
to fail, and also deletes all exception related code.
Max Karolinskiy