Chromium change:
https://source.chromium.org/chromium/chromium/src/+/4e0c6f2ed20a06683a32e6ac271d29cdad5729e7
[Minimal UI] Disable minUI controls when secondary UI is shown
This CL has two parts, the first one changes back and reload buttons
contract - now instead of #setEnabled method they require to pass
an boolean ObservableSupplier that allows easier synchronization of
internal button state with external states, for example, dialogs overlay
while page is loading.
`setEnabled` API forces button to synchronize access internally by
managing access token, but as more controls will be added, more
tokens will be held in a parent. Instead a single token can be
managed by parent container, because individual enabled state is
a rare case and still can be added on top of the proposed API.
The second part adds ModalDialogManager into web app header.
Header listens to shown dialogs and enables/disables controls when
ovelaid with any. As soon as dialog queue is drained, controls will be
enabled back.
Bug: 412910949
Change-Id: Ice3ee83637d9a88c4c2c84dd4fd167a3ebe8b82b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6499077
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/c59eeff40f493459618031de68c3abdc932d1d8d
Reland "[Android] Support multi-window in Public Transit tests"
This is a reland of commit 9527df220a190af84652625ff34f44ea0ad927e4
Changed: Restricted test to non-Auto as it does not support
multi-window.
Bug: 414438679,415935250
Change-Id: I368b5a5f260050c2c4e200df0aa93c99c4687991
Original change's description:
> [Android] Support multi-window in Public Transit tests
>
> - TrafficControl now accepts 0+ Stations as active instead of 0-1.
> - ActivityElement waits for an Activity in the same window or on a
> different one, depending on the transition (or any window in the
> first transition.
> - Station now has #spawnSync to transition into a Station in a new
> Window without leaving the current Station in the existing Window.
> - Add MultiwindowAppMenuTest using all of this to test the 'New
> Window' menu item in Tablets.
>
> Bug: 414438679
> Change-Id: If963b5d3bb845eb8a71e22c448b2687b71eeffc7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6488661
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: Aishwarya Rajesh <aishwaryarj@google.com>
> Owners-Override: Henrique Nakashima <hnakashima@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1455965}
Change-Id: I368b5a5f260050c2c4e200df0aa93c99c4687991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6513365
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/55bc1473c10ac7470c2c2133d26d69c936bdc502
[Minimal UI] Add ThemeColorProvider for browser services
Adding a new ThemeColorProvider that targets browser services
primary color calculations based on the web app manifest and
Chrome default theme. It doesn't add anything new in color calculations
themselves, but rather extracts existing logic from
CustomTabColorController to share with other UI controls like web app
header.
Focused/unfocused primary color will be implemented in scope of
another task.
Bug: 396101424
Change-Id: I2ee3712725e9e1069a1e30c9dccbd33a4af8ce1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6487756
* Tweak background video playback description in flag page
* Remove redundant call to allow Javascript injection
The method `content::RenderFrameHost::AllowInjectingJavaScript()` is already called in
`background_video_playback_tab_helper` for those domains that correctly have a match so
it's not needed in `brave_browser_main_parts`.
* Fix boolean logic
* Make `IsBackgroundVideoPlaybackEnabled` method more readable
* Remove unneeded predefined default value from XML
* Refactor logic and remove old code
* Enable background video playback preference by default
* Remove unused constant
* Remove usage of `BravePrefServiceBridge` for boolean background video playback
* Use mTabModelProfileSupplier as settings UI always use original profile
* [Android] New Mobile Bookmarks homepage setting
* [Android] Mobile bookmarks string correction
* [Android] Code review suggestions
* Replaces direct patch with bytecode and adds eol
* Moves test method from dummy to the main class
* Direct patch xmls and typo fix
* BaseJUnit4ClassRunner to ChromeJUnit4ClassRunner for tests
* Fixes presubmit issues for tests
Chromium change:
https://chromium.googlesource.com/chromium/src/+/b875fe9e2f6b613d0207655bd970a34427210f0d
[Android][3PPWM] Ignore IsEnabled and load config timely for CCTs
CCTs create webContents in a way that doesn't allow reading the pref
before the autofill machinery is initialized. With this CL, the pref
value is passed in on creation which fixes the issue.
Another, less frequent issue is checking isEnabled. This method lazily
initializes Android's AutofillManager and contributes to CCTs
occasionally preventing Autofill use. This is incorrect since the return
value may change while the app is running and isn't suitable for making
an initial decision about whether Autofill should be enabled. The
safeguard this provided is (already or by now) checked in the Android
Framework when the regular notifyViewEntered calls are invoked.
Just out of caution and because this fix affects a fully launched
feature, both changes are guarded with a new feature:
kAutofillVirtualViewStructureAndroidInCct.
Unlaunching the original feature isn't a good option but holding this
fix back is a bad option, too. Therefore, it's default-enabled and
intended to use only as a possible kill-switch.
The change shouldn't affect WebView but we'll add a flag as guard.
go/scrcast/NTMyNTYxNTEwMzIxMzU2OHw1OTZhYTJlZC02Yg
(cherry picked from commit 5bd3d05740695f1e55c34415cb77bdea0e04759c)
DD: go/3ppwm-dd
Bug: 411164104
Fixed: 415734605
Change-Id: Iaf8ac48eef3fbf833d49d67c3e427d8c8d4d53b5
Chromium change:
https://chromium.googlesource.com/chromium/src/+/19050b6adac2e1f9b0442fc2dc4e58e5e023b251
Make AppMenuPropertiesDelegateImpl abstract.
Previously, the base class had all the logic for tabbed mode, and that
was never accessed by other child classes. This moves the tabbed logic
to the TabbedAppMenuPropertiesDelegate and make the base class abstract.
One of many CLs to try and remove XML menu inflation from the app menu.
Bug: 40145539
Chromium change:
https://chromium.googlesource.com/chromium/src/+/44b0ddd43212a03a3a9c7a66c08cd3a0f52b7e4b
[mobar] Suppress top toolbar scene layer while mini origin bar is active
Since the mini origin bar 1) is smaller and 2) looks different from the
scene layer's contents and the Java view will always be visible when
mobar is active, we need to hide it to avoid visual glitches.
Bug: 409317927
AlexeyBarabash