* [ads] Brave Ads buildflag for `/browser` & `/chromium_src`
The PR adds Brave Ads buildflag checks to
`/browser` and `/chromium_src` directories code
which depends on Brave Ads. This is a pre-requisite
for moving Brave Ads code under a build flag.
* Handle remaining brave_ads deps and includes
* Fix deps for `chrome/browser/prefs:impl`
It is first stage of the PSST feature implementation. The main goal
was to make the existing code ready to the next implementation
steps and be consistent with feature requirements.
Resolves: https://github.com/brave/brave-browser/issues/46045
---------
Signed-off-by: Vadym Struts <vstruts@brave.com>
`BraveTestingProfile` is used as a substitution, and it therefore it
must match the parent class constructor change.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/bb1ae862cc7112b9615fc08ca43a885aecef00e7
commit bb1ae862cc7112b9615fc08ca43a885aecef00e7
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Tue Aug 27 05:08:43 2024 +0000
Add CreateMode parameter to TestingProfile's ctor
Also TestingProfile::Builder starts to support CreateMode.
Bug: 341267441
Test: Tryjob
This would also initialize Brave keyed services factories in upstream unit tests.
This is a solution proposed by bridiver.
Addresses various issues that this change introduced.
Behavioral Change: Now, the farbling's session token is isolated to each profile, and
also an incognito session originating from a different profile has a unique session token.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/cd23b8b9d212daf06dde638488dbaa355d6651fa
commit cd23b8b9d212daf06dde638488dbaa355d6651fa
Author: Daniel Cheng <dcheng@chromium.org>
Date: Fri Sep 16 17:16:24 2022 +0000
Move bind.h, callback{,_forward,_helpers}.h into //base/functional
Forwarding headers remain in the old locations to ease migration.
Include paths for files in //base/functional/ are also fixed up to the
new canonical path; remaining fixups are deferred until followups to
minimize the risk of conflicts.
Bug: 1364441
HTTPS by default on Desktop
- Disabled, Standard, Strict modes
- Controlled by global and per-site shields settings
- Merge UI with HTTPS-Only Mode
- Behind HttpsByDefault feature flag
- Browser tests for each setting
By providing nullptr for OSConnectionAPI and moving create
method to platform specific files, we can avoid complicted buildflag
condition checking at BraveBrowserProcessImpl.
This change corrects the constructors of several classes under
browser/, using clang-tidy's modernize-use-equals-default. Additionally,
this commit includes a few additional straggler files.
* Explicit sandbox attribute for TorLauncher instead of specialization of the GetServiceSandboxType<>
* Added tor.bridges local state pref.
* Added component updater for Tor Pluggable transports.
* Reworked Tor browser test.
* Added Tor bridges tests
* Tor settings moved to Privacy page.
* Tor new tab page description and failure messages were added.
Recent changes to content::UnitTestTestSuite have been added to provide
support to ContentClient instantiations. This addition might have to
potential to remove the individual instantiation of those in each
browser test fixture. This CL corrects the build breakage introduced by
this change.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/d2126c70ea1b9cc77a07293790027af8d3fb612e
commit d2126c70ea1b9cc77a07293790027af8d3fb612e
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Mar 25 10:25:12 2022 +0000
Move initialization and tear down of objects needed by Content and its dependencies into content::UnitTestTestSuite.
This avoids test suites which depend on content having to duplicate this correctly. It also allows UnitTestTestSuite to ask embedders to create ContentClient implementations at the right time, which will soon be needed before calling blink::Initialize.
Bug: 1309246
* Implement navigator.languages farbling
* add support for HTTP headers
* add support for farbling HTTP header
* add reduce language preference toggle in settings
* Implement font whitelist
* add sublabel to reduce-lang preference toggle
* rebase patches
* use anonymous namespace
* also add our AllowFontFamily method to TestFontSelector to avoid compile errors
* farble all non-whitelisted fonts without enumeration
* rename to MakePseudoRandomGeneratorForURL
* move session token management to singleton service
* move font whitelist to .cc file
* move prefs constants and code around
* pref names browsertest fix
* reduce patches (really)
* add web worker and service worker tests
* get URL differently, move DCHECK
* propogate reduce-language pref to renderers
* consolidate feature detection, add some comments
* lint
* gn_check
* gn_check
* refactor default locale lookup
* lint
* default session key to 12345 if command line switch is missing
https://github.com/brave/brave-browser/issues/22021
* change 12345 -> 23456 so it doesn’t match the test default
Co-authored-by: bridiver <github@brianjohnson.cc>
Aleksei Seren