* Update from Chromium 127.0.6533.26 to Chromium 127.0.6533.43.
* Conflict-resolved patches from Chromium 127.0.6533.26 to Chromium 127.0.6533.43.
* Update patches from Chromium 127.0.6533.26 to Chromium 127.0.6533.43.
* Updated strings for Chromium 127.0.6533.43.
* Move tab search alignment override
This override used to be a static function, however now it relies on the
value stored in a global in a different file. This change moves the
override to a new location to cancel the alignment.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/0f49c359318fb8ac60b6f8de2b9142cdde2f210b
commit 0f49c359318fb8ac60b6f8de2b9142cdde2f210b
Author: David Pennington <dpenning@chromium.org>
Date: Wed Jun 26 00:52:03 2024 +0000
[TabSearchPosition] Change the tab search position based off of the pref
Use the pref in the settings page to set the initial position of the
tab search button.
Bug: 338622527
* `SidePanelUI::GetSidePanelUIForBrowser` deleted
Access to the sidepanel pointer is supposed to be through the browser
instance now.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/dda455db11b61d29a64ca80826eb1359d24b582a
commit dda455db11b61d29a64ca80826eb1359d24b582a
Author: Erik Chen <erikchen@chromium.org>
Date: Tue Jun 11 21:53:21 2024 +0000
Remove static accessors from SidePanelUI.
This CL is a refactor with no intended behavior change.
This CL turns SidePanelUI into an abstract base class. This CL modifies
BrowserWindowFeatures to own an instance of SidePanelCoordinator.
SidePanelUI static accessors are redirected to use
BrowserWindowFeatures.
There are slight timing differences to construction and destruction of
SidePanelCoordinator, which should have no user-visible effect. This CL
introduces the methods InitPostBrowserViewConstruction and
TearDownPreBrowserViewDestruction to BrowserWindowFeatures to handle
this more generically.
Change-Id: Ic3565fa4ff8d6b57f301f51b2bb9d9d3ed8b2f09
Bug: 346148554, 346158959, 345499793
* Browser actions initialization was moved out of class c'tor.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/63f9a1d81a696de43f9aa6a3c4a5aa0e0a57ab17
commit 63f9a1d81a696de43f9aa6a3c4a5aa0e0a57ab17
Author: Erik Chen <erikchen@chromium.org>
Date: Tue Jun 11 22:19:32 2024 +0000
[lensoverlay] Simplify LensOverlaySidePanelCoordinator.
This CL is a refactor with no intended behavior change. It makes 5
changes:
(1) Dynamic state from LensOverlayController was being stored on
LensOverlaySidePanelCoordinator as fixed members. This introduces the
potential for state mismatch. This state mismatch is one of the reasons
we had to disable tab dragging for chromnient. These members were
deleted, and all state is fetched dynamically.
(2) Removed conditionals that always evaluated to false.
(3) Inlined and simplified CreateSidePanelActionCallback.
(4) Pass around content::BrowserContext instead of Profile when
possible.
(5) Initialize BrowserActions after BrowserWindowFeatures.
Bug: 339497734, 342921671
* [Android] [Tab Group Sync] Add and update metrics
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/21f46a1beb022ef6fe8ab989750a2ee85029ef54
[M127][Tab Group Sync] Add and update metrics
* Move TabGroups.UserGroupCount to be form-factor agnostic.
* Record whether a tab group is local or remote when a tab is selected.
* Add metrics for rename dialog usage.
* Record when sync creates a new tab group.
* Record when the tab group name is reset.
* Record when we close vs delete a local version of a synced tab group.
(cherry picked from commit ad1292750543d8f9673d11efdcf71d8601c8a2a6)
Bug: 348687061
* Side panel position strings have changed.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/30404c2dfea7a8af429dd8442343e9d4857631e2
commit 30404c2dfea7a8af429dd8442343e9d4857631e2
Author: David Pennington <dpenning@chromium.org>
Date: Fri Jun 14 19:38:23 2024 +0000
[TabSearchPosition] Update the sidepanel position to a dropdown
Before changing the tab search button position to a dropdown, the side
panel position option text is updated, and changed to be a dropdown.
text is changed so that it can be used across the 2 options.
image in bug.
Bug: 338622527
* Disables crashing upstream unit tests.
---------
Co-authored-by: mkarolin <max@brave.com>
Co-authored-by: Artem Samoilenko <artem@brave.com>
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/d864e62dddc14e305f0a274f6058ab082ad2b99a
[SurfacePolish][CleanUp] Clean up surface polish code for MVT (Part 5)
This CL represents part 5 of the cleanup for the surface polish code in
the MVT, focusing on refining the code associated most visited tiles
layout. The update removes the grid layout from most visited tiles and
renames the most visited tiles carousel layout to simply most visited
tiles layout.
Bug: 331667743
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/d2c4b3d248d0a74dd00e9956df65604eea0ef6bc
[E2E] Use BottomControlsStacker to resize bottom browser controls
Introduce BrowserControlsStacker to coordinate different UI that wants to change the bottom controls height. This CL is used as transitional solution, just forwarding calls from BrowserControlsStacker to the wrapped BrowserControlsSizer, while also provide the BrowserControlsStateProvider for clients to do the observation.
There are still references of BrowserControlsSizer in custom_tabs, which is not in scope of this initial refactor.
Bug: 345488108
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/d864e62dddc14e305f0a274f6058ab082ad2b99a
[SurfacePolish][CleanUp] Clean up surface polish code for MVT (Part 5)
This CL represents part 5 of the cleanup for the surface polish code in
the MVT, focusing on refining the code associated most visited tiles
layout. The update removes the grid layout from most visited tiles and
renames the most visited tiles carousel layout to simply most visited
tiles layout.
Bug: 331667743
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/d864e62dddc14e305f0a274f6058ab082ad2b99a
[SurfacePolish][CleanUp] Clean up surface polish code for MVT (Part 5)
This CL represents part 5 of the cleanup for the surface polish code in
the MVT, focusing on refining the code associated most visited tiles
layout. The update removes the grid layout from most visited tiles and
renames the most visited tiles carousel layout to simply most visited
tiles layout.
Bug: 331667743
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/a132d3713b07b5e78f3c7a0d4b1b0fc9401f4214
Stop accepting fragment as raw string in SettingsLauncher API
No behavior change. Before this CL, the SettingsLauncher API used to
take fragments as 3 different types.
1) Fragment class
2) SettingsFragment enum
3) String for class name of the fragment
2 and 3 are used when the calling code is modularized but not the
corresponding fragment. 3 is less safe than 2 (think features
breaking because the fragment got renamed or changed packages). So
this CL drops 3 and adopts only 2.
Long term, it would be good to unify more, i.e. either
- Modularize all settings fragments and only use 1.
- Only use 2.
But that work is beyond this CL.
Change-Id: I1d2c99aa60bc0393f514a9e10d895185be399196
deeppandya