Before this commit, there were two silent installers: a 1 MB online
"stub" installer and a standalone installer. Both opened a Brave window,
so were not truly silent. To fix this, the online installer was removed
entirely. And the standalone installer was updated to be built from a
new version of the Omaha update framework, which passes the flag
`--do-not-launch-chrome` to Brave's installer.
This should initiate 5 retries when we receive
502 Bad Gateway errors uploading to GitHub.
urllib3 is only installed on the sf-mac-pro build
worker, and we use sys.path.append to add the path
to the package because it doesn't find it by default.
We will use pip to install urllib3 on the linux
and windows AWS workers in the build job itself.
Fixes https://github.com/brave/devops/issues/943
Pycodestyle is starting to fail invalid escape sequences
that will be illegal in Python 3.7 and in this example
we were using \. and \s which will be invalid at that
time.
We will use character classes instead.
- Fixes broken unit tests
- Fixes linting errors
- Adds tests for upload scenario
- Adds test for retry scenario (making sure calls are in order)
New `npm run` task created; runs linter + tests. To try it, run:
`npm run test-python-scripts`
This resolvesbrave/brave-browser#565 by passing the filename and
changing the match pattern to:
'Brave-Browser-' + channel.capitalize() + r'.*\.dmg$'
Also adds tests for yield_brave_packages in scripts/upload.py
Mihai PLESA