Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
68,004 Commits 1 Branch 0 Tags
b76149adcf88f8cb79da4e15fa76216334b1fb37
Commit Graph
12 Commits
Author SHA1 Message Date
AlexeyBarabash 2c0b5169bc [cr134] [Android] Adopt Java class GaiaId to improve type safety 
Related Chromium change
https://source.chromium.org/chromium/chromium/src/+/3fded879fa9da3882befb43faecc1fb3859065af

	Adopt Java class GaiaId to improve type safety

	Introduced recently in Java in https://crrev.com/c/6110420, the
	class is now adopted throughout the codebase to replace String
	objects when it comes to gaia IDs.

	Bug: 380416867
	Change-Id: I1ea990a1442c87f2fd2df4693c2ddb22d5ada873
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6110764
 2025-02-18 12:46:53 +00:00
AlexeyBarabash cf9ea1bc0c [Android] Upstream made AccountInfo constructor private 
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/956c0c17f01deb73aabec519e1e818b5927fbff2

	[Signin] Make AccountInfo constructor private

	No behavior change.

	Bug: 348373729
	Change-Id: I68b97cf6a22dac2e1945f637954fe35670c0b0ab
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5930403
 2024-11-29 13:24:52 +00:00
AlexeyBarabash 8751ac34d5 New parameter at ManageAccountDevicesLinkView.getSharingAccountInfo 
Now it has `Profile profile`

Related Chromium change:
https://source.chromium.org/chromium/chromium/src/+/361f25f4657194e20941c9714d8011dcb209e88f

Remove getLastUsedRegularProfile from ManageAccountDevicesLinkView.

Bug: 40254448
Change-Id: I570add47faced4ab9c02a8b75f3334c04d739837
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5458378
 2024-05-24 12:58:07 +01:00
AlexeyBarabash 693e8ae743 Fixed crash accessing 'send to devices' in share menu via Sync (#21168) 
Fixes brave/brave-browser#34636

Related Chromium commit:
https://source.chromium.org/chromium/chromium/src/+/84ed1f62ecd64bbfc3d2c4775a6e80a6b0e9defb

Clean up SendTabToSelfSigninPromo flag

Enabled by default in M119 (https://crrev.com/c/4905024), can be
cleaned up in M120.

Fixed: 1479693, 1295204
Change-Id: Ic778e9c886a5d9391fb5da7510d166952481fe21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4905343
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/main@{#1204655}
 2023-12-01 13:16:38 +02:00
Artem Samoilenko 368fb3140e [Android] ManageAccountDevicesLinkView#inflateIfVisible was removed 
Chromium change:
https://github.com/brave/chromium/commit/84ed1f62ecd64bbfc3d2c4775a6e80a6b0e9defb

Clean up SendTabToSelfSigninPromo flag
Enabled by default in M119 (https://crrev.com/c/4905024), can be
cleaned up in M120.

Fixed: 1479693, 1295204
 2023-11-27 11:27:10 -05:00
Simone Arpe 39cf09370b Fix copyright header (#18011) 
Replaces `http` protocol with `https` in the copyright header for Java and XML files.
 2023-04-12 15:10:02 +02:00
samartnik 6097457996 [Android] Usage of ManageAccountDevicesLinkView was changed 
Chromium change:
https://github.com/chromium/chromium/commit/aaac59b898e58ca10ced7e359f6331a97d2a6824

[stts/android] Adjust background and alignment
Before/after screenshots per user state.

No target device state (kSendTabToSelfSigninPromo off):
https://screenshot.googleplex.com/BJ6tn5iNy65kDjq
https://screenshot.googleplex.com/4rghZiHSiW6Trf7

No target device state (kSendTabToSelfSigninPromo on):
https://screenshot.googleplex.com/rvD7MoNKRApABPk
https://screenshot.googleplex.com/9o8kF3WBtFFxDqq

Device picker:
https://screenshot.googleplex.com/9wZJg6c5ouEsMbG
https://screenshot.googleplex.com/ANsB54CxAkRPARH

Bug: 1219434
 2022-09-15 20:46:18 -04:00
samartnik 1d46128834 [Android] New UI for send tab to self 
Chromium change:
https://github.com/chromium/chromium/commit/8f81d7723f510c99bb651770b6d731d2fdf486c1

[send-tab-to-self/android] Add account UI to "no target devices" sheet
Behavior changes are behind a feature flag disabled by default.
This footer was already present in the device picker, now it's present
on the "no target devices" UI too.
Mock is "Option 2" here: https://docs.google.com/presentation/d/1w4me9wINwMW2UD-uuSQGMKiWuqkX9GDfAFvSM74Pt00/edit#slide=id.ge2c74ccf3a_0_4

Bug: 1219434
 2022-07-22 13:33:53 +01:00
samartnik d8bf4840c9 [Android] Various c-tor signature changes 2022-07-22 13:33:52 +01:00
samartnik f265e3526d [Android] New c-tor signature for DevicePickerBottomSheetContent 
Chromium change:
https://github.com/chromium/chromium/commit/757a57cc300f4949259b4adf0286712a87ec63fb

[send-tab-to-self] Remove unused plumbing for navigation_time
No behavior is changed. The navigation time argument in the
SendTabToSelfEntry constructor is unused since crrev.com/c/3604466,
so the associated plumbing can be deleted.

Fixed: 1319413
 2022-06-10 05:58:23 -04:00
mkarolin a09b02cdf2 [Android] DevicePickerBottomSheetContent c'tor signature has changed. 
Chromium change:

https://source.chromium.org/chromium/chromium/src/+/fb4ad98be363120645b2eaff91170de95d86d71b

commit fb4ad98be363120645b2eaff91170de95d86d71b
Author: Victor Hugo Vianna Silva <victorvianna@google.com>
Date:   Fri Feb 18 19:00:15 2022 +0000

    Plumb WindowAndroid to SendTabToSelfCoordinator

    No behavior is changed. This will be required to use the
    AccountPickerBottomSheetCoordinator [1] in that layer later.
    Besides that:
    - Remove the plumbing of SyncService::isSyncRequested() through those
    same layers because it's unused - this was overlooked by
    crrev.com/c/3449011. Besides being a clean-up, the motivation is we'll
    want to use the SyncService directly in the coordinator anyways, so
    there's no need for the plumbing.
    - Make createBottomSheetContent() private, so show() is the one entry
    point for the coordinator.
    - Add a TODO regarding how the metric
    SharingHubAndroid.SendTabToSelf.NoTargetDevices is now misleading.

    [1] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/android/signin/java/src/org/chromium/chrome/browser/ui/signin account_picker/AccountPickerBottomSheetCoordinator.java;l=76;drc=bc1e9573d7bc2802a3e6512a62f28a79faa0ed0c

    Bug: 1219434
 2022-04-15 18:27:00 -04:00
samartnik 144dd60425 [Android] Fixed crash on sending tabs to another device 2022-04-06 15:27:56 -04:00