* Converts npm run pylint command to use js.
Currently `npm run pylint` triggers a shell script to run pylint.
This a) doesn't work on windows b) doesn't use correct path to pylint
because depot_tools isn't in the PATH.
This change adds the same functionality that the shell script provides
to our js scripts. It also adds depot_tools/python2-bin and python2-bin
to the PATH as recommended by Chromium.
* Modifies pylint script to work with folders.
Version of pylint that comes with depot_tools doesn't process
directories unless they have __init__.py file. To get around
this limitation we need to find all python files ourselves and
pass them to pylint.
This needs to accout for command line lenth limitation on Windows.
Also use different config files for python2 and python3.
* Added pylint resource file for python2
* Modified .pylint2rc the same as .pylintrc
* Ensure depot_tools is in the path when invoking pylint.
* TEMP: pylint testing.
* Update Jenkinsfile
* Update bump-version.py
* Update Jenkinsfile
Co-authored-by: Mihai PLESA <mplesa@brave.com>
* [MacOS] Override helper-alerts identifier for signing.
Alerts helper has been added for signing upstream but Chrome doesn't
distribute it yet. Because it uses the same identifier as the current
alerts service, we get a signing error.
For now we'll use a different identifier for this helper and then
revert once Chrome starts distributing the helper.
Fixesbrave/brave-browser#15731
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/56915522276f
commit 56915522276f86acc55f86b143b4d7b260d6bc36
Author: Richard Knoll <knollr@chromium.org>
Date: Fri Mar 5 16:07:34 2021 +0000
Introduce alert notification helper .app
This adds a new helper .app on macOS to display alert notifications.
This app is required to show alert style notifications as the main app
can only show banner style ones and the XPC service can not use the new
UNNotification APIs.
Bug: 1127306
* Pacify pylint for signing_helper.py
Enable a/b testing for different versions of a resource, e.g. text classification. Change name from UserModel to AdsResource and move code into the brave ads component. Finally removing the bat-native-usermodel dependency from ads.
Checks that translation of strings in ICU plural format, similar to:
{ xxx, plural,
=x {}
other {}
}
is preserved in the translation strings.
Also fixed some pylint formatting indignations.
Before this commit, there were two silent installers: a 1 MB online
"stub" installer and a standalone installer. Both opened a Brave window,
so were not truly silent. To fix this, the online installer was removed
entirely. And the standalone installer was updated to be built from a
new version of the Omaha update framework, which passes the flag
`--do-not-launch-chrome` to Brave's installer.
Because brave_strings.grd and settings_brave_strings.grdp are special
cases in terms of naming, the rebase script wasn't adding the GRDP
override to the GRD override.
Addresses brave/brave-browser#14750
Doesn't fix the actual translations, but we should get them the next
time we order.
To make this work well on shells like Windows' cmd.exe or PowerShell,
we add an intermediate step before matching the paths for files found
in the repository against the regular expresisons declared in EXCLUDES,
so that we use forward slashes instead of backward slashes, which will
cause errors due to the regexp interpreting paths like C:\\mypath as if
they contained the escaped '\m' character.
Once the regular expression has been used though, we still append the
unnormalized OS-dependant relative path to the list of paths built by
filter_chromium_src_filepaths(), so that further operations over those
files can be performed correctly, and so that any path printed in the
output will use the OS-dependant path separator.
To make it clearer where each global variable points to, rename:
* SOURCE_ROOT -> BRAVE_SRC
* CHROMIUM_SRC -> BRAVE_CHROMIUM_SRC
* SRC_DIR -> CHROMIUM_SRC
We can't use the OS path separator when handling C++ include paths but
UNIX-like path separators instead, otherwise counting the number of
'../' components wont' work, nor creating the list of relative paths
to chromium_src override files to be checked.
We would like to expand the functionality of this script to allow us
to check for more potentially problematic situations (e.g. new uses
of re-defined symbols inside a given overriden file), so let's migrate
it to Python first so that's easier to extend.
Resolves https://github.com/brave/brave-browser/issues/14382
Fixesbrave/brave-browser#11133Fixesbrave/brave-browser#11407Fixesbrave/brave-browser#11546Fixesbrave/brave-browser#11547
- Disables features via Chromium features:
* Direct Sockets
* Lang Client Hint Header
* Signed Exchange Prefetch Cache For Navigations
* Subresource Web Bundles
- Disabled the following blink features in
BraveContentRendererClient::SetRuntimeFeaturesDefaultsBeforeBlinkInitialization
since they don't have Chromium features:
* Digital Goods
* Native File System (File System Access)
- Added browser tests for these features
- Modified redirect-cc.py to allow overriding files under out/XXX/gen
- Added an override for blink::origin_trials::IsTrialValid and overrides
for blink::OriginTrialContext methods AddFeature and AddForceEnabledTrials
for trials:
* NativeFileSystem2
* SignedExchangeSubresourcePrefetch
* SubresourceWebBundles
- Added browser tests for trials disablement.
yan