Chromium change:
https://github.com/brave/chromium/commit/aa78b431380e08988cccde7e6e2a167568da64a9
[Tab Groups] Remove auto creation and menu order params
Remove tab group auto creation and menu order params as these are
launched in their current and final states.
Tab Group Auto Creation is disabled.
New Tab In Group is first in the context menu.
Bug: 1188370
* Upgrade from Chromium 115.0.5790.40 to Chromium 115.0.5790.56
* Upgrade patches from Chromium 115.0.5790.40 to Chromium 115.0.5790.56
* Update pins list timestamp
* Updated strings for Chromium 115.0.5790.56
* Use new internal namespace for kSidePanelCompanion and disable related feature
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/8168e68f8e290ab3d73da121d2db3248c9b5c41c
commit 8168e68f8e290ab3d73da121d2db3248c9b5c41c
Author: Tarun Bansal <tbansal@google.com>
Date: Mon Jun 26 19:02:28 2023 +0000
[M115 Merge] [CSC] Enable companion when exps is enabled
This CL dynamically enables Chrome companion if Chrome detects that user
is enabled in exps. This happens if the
CompanionEnabledByObservingExpsNavigations feature is enabled.
The CL achieves this by changing some of the existing checks to be
enabled by either of the 2 field trial experiments: (i) CSC itself is
enabled as a feature (ii) Detection of exps enrollment is enabled
If detection of exps enrollment is enabled and exps enrollment is
detected, then companion is dynamically enabled and an entry is pinned
to the toolbar.
Design discussion: http://shortn/_nrSG5apNyX
(cherry picked from commit 083f2748173dcfc19fca70cc40390b1058d54e11)
Bug: b:286111571, 1449021
---------
Co-authored-by: brave-builds <brave-builds+devops@brave.com>
* Enable CheckJavaStyle presubmit check
For now severity for all checks except RedundantImport/UnusedImports
is changed from error to warning with brave-style-5.0.xml.
Once all Java style errors will be fixed, check should be switched
back to upstream's original check.
Fixesbrave/brave-browser#30823
* Remove all unused/redundant imports from java files
Mostly renaming and removing obsolete code.
Chromium changes:
https://github.com/chromium/chromium/commit/7068c98f7fafe23ea93e203c182f889a04380d2e
Enable All Suggestions to feature Action Chips.
The change renames PedalSuggestionProcessor as ActionChipsProcessor
and relocates it to the `.base` package.
The change also renames OmniboxPedalDelegate as ActionChipsDelegate,
and plumbs the Delegate to all relevant SuggestionProcessors:
- Entity,
- Answer,
- Tail, and
- Basic (catch-all suggestion processor).
to increase the availability of Pedals and Journeys.
Bug: 1418077
https://github.com/chromium/chromium/commit/819d1f2e3fc5b4044abf1b5c0fc24adcab272b04
[Crow] Remove CrowButtonDelegate dependency (Feed+Menu)
Bug: 1408601
https://github.com/chromium/chromium/commit/e82ad92b6f71d5baca1ec94b389c1d7cea903161
Simplify Java TaskTraits
This is essentially prep work for future cleanup, I've minimized the API
exposed from TaskTraits (after 4 years we still haven't needed a lot of
the infrastructure that was built here).
There are no functional changes here, TaskTraits.THREAD_POOL_BEST_EFFORT and TaskTraits.BEST_EFFORT were/are equivalent.
Change-Id: Ida665c009d20d891b25821fec9d603bd9c1a3657
https://github.com/chromium/chromium/commit/2d180440d8b213e2f9b5290dd76998414d0f02ff
[Tab Management] Simplify M5 params
Flatten launch params for M5 to make things a bit easier to reason
about. This CL flattens params for
* ENABLE_LAUNCH_POLISH
* ENABLE_LAUNCH_BUG_FIX
* ENABLE_DEFERRED_FAVICON
into TabUiFeatureUtilities#isTabGroupsAndroidContinuationEnabled(). This
flag has been turned off and will only be re-activated once we are ready
to re-attempt the M5 launch.
This CL also removes
* ENABLE_TAB_GROUP_SHARING
which is deprecated in favor of TabSelectionEditorV2.
The second, third, and fourth bugs are speculatively fixed by this.
Bug: 1420613, 1418922, 1420197, 1419842
We want bottom tab groups toolbar and bottom toolbar colors to match.
Chromium change:
https://github.com/chromium/chromium/commit/36b698ced32d46de61554b4db1d9ca38143fcfc2
Reland "[GMNext] Migrate default_bg_color_dark_elev_N"
This is a reland of 391590f
The underlying issue has been fixed in https://crrev.com/c/3414069 and
this change is now safe to reland without any modifications.
Original change's description:
> [GMNext] Migrate default_bg_color_dark_elev_N
>
>
> [GMNext] Migrate default_bg_color_light_elev_N to dynamic colors
>
> Migrate default_bg_color_light_elev_N to dynamic colors.
>
> Only usage can be handled with the SurfaceColorDrawable.
>
> Will handle night mode version in followup CL migrating
> default_bg_color_dark_elev_N.
>
> Bug: 1270911
> Change-Id: Id2931d815de83f3d0a57bbd104a65d2cd85c8f8b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343448
> Reviewed-by: Sky Malice <skym@chromium.org>
> Reviewed-by: Sinan Sahin <sinansahin@google.com>
> Reviewed-by: Theresa Sullivan <twellington@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Commit-Queue: Neil Coronado <nemco@google.com>
> Cr-Commit-Position: refs/heads/main@{#957734}
Bug: 1270911, 1287000
Chromium change:
https://chromium.googlesource.com/chromium/src/+/73c2d3d5ee5865411e0f09909f1456c5e7bbc4e3
Bottom tab strip bg to Surface-3 in night mode.
The previous implementation assumed that the background color of the tab
strip should match the omnibox. This is no longer the case, as the
tab strip should now match infobars/dialogs, and be surface-0 (day) and
surface-3 (night).
So replace the theme provider with an is incognito provider, to let the
view make the appropriate decision.
Bug: 1243098
Chromium change:
Bottom tab strip bg to Surface-3 in night mode.
The previous implementation assumed that the background color of the tab
strip should match the omnibox. This is no longer the case, as the
tab strip should now match infobars/dialogs, and be surface-0 (day) and
surface-3 (night).
So replace the theme provider with an is incognito provider, to let the
view make the appropriate decision.
Bug: 1243098
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/d5668a5d7e41aefbc739d76435f1d02fd1f93ec9
Update GTS/Group feature checking util method to use activity context
GTS/Group is currently disabled for tablet. The util method that
determines availability of the GTS and Tab Group is using application
context to identify the tablet mode. We should use activity context
instead. This CL updates those util methods to use the activity context.
Bug: 1217430
Chromium change:
https://chromium.googlesource.com/chromium/src/+/2336b6557478c544a81650258aab4b0e7af49c78
Toolbar: Move BottomControls to modularized target
This CL moves the classes for BottomControls MVC component plus
its layout xml to chrome/browser/ui/android/toolbar/.
Following dependencies on chrome_java were removed:
- ShareDelegate - was not in use.
- TabGroupUi - split to BottomControlsContentDelegate and extend
from it.
Bug: 1127732
Artem Samoilenko