cdesouza-chromium
07b587a892
This PR corrects several places where `BASE_FEATURE` is being used to rely on the two-arg variant of this macro. This particular PR has no functional changes, and the only feature declarations affected are the ones for which the feature-name constant, and the actual value are identical. The particular issue for this will be left open so subsequent work for the other features can be followed up on. Bug: https://github.com/brave/brave-browser/issues/50492
119 lines
4.4 KiB
C++
119 lines
4.4 KiB
C++
/* Copyright (c) 2021 The Brave Authors. All rights reserved.
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
* You can obtain one at https://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "base/feature_override.h"
|
|
|
|
#include <optional>
|
|
|
|
#include "base/check.h"
|
|
#include "base/dcheck_is_on.h"
|
|
#include "base/debug/debugging_buildflags.h"
|
|
#include "base/feature_list.h"
|
|
#include "base/memory/raw_ref.h"
|
|
#include "base/test/mock_callback.h"
|
|
#include "testing/gmock/include/gmock/gmock.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
using testing::_;
|
|
|
|
namespace base {
|
|
namespace {
|
|
|
|
BASE_FEATURE(kTestControlEnabledFeature,
|
|
FEATURE_ENABLED_BY_DEFAULT);
|
|
BASE_FEATURE(kTestControlDisabledFeature,
|
|
FEATURE_DISABLED_BY_DEFAULT);
|
|
|
|
BASE_FEATURE(kTestEnabledButOverridenFeature,
|
|
FEATURE_ENABLED_BY_DEFAULT);
|
|
BASE_FEATURE(kTestDisabledButOverridenFeature,
|
|
FEATURE_DISABLED_BY_DEFAULT);
|
|
|
|
BASE_FEATURE(kTestEnabledButOverridenFeatureWithSameState,
|
|
FEATURE_ENABLED_BY_DEFAULT);
|
|
|
|
OVERRIDE_FEATURE_DEFAULT_STATES({{
|
|
{kTestEnabledButOverridenFeature, FEATURE_DISABLED_BY_DEFAULT},
|
|
{kTestDisabledButOverridenFeature, FEATURE_ENABLED_BY_DEFAULT},
|
|
|
|
// Override, but keep the same state as `default_state`. We should properly
|
|
// return false from IsFeatureOverridden in this case.
|
|
{kTestEnabledButOverridenFeatureWithSameState, FEATURE_ENABLED_BY_DEFAULT},
|
|
}});
|
|
|
|
} // namespace
|
|
|
|
TEST(FeatureOverrideTest, OverridesTest) {
|
|
struct TestCase {
|
|
const raw_ref<const base::Feature> feature;
|
|
const bool is_enabled;
|
|
const bool is_overridden;
|
|
};
|
|
constexpr TestCase kTestCases[] = {
|
|
// Untouched features.
|
|
{raw_ref<const base::Feature>(kTestControlEnabledFeature), true, false},
|
|
{raw_ref<const base::Feature>(kTestControlDisabledFeature), false, false},
|
|
|
|
// Overridden features.
|
|
{raw_ref<const base::Feature>(kTestEnabledButOverridenFeature), false,
|
|
true},
|
|
{raw_ref<const base::Feature>(kTestDisabledButOverridenFeature), true,
|
|
true},
|
|
|
|
// Overridden but with the same state.
|
|
{raw_ref<const base::Feature>(
|
|
kTestEnabledButOverridenFeatureWithSameState),
|
|
true, true},
|
|
};
|
|
for (const auto& test_case : kTestCases) {
|
|
SCOPED_TRACE(testing::Message() << test_case.feature->name);
|
|
EXPECT_EQ(test_case.is_enabled, FeatureList::IsEnabled(*test_case.feature));
|
|
EXPECT_EQ(test_case.is_overridden,
|
|
FeatureList::GetInstance()->IsFeatureOverridden(
|
|
test_case.feature->name));
|
|
EXPECT_EQ(test_case.is_overridden ? std::make_optional(test_case.is_enabled)
|
|
: std::nullopt,
|
|
FeatureList::GetStateIfOverridden(*test_case.feature));
|
|
}
|
|
}
|
|
|
|
#if DCHECK_IS_ON() && !BUILDFLAG(DCHECK_IS_CONFIGURABLE)
|
|
TEST(FeatureOverrideTest, FeatureDuplicateDChecks) {
|
|
// Check any feature to make sure overridden features are finalized (moved
|
|
// from an unsorted vector to a sorted flat_map).
|
|
ASSERT_FALSE(base::FeatureList::IsEnabled(kTestEnabledButOverridenFeature));
|
|
|
|
// This will add a feature to an unsorted vector of overrides.
|
|
internal::FeatureDefaultStateOverrider init_overrides{{
|
|
{kTestEnabledButOverridenFeature, FEATURE_DISABLED_BY_DEFAULT},
|
|
}};
|
|
|
|
// This should trigger DCHECK.
|
|
EXPECT_DEATH_IF_SUPPORTED(
|
|
internal::FeatureDefaultStateOverrider({
|
|
{kTestEnabledButOverridenFeature, FEATURE_DISABLED_BY_DEFAULT},
|
|
}),
|
|
testing::HasSubstr("Feature TestEnabledButOverridenFeature has already "
|
|
"been overridden"));
|
|
}
|
|
|
|
TEST(FeatureOverrideTest, FeatureDuplicateInSameMacroDChecks) {
|
|
// Check any feature to make sure overridden features are finalized (moved
|
|
// from an unsorted vector to a sorted flat_map).
|
|
ASSERT_FALSE(base::FeatureList::IsEnabled(kTestEnabledButOverridenFeature));
|
|
|
|
// This should trigger DCHECK.
|
|
EXPECT_DEATH_IF_SUPPORTED(
|
|
internal::FeatureDefaultStateOverrider({
|
|
{kTestEnabledButOverridenFeature, FEATURE_DISABLED_BY_DEFAULT},
|
|
{kTestEnabledButOverridenFeature, FEATURE_DISABLED_BY_DEFAULT},
|
|
}),
|
|
testing::HasSubstr("Feature TestEnabledButOverridenFeature is duplicated "
|
|
"in the current override macros"));
|
|
}
|
|
#endif // DCHECK_IS_ON() && !BUILDFLAG(DCHECK_IS_CONFIGURABLE)
|
|
|
|
} // namespace base
|