Claudio DeSouza
5fe7b5b8fd
Chromium changes: https://chromium.googlesource.com/chromium/src/+/94c8534414d7e52827cc07353185709210aa98e8 commit 94c8534414d7e52827cc07353185709210aa98e8 Author: Erik Chen <erikchen@chromium.org> Date: Wed Apr 22 11:38:16 2026 -0700 Modularize //chrome/browser/lifetime Extracts the `lifetime` sources (application_lifetime, browser_shutdown, browser_close_manager, restartability_monitor, etc.) out of the monolithic `//chrome/browser` target into dedicated `//chrome/browser/lifetime:lifetime` (public headers) and `//chrome/browser/lifetime:impl` targets. Platform-specific sources (android, chromeos, mac, aura) are conditionally included via the new BUILD.gn rules. All downstream BUILD.gn files that previously relied on the bundled target now declare an explicit dep on `//chrome/browser/lifetime`. A circular-dep note is preserved explaining why `:impl` still has to live under `//chrome/browser` and `//chrome/browser/ui`. AGENT_GENERATED_CL Bug: 353332589 Change-Id: I9235a54772bc0941e313dba3e0f7eec495ab1ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7786609 Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/main@{#1618994}
48 lines
1.3 KiB
Plaintext
48 lines
1.3 KiB
Plaintext
# Copyright (c) 2025 The Brave Authors. All rights reserved.
|
|
# This Source Code Form is subject to the terms of the Mozilla Public
|
|
# License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
# You can obtain one at https://mozilla.org/MPL/2.0/.
|
|
|
|
source_set("upgrade_when_idle") {
|
|
sources = [
|
|
"upgrade_when_idle.cc",
|
|
"upgrade_when_idle.h",
|
|
]
|
|
|
|
# We also depend on several sources from //chrome/browser but can't list it
|
|
# here because it would create a dependency cycle.
|
|
deps = [
|
|
"//base",
|
|
"//chrome/browser/first_run",
|
|
"//chrome/browser/lifetime",
|
|
"//chrome/browser/profiles:profile_manager",
|
|
"//chrome/browser/ui/browser_window",
|
|
"//chrome/browser/upgrade_detector",
|
|
"//chrome/common:non_code_constants",
|
|
"//components/browsing_data/core",
|
|
"//components/prefs",
|
|
"//ui/base/idle",
|
|
]
|
|
}
|
|
|
|
source_set("unit_tests") {
|
|
testonly = true
|
|
|
|
sources = [ "upgrade_when_idle_unittest.cc" ]
|
|
|
|
deps = [
|
|
":upgrade_when_idle",
|
|
"//base",
|
|
"//base/test:test_support",
|
|
"//chrome/browser/ui",
|
|
"//chrome/test:test_support",
|
|
"//chrome/test:test_support_ui",
|
|
"//components/browsing_data/core",
|
|
"//components/prefs",
|
|
"//content/test:test_support",
|
|
"//testing/gmock",
|
|
"//testing/gtest",
|
|
"//ui/base/idle:test_support",
|
|
]
|
|
}
|