These classes were hoisted and renamed. This has been replaced in Chromium as well. This is a mechanical change for Brave, done with the following script. ``` git grep -lw 'Value::List' | xargs sed -i 's/\bValue::List\b/ListValue/g' git grep -lw 'Value::Dict' | xargs sed -i 's/\bValue::Dict\b/DictValue/g' git cl format ``` Chromium changes: https://chromium.googlesource.com/chromium/src/+/6bc468d481835992696083e99e556516fb7f5f80 ``` commit 6bc468d481835992696083e99e556516fb7f5f80 Author: Avi Drissman <avi@chromium.org> Date: Thu Jan 29 22:14:50 2026 -0800 Remove aliases for base::DictValue and base::ListValue This removes a few last stragglers as well. Fixed: 478100525 Cq-Include-Trybots: luci.chromium.try:win-official,mac-official,linux-official,android-official,android-desktop-x64-official Change-Id: If92142b8ab0562a82c609b71c6b2a7665cea6ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7513889 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Owners-Override: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1577038} ``` Issue: https://github.com/brave/brave-browser/issues/52435
36 lines
1.1 KiB
C++
36 lines
1.1 KiB
C++
/* Copyright (c) 2025 The Brave Authors. All rights reserved.
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
* You can obtain one at https://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "base/notimplemented.h"
|
|
#include "third_party/rust/serde_json_lenient/v0_2/wrapper/lib.rs.h"
|
|
|
|
#include <base/json/json_reader.cc>
|
|
|
|
namespace serde_json_lenient {
|
|
|
|
// TODO(https://github.com/brave/brave-browser/issues/47120): These methods are
|
|
// not implemented for now, but their purpose is to eventually hook up the
|
|
// the `serde_json_lenient` to `base::Value`, and let us store binary blobs
|
|
// whenever dealing with 64bit integers that cannot be represented in
|
|
// `base::Value`.
|
|
|
|
void list_append_i64(base::ListValue& ctx, int64_t val) {
|
|
NOTIMPLEMENTED();
|
|
}
|
|
|
|
void list_append_u64(base::ListValue& ctx, uint64_t val) {
|
|
NOTIMPLEMENTED();
|
|
}
|
|
|
|
void dict_set_i64(base::DictValue& ctx, rust::Str key, int64_t val) {
|
|
NOTIMPLEMENTED();
|
|
}
|
|
|
|
void dict_set_u64(base::DictValue& ctx, rust::Str key, uint64_t val) {
|
|
NOTIMPLEMENTED();
|
|
}
|
|
|
|
} // namespace serde_json_lenient
|