Simon Hong
9ad657024d
Resolves brave/brave-browser#55816 This ensures UpdateIcon_BraveImpl is called at the point where the upstream has already updated the image, rather than at the end of the function where it would be skipped by early returns. Regressions from #35750 TEST=DownloadToolbarInsecureIconTest.InsecureDownloadIcon
13 lines
877 B
Diff
13 lines
877 B
Diff
diff --git a/chrome/browser/ui/views/download/bubble/download_toolbar_ui_controller.cc b/chrome/browser/ui/views/download/bubble/download_toolbar_ui_controller.cc
|
|
index 5360031b8a2b29a58572f1caa5531f168c710335..b8bebc288aecffb87c2e3876758a722d6b6f294b 100644
|
|
--- a/chrome/browser/ui/views/download/bubble/download_toolbar_ui_controller.cc
|
|
+++ b/chrome/browser/ui/views/download/bubble/download_toolbar_ui_controller.cc
|
|
@@ -716,6 +716,7 @@ void DownloadToolbarUIController::UpdateIcon() {
|
|
GetImageBadge(browser_view_)
|
|
->UpdateImage(is_active, progress_download_count, progress_color,
|
|
badge_background_color);
|
|
+ UpdateIcon_BraveImpl(browser_view_, *new_icon, state_, active_, action_item_);
|
|
|
|
// Do not show the progress ring when there is no in progress download.
|
|
if (state_ == IconState::kComplete || progress_info_.download_count == 0) {
|