AlexeyBarabash
d2c91e9eb1
* Fixed `CheckSettingsChanges` presubmit function There were two problems: 1. Somehow the `registry_full_path` misses segments `chrome` and `android` when accessing `SearchIndexProviderRegistry.java`, so it is `.../brave-browser/src/java/src/org/chromium/chrome/browser/settings/search/SearchIndexProviderRegistry.java` instead of an actual `.../brave-browser/src/chrome/android/java/src/org/chromium/chrome/browser/settings/search/SearchIndexProviderRegistry.java` which causes the registry not being read 2. `input_api.ReadFile` could not read outside of repo root which is `brave-browser/src/brave` so it could not read `SearchIndexProviderRegistry.java` Fixed both with patching or chromium_presubmit_overrides.py Resolves https://github.com/brave/brave-browser/issues/53560
13 lines
534 B
Diff
13 lines
534 B
Diff
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
|
|
index 00f85840ae075b43d7503f386a221f7037f40503..1f077c67a3d9e54ecbd3f766e9c18a0bf16c7f20 100644
|
|
--- a/PRESUBMIT.py
|
|
+++ b/PRESUBMIT.py
|
|
@@ -8207,6 +8207,7 @@ def CheckSettingsChanges(input_api, output_api):
|
|
relevant_files_found = False
|
|
registry_content = ''
|
|
registry_full_path = input_api.os_path.join(input_api.PresubmitLocalPath(),
|
|
+ "chrome", "android",
|
|
registry_path)
|
|
|
|
try:
|