Chromium change:
https://chromium.googlesource.com/chromium/src/+/25eaa43022a6ac52292434e1b03cb72f8f98c74b
commit 25eaa43022a6ac52292434e1b03cb72f8f98c74b
Author: Matt Menke <mmenke@chromium.org>
Date: Tue Aug 25 00:10:00 2020 +0000
Remove net::LOAD_DO_NOT_SEND_COOKIES and net::LOAD_DO_NOT_SEND_AUTH_DATA.
These two net::LoadFlags (along with net::LOAD_DO_NOT_SAVE_COOKIES) are
being combined into network::mojom::CredentialMode::kOmit. This CL
updates the remaining consumers of the two cookies to use
CredentialsMode / allow_credentials / PrivacyMode instead.
Unfortunately, there are still a bunch of consumers that are setting
net::LOAD_DO_NOT_SAVE_COOKIES without either of the other two flags,
so this CL leaves that one in place, for now.
This CL also fixes the LOAD_DO_NOT_SAVE_COOKIES case, where we'd set
privacy mode at the URLRequest layer, but then URLRequestHttpRequest
would disable it in the RequestInfo struct unless cookies were blocked
by the network delegate. The code now never sets PrivacyMode if only
LOAD_DO_NOT_SAVE_COOKIES is set, which does slightly alter behavior in
the LOAD_DO_NOT_SAVE_COOKIES + NetworkDelegate blocks cookies case, but
the current behavior seems more consistent.
This will also make it so that when the NetworkDelegate forces
PrivacyMode, it will disable sending auth credentials. The impact
on this is not expected to be significant, but it's worth being
aware of.
Bug: 799935
mkarolin
1470f718fe