cdesouza-chromium
9579407238
[CodeHealth][cr146] `base::Contains` dissallowed when `.contains` suffices it This is being enforced by the compiler through a concept, and it only applies for cases where `base::Contains` is used without a projection. This change also carries out IWYU for `base::Contains`. Chromium changes: https://chromium.googlesource.com/chromium/src/+/4a17af8403373b7f7e7546ef61f30dfbe883d617 ``` commit 4a17af8403373b7f7e7546ef61f30dfbe883d617 Author: Victor Hugo Vianna Silva <victorvianna@google.com> Date: Tue Jan 13 07:30:34 2026 -0800 Disallow base::Contains() when contains() or find() methods available This is a temporary step towards deleting base::Contains(). Trying to call base::Contains(foo, bar) will now cause a static assertion failure if foo has contains() or find() methods. This effectively makes base::Contains() an alias to std::ranges::contains(). The result is we can replace instances of 'base::Contains' with 'std::ranges::contains' in upcoming CLs while being sure to not regress performance. Bug: 470391351 Change-Id: I8778f435ff8f5b52fb3bf336724f2dfef388907a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7415207 Commit-Queue: Francois Pierre Doray <fdoray@chromium.org> Reviewed-by: Francois Pierre Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/main@{#1568392} ``` Bug: https://github.com/brave/brave-browser/issues/42557