cdesouza-chromium
6148d17fe6
The use of `bool` for `DeviceInfo` fields has led to bugs in the past. This has been correct with plaster, however we should also convert the field to an enum to make sure we follow the upstream practice of using enums in this type. Resolves https://github.com/brave/brave-browser/issues/55018
25 lines
1.1 KiB
Diff
25 lines
1.1 KiB
Diff
diff --git a/components/sync_device_info/device_info.cc b/components/sync_device_info/device_info.cc
|
|
index f828751332055e70fef223044da7dc6944f221a3..5ae8a20b5ffa20c2c05bc43cd2d8660a931182ba 100644
|
|
--- a/components/sync_device_info/device_info.cc
|
|
+++ b/components/sync_device_info/device_info.cc
|
|
@@ -81,7 +81,8 @@ DeviceInfo::DeviceInfo(
|
|
std::optional<base::Time> auto_sign_out_last_signin_timestamp,
|
|
bool desktop_to_ios_promo_receiving_enabled,
|
|
const MobilePromoOnDesktopPromoTypeSet&
|
|
- desktop_to_ios_promo_receiving_types)
|
|
+ desktop_to_ios_promo_receiving_types,
|
|
+ SelfDeleteSupport self_delete_support)
|
|
: guid_(guid),
|
|
client_name_(client_name),
|
|
chrome_version_(chrome_version),
|
|
@@ -105,7 +106,8 @@ DeviceInfo::DeviceInfo(
|
|
desktop_to_ios_promo_receiving_enabled_(
|
|
desktop_to_ios_promo_receiving_enabled),
|
|
desktop_to_ios_promo_receiving_types_(
|
|
- desktop_to_ios_promo_receiving_types) {}
|
|
+ desktop_to_ios_promo_receiving_types),
|
|
+ self_delete_support_(self_delete_support) {}
|
|
|
|
DeviceInfo::~DeviceInfo() = default;
|
|
|