Artem Samoilenko
01faa34916
Chromium changes: https://chromium.googlesource.com/chromium/src/+/c818a3850128c73f62537482e36f43367e9c40ce commit c818a3850128c73f62537482e36f43367e9c40ce Author: Tomasz Wiszkowski <ender@google.com> Date: Fri Oct 3 15:11:19 2025 -0700 Ensure all StatusIcons meet the specific size constraint. We've observed a weird behavior when toggling search engines results in oversize and cropped search engine icon shown in the omnibox. This is partially because the ChromeTransitionDrawable animating between states receives Drawables of inconsistent sizes, and changes its intrinsic size, trying to accommodate the larger of the drawables. Second more important factor is that the StatusIconResource carrying drawable was shared between two different views - the NTP Fakebox and the Omnibox. One view altering the Drawable state made the other view instantly see these alterations, resulting in wrong positioning of the icon. This change aligns all StatusView icon sizes, ensuring that no icon can ever change the intrinsic size of the TransitionDrawable. Change intentionally kept small as it will need to be cherrypicked. Fixed: 449181250 Change-Id: I59953971b99a01d015aa2398db058677c7816d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7007583 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/main@{#1525046}
108 lines
5.7 KiB
XML
108 lines
5.7 KiB
XML
<?xml version="1.0" encoding="utf-8"?>
|
|
<!-- Copyright (c) 2019 The Brave Authors. All rights reserved.
|
|
This Source Code Form is subject to the terms of the Mozilla Public
|
|
License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
You can obtain one at https://mozilla.org/MPL/2.0/.
|
|
-->
|
|
|
|
<resources xmlns:tools="http://schemas.android.com/tools">
|
|
<!-- Brave wallet -->
|
|
<dimen name="brave_wallet_tab_indicator_height">2dp</dimen>
|
|
|
|
<!-- Onboarding dimens -->
|
|
<dimen name="onboarding_text_size">16sp</dimen>
|
|
<dimen name="onboarding_bottom_sheet_height">250dp</dimen>
|
|
<dimen name="onboarding_counter_layout_height">350dp</dimen>
|
|
<dimen name="onboarding_counter_height">250dp</dimen>
|
|
|
|
<dimen name="onboarding_2_title_size">22sp</dimen>
|
|
<dimen name="onboarding_2_text_size">16sp</dimen>
|
|
<dimen name="onboarding_2_layout_height">200dp</dimen>
|
|
<dimen name="onboarding_2_animation_height">233dp</dimen>
|
|
<dimen name="onboarding_2_animation_width">318dp</dimen>
|
|
|
|
<!-- Bottom toolbar dimensions -->
|
|
<dimen name="bottom_toolbar_padding">12dp</dimen>
|
|
<dimen name="search_accelerator_width">64dp</dimen>
|
|
<dimen name="search_accelerator_height">36dp</dimen>
|
|
<dimen name="search_accelerator_height_padding">6dp</dimen>
|
|
<dimen name="search_accelerator_width_margin">4dp</dimen>
|
|
|
|
<dimen name="shields_tooltip_margin">-10dp</dimen>
|
|
<dimen name="shields_tooltip_padding">32dp</dimen>
|
|
<dimen name="shields_tooltip_arrow_width">30dp</dimen>
|
|
<dimen name="shields_tooltip_arrow_height">15dp</dimen>
|
|
|
|
<dimen name="full_screen_custom_tabs_control_container_height">0dp</dimen>
|
|
|
|
<dimen name="vpn_plan_margin">32dp</dimen>
|
|
|
|
<dimen name="onboarding_network_selection_item_width">103dp</dimen>
|
|
<dimen name="onboarding_network_selection_item_height">96dp</dimen>
|
|
|
|
<dimen name="default_regular">14sp</dimen>
|
|
<dimen name="large_regular">16sp</dimen>
|
|
<dimen name="large_semibold">16sp</dimen>
|
|
<dimen name="default_semibold">14sp</dimen>
|
|
<dimen name="small_regular">12sp</dimen>
|
|
<dimen name="x_small_semibold">11sp</dimen>
|
|
<dimen name="heading_h1">32sp</dimen>
|
|
<dimen name="heading_h3">22sp</dimen>
|
|
<dimen name="heading_h4">16sp</dimen>
|
|
<dimen name="small_semibold">12sp</dimen>
|
|
<dimen name="monospace_small">12sp</dimen>
|
|
<dimen name="brave_toolbar_edge_padding_ntp">8dp</dimen>
|
|
<dimen name="new_tab_page_incognito_title_text_size">28sp</dimen>
|
|
<dimen name="new_tab_page_incognito_logo_size">42sp</dimen>
|
|
<dimen name="new_tab_page_incognito_icon_size">32sp</dimen>
|
|
|
|
<!-- Brave News cards-->
|
|
<dimen name="brave_news_ad_title_textsize">17sp</dimen>
|
|
<dimen name="brave_news_ad_desc_textsize">12sp</dimen>
|
|
<dimen name="brave_news_ad_button_textsize">13sp</dimen>
|
|
<dimen name="brave_news_more_offers_tablet_textsize">17sp</dimen>
|
|
<dimen name="brave_news_more_offers_phone_textsize">13sp</dimen>
|
|
<dimen name="brave_news_deals_top_textsize">17sp</dimen>
|
|
<dimen name="brave_news_publisher_group_top_textsize">20sp</dimen>
|
|
<dimen name="brave_news_category_group_top_textsize">26sp</dimen>
|
|
<dimen name="brave_news_deals_title_tablet_textsize">18sp</dimen>
|
|
<dimen name="brave_news_deals_title_phone_textsize">14sp</dimen>
|
|
<dimen name="brave_news_deals_desc_tablet_textsize">16sp</dimen>
|
|
<dimen name="brave_news_deals_desc_phone_textsize">12sp</dimen>
|
|
<dimen name="brave_news_headline_title_tablet_textsize">21sp</dimen>
|
|
<dimen name="brave_news_headline_title_phone_textsize">17sp</dimen>
|
|
<dimen name="brave_news_headline_desc_tablet_textsize">15sp</dimen>
|
|
<dimen name="brave_news_headline_desc_phone_textsize">11sp</dimen>
|
|
<dimen name="brave_news_headline_publisher_tablet_textsize">16sp</dimen>
|
|
<dimen name="brave_news_headline_publisher_phone_textsize">12sp</dimen>
|
|
<dimen name="brave_news_promoted_article_title_textsize">17sp</dimen>
|
|
<dimen name="brave_news_promoted_article_desc_textsize">11sp</dimen>
|
|
<dimen name="brave_news_promoted_article_promoted_textsize">12sp</dimen>
|
|
<dimen name="brave_news_promoted_article_publisher_textsize">12sp</dimen>
|
|
<dimen name="brave_news_headline_paired_title_tablet_textsize">17sp</dimen>
|
|
<dimen name="brave_news_headline_paired_title_phone_textsize">13sp</dimen>
|
|
<dimen name="brave_news_headline_paired_desc_tablet_textsize">15sp</dimen>
|
|
<dimen name="brave_news_headline_paired_desc_phone_textsize">11sp</dimen>
|
|
<dimen name="brave_news_headline_paired_publisher_tablet_textsize">16sp</dimen>
|
|
<dimen name="brave_news_headline_paired_publisher_phone_textsize">12sp</dimen>
|
|
<dimen name="brave_news_publisher_group_title_tablet_textsize">17sp</dimen>
|
|
<dimen name="brave_news_publisher_group_title_phone_textsize">15sp</dimen>
|
|
<dimen name="brave_news_publisher_group_desc_tablet_textsize">14sp</dimen>
|
|
<dimen name="brave_news_publisher_group_desc_phone_textsize">12sp</dimen>
|
|
<dimen name="brave_news_category_group_source_tablet_textsize">16sp</dimen>
|
|
<dimen name="brave_news_category_group_source_phone_textsize">12sp</dimen>
|
|
<dimen name="brave_news_category_group_title_tablet_textsize">17sp</dimen>
|
|
<dimen name="brave_news_category_group_title_phone_textsize">13sp</dimen>
|
|
<dimen name="brave_news_category_group_desc_tablet_textsize">15sp</dimen>
|
|
<dimen name="brave_news_category_group_desc_phone_textsize">11sp</dimen>
|
|
|
|
<!-- Quick Action Search Widget -->
|
|
<dimen name="quick_action_search_widget_small_margin_vertical">12dp</dimen>
|
|
|
|
<!-- Override of chromium's toolbar hairline height -->
|
|
<dimen name="toolbar_hairline_height">0dp</dimen>
|
|
|
|
<!-- Override of chromium's Search engine logo -->
|
|
<dimen name="omnibox_search_engine_logo_composed_size">20dp</dimen>
|
|
</resources>
|