Previously, the icon for the "Brave Shields & privacy" item in the
Settings section used the Brave lion. This commit changes it to the
shields icon.
However, this comes with the caveat that since ic_shield_done.xml
defines a gradient, we have had to create a new
ic_shield_done_nogradient with a flat fillColor reference in order to
match the desired visual style from Figma.
The title of the settings has been fixed by adding our own override of
getPageTitle that returns an observable which we initialise from the
appropriate localisation string. Previously, setTitle was simply being
called which evidently was insufficient to actually make the title
change.
Resolvesbrave/brave-browser#51347
Oliver
0f9dbf8fb3