Files
brave-core/components/sync
Claudio DeSouza 12c8cd6c91 [cr141] DetermineAccountToUse deleted
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/b28c039343fef4ae2b4514193c7969df916d1630
https://chromium.googlesource.com/chromium/src/+/125c24ee56dc5860fd442615a9a099570fb957a3

commit b28c039343fef4ae2b4514193c7969df916d1630
Author: Marc Treib <treib@chromium.org>
Date:   Mon Aug 18 09:11:20 2025 -0700

    Sync: Determine account managed-ness in SyncAuthManager

    Currently, multiple data types (at least HISTORY and CONTACT_INFO)
    determine independently, in their DataTypeController, whether the
    primary account is managed or not (and turn themselves off if so).

    This CL adds the managed-ness determination to the core sync machinery
    (specifically SyncAuthManager), from where it's passed to the data types
    via ConfigureContext.

    Note that no data types use this yet - the plan is to first let this
    roll out, ensure it doesn't unduly slow down sync startup etc, and then
    switch over the actual data type implementations.

    Bug: 40897778
    Change-Id: Ife6e4f3bb4a13d68d2f40c06bdf1f2971d0ac49d
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6550026
    Reviewed-by: Ankush Singh <ankushkush@google.com>
    Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1502743}

commit 125c24ee56dc5860fd442615a9a099570fb957a3
Author: Marc Treib <treib@chromium.org>
Date:   Mon Aug 18 09:40:47 2025 -0700

    SyncAuthManager: Pull account managed-ness checks into separate class

    This CL introduces a new ActiveAccount subclass, which is responsible
    for determining the account's managed-ness status whenever the account
    changes.

    AI notes: This was kinda-sorta AI-generated, but it took a sequence of
    prompts plus a bunch of manual polishing at the end to get there.
    Overall, kinda cool but not actually saving any time, since you have to
    specify in quite a lot of detail what the outcome should be (and I don't
    see how that could be specified in a reusable way).

    Bug: 40897778
    Change-Id: I9bb92a54fbe0c60fc6d0d5820894f2a64aeef2bd
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6853903
    Commit-Queue: Marc Treib <treib@chromium.org>
    Reviewed-by: Ankush Singh <ankushkush@google.com>
    Cr-Commit-Position: refs/heads/main@{#1502763}
2025-09-22 14:59:43 -04:00
..