Files
brave-core/third_party/rust
Claudio DeSouza 4d3098bad7 [cr149][rust] extra_build_script_src_roots dropped in gnrt
This is now just `extra_build_script_input_roots`.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/3197ca477e1f00cc6252cf79bb31c5bc87dc1a6d

commit 3197ca477e1f00cc6252cf79bb31c5bc87dc1a6d
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date:   Mon May 4 11:37:30 2026 -0700

    [gnrt] Use `..._input_roots` for everything and remove `..._src_roots`.

    This change avoids the following problems:

    * Having to say `extra_input_roots = ['../data']` **and also**
      `extra_src_roots = ['../data']` in `gnrt_config.toml` entries for
      multiple ICU crates.  The repetition was introduced because
      `..._input_roots` ignores `.rs` files.  But in both cases the
      discovered files are exposed as GN `inputs` (not `sources`).
      This was reported a while ago by @manishearth in chat, but I forgot to
      open a bug and follow-up... :-(
    * General confusion about how things work, which was encountered when
      tweaking import of `zerocopy` for fuzzing.  This was reported recently
      and captured in https://crbug.com/508339800.

    Before this change `extra_input_roots` wouldn't cover `.rs` files, so
    the removal of `extra_src_roots` means that `extra_input_roots` has to
    also cover `.rs` files after this change.  This in turn means that we
    need to explicitly list files one-by-one in
    `build/rust/std/gnrt_config.toml` to avoid adding unnecessary `.rs`
    files to the generated `BUILD.gn`.  This is a bit unfortunate -
    hopefully this will be fixed by adopting `glob` or a similar globbing
    crate in a follow-up CL.

    Tested by manually running the following tools (and including the
    results in this CL):

    * `tools/crates/run_gnrt.py gen`
    * `tools/rust/gnrt_stdlib.py`
    * `cargo test` and `cargo clippy` in `tools/rust/gnrt`

    Bug: 508339800
    Change-Id: I4db48ca9f5f215a3b5daaa42e9fd4df9e2c122b0
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7810294
    Reviewed-by: Devon Loehr <dloehr@google.com>
    Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1624842}
2026-05-22 16:57:38 -04:00
..