AlexeyBarabash
4ac8ec37fd
* [cr144][Sync] Fix for Tabs from other devices History section Chromium code expects we are signed in, but formally we are not Resolves https://github.com/brave/brave-browser/issues/51834 Chromium change (probably): https://source.chromium.org/chromium/chromium/src/+/e82e3863e751b0ecc228a387fd27bfb7301dc4c1 Refactor HistorySignInState and add isTabsSyncEnabled This change refactors the HistorySignInState enum to remove the distinction between "syncing tabs" and "not syncing tabs" from the enum values. Instead, two separate enums `signInState` and `tabsSyncState` are introduced and passed to the synced device manager as a HistoryIdentityState struct. The UI logic in `app.ts` and `synced_device_manager.ts` is updated to use both `signInState` and `tabsSyncState` fields to determine the correct display and behavior (the behavior stays exactly the same as it was before this refactoring). The backend now fires a `history-identity-statw-changed` event. BYPASS_LARGE_CHANGE_WARNING: this number of changed lines came from renaming files Bug: 418144407 Change-Id: Ief342e124fdbff5c98ad28fe967bd1275f97ad3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7201857
14 lines
763 B
Diff
14 lines
763 B
Diff
diff --git a/chrome/browser/resources/history/synced_device_manager.ts b/chrome/browser/resources/history/synced_device_manager.ts
|
|
index 9a98032a14a071b6b8e2b6a36be1165034f82b9b..47cb457b8f7d38d366a96d22b2f06ce35347a391 100644
|
|
--- a/chrome/browser/resources/history/synced_device_manager.ts
|
|
+++ b/chrome/browser/resources/history/synced_device_manager.ts
|
|
@@ -441,8 +441,6 @@ export class HistorySyncedDeviceManagerElement extends
|
|
}
|
|
} else if (this.isSignInState_(HistorySignInState.SIGNED_OUT)) {
|
|
// User signed out, clear synced device list and show the sign in promo.
|
|
- this.clearDisplayedSyncedDevices_();
|
|
- return;
|
|
}
|
|
this.updateSyncedDevices_();
|
|
// User signed in, show the loading message when querying for synced
|