Error message was:
```
ERROR at //chrome/browser/content_settings/host_content_settings_map_unittest.cc:79:11: Can't include this header from here.
^----------------------------------
The target:
//chrome/browser/content_settings:unit_tests
is including a file from the target:
//brave/extensions:common
It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.
Dependency chain (there may also be others):
//chrome/browser/content_settings:unit_tests -->
//chrome/browser:browser --[private]-->
//brave/extensions:common
```
In upstream Chromium, extensions/common/url_pattern_set.h
belongs to //extensions/common which is a real target.
But on Android where enable_extensions=false, that target
doesn't exist/isn't built. So effectively, on Android, the
header has no upstream owner — and Brave's source_set
//brave/extensions:common "claims" to make it available.
Source
chrome/browser/content_settings/host_content_settings_map_unittest.cc
is at
//chrome/browser/content_settings:unit_tests
but does not depend on //brave/extensions:common .
This is the complain of the gn_check.
The purpose of deprecated_visibility_allowed is only to prevent
new uses of url_pattern_set, current commit doesn't introduce that.
The upside - no need to patch chrome/browser/content_settings:unit_tests,
as depenence is visible through
//chrome/browser/content_settings:unit_tests -->
//chrome/browser:browser -->
//chrome/browser:browser_public_dependencies
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/7307848029fabb938e5cce51d0e3581d1096a58b
commit 7307848029fabb938e5cce51d0e3581d1096a58b
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Mar 16 18:26:20 2026 -0700
Add new ExtensionInstallTimePermissionProvider
It provides the status of permissions which are enabled via
extension manifests. Current analysis shows that only
geolocation and notifications are relevant.
With support for extensions in desktop android, the SiteSettings page should show when extensions have permissions enabled. Desktop looks
up these permissions via site_settings_helper GetPermissionResultForOriginWithoutContext(), but it can be done
via HostContentsSettingsMap by adding this new provider.
Bug: 40215363
Bug: 458227842
Change-Id: I4528923a56d0d20e1ab8a166dd729d4accc50d48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7627082
Reviewed-by: Elias Klim <elklm@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1600254}
AlexeyBarabash
b8f04fec8a