Files
brave-core/components/browser_ui
AlexeyBarabash 682d583938 [Android] Site Settings should work the same for any Containment option (#35509)
[Android] Fix divider preference removed by upstream in SiteSettings

Resolves https://github.com/brave/brave-browser/issues/54486

This commit adapts the Site settings for both
cases - when Android Settings Containment flag is
turned off or on.

Upstream removed the `divider` preference from the screen when
`isSettingsContainmentEnabled()` is true. Our order-adjustment code in
`configureBravePreferences` relied on it being present, causing a null
assert failure.

Chromium change:
https://source.chromium.org/chromium/chromium/src/+/3e7c1090fe6836b828c58f6ce31ef786aebce69a

commit 3e7c1090fe6836b828c58f6ce31ef786aebce69a
Author: Gazal <agazal@google.com>
Date:   Tue Sep 30 14:10:19 2025 -0700

    [Settings containment]  Remove unwanted dividers in Site Settings and All Sites pages

    Before: https://screenshot.googleplex.com/9nQ28EheaL6E5yR.png
    After: https://screenshot.googleplex.com/87LzVJaFcqxX2DU.png

    Bug: 433576895, 439725777
    Change-Id: I55cf2f6a88d108d19c9fcc0be199194ee08bbe91
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6998571
    Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
    Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
    Auto-Submit: Gazal Agarwal <agazal@google.com>
    Cr-Commit-Position: refs/heads/main@{#1523141}
2026-04-15 12:24:40 +03:00
..