This function used to use an out param to communicate its result.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/86d098d0210c5fad5e10ae8eab563fd49b349354
commit 86d098d0210c5fad5e10ae8eab563fd49b349354
Author: Chris Fredrickson <cfredric@chromium.org>
Date: Tue Jun 27 15:52:05 2023 +0000
Reland "Refactor GetSettingsForOneType API to avoid out-param"
This is a reland of commit fe104a2598dbe5b3b276b65883a6141f3cc414ab
Patchset 2 has the difference between this CL and the original (fixes
a build failure with another CL that crossed mid-submit).
Original change's description:
> Refactor GetSettingsForOneType API to avoid out-param
>
> The style guide says to prefer returning by value, since it is clearer
> and often performs the same or better than an out-param.
>
> Out-params can be useful to allow reusing a single allocation, but
> none of the callers of GetSettingsForOneType took advantage of that,
> so there is no reason to prefer the out-param.
Claudio DeSouza
5664b43657