This change adds `[[clang::no_destroy]]` to all places where
`-Wexit-time-destructors` has caused an error. This is a mechanical
change, and the individual cases must be fixed separately.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/62849b7b1a562b823e34e64ec54b9724dc88cbfd
commit 62849b7b1a562b823e34e64ec54b9724dc88cbfd
Author: Claudio DeSouza <cdesouza@chromium.org>
Date: Mon Aug 25 07:58:19 2025 -0700
Reland "[exit-time-destructors] Enable by default"
This reverts commit cfbf29170f0b3e73e580d291085c188f8aa8cfa0.
The cause for the revert was breakage elsewhere that needed exclusions,
which are being handdled in https://crrev.com/c/6863758
Bug: 40031409, 430332953
Original change's description:
> Revert "[exit-time-destructors] Enable by default"
>
> This reverts commit 180c32cb5158bb4039235288b38813697b757e1a.
>
> Reason for revert: Broke the build on some bots:
> https://ci.chromium.org/ui/p/chromium/builders/ci/chromeos-arm-generic-rel/148963/overview
>
> Bug: 40031409, 430332953
> Original change's description:
> > [exit-time-destructors] Enable by default
> >
> > This CL enables `-Wexit-time-destructors` as a default warning in
> > Chromium. As the value of `is_wexit_time_destructors_default` is being
> > flipped, it is expected that the old config, `wexit_time_destructors`,
> > which was a opt-in, will become no-op, while the newly introduced
> > opt-out config will have its effect in places with pending issues.
> >
> > There are exclusions being added to `warning_suppression.txt` for
> > certain paths under `//third_party/`. These entries attempt to be the
> > narrowest possible. Work is under way to eliminate completely the need
> > for these, but this is in general slow (although fixes have been merged
> > into dawn, v8, and pdfium).
> >
> > Bug: 40031409, 430332953
> > Change-Id: I0c01c1e4ef8dfdcc319538cbda7991f364a6f22c
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6826535
> > Reviewed-by: Devon Loehr <dloehr@google.com>
> > Commit-Queue: Claudio DeSouza <cdesouza@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1502919}
>
> Bug: 40031409, 430332953
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: Icefe8b2206147767f0c074362e995af2030a1fd6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6860282
> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Devon Loehr <dloehr@google.com>
> Cr-Commit-Position: refs/heads/main@{#1502936}
Bug: 40031409, 430332953
Change-Id: Ib556482a0b31814107eafe3620af13e0d272cd76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6859042
Reviewed-by: William Liu <liuwilliam@chromium.org>
Reviewed-by: Devon Loehr <dloehr@google.com>
Commit-Queue: Claudio DeSouza <cdesouza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1505863}
Claudio DeSouza
c349e5c3fd