Simon Hong
a4b9cdbda1
Resolves brave/brave-browser#46871 During the launching tab modal dialog(ex, js alert), browser prevent launching modal dailog from inactive tab. When checkcing inactive tab, mostly tab's web contents visibility is checked. So, if it not HIDDEN, dialog is shown. This works well except split view. In split view, inactive split tab's web contents visibility is not HIDDEN. Because of that, tab modal is shown from inactive split tab. To prevent this, TabModalDialogManager/WebContentsModalDialogManager should check tab's activation state also. TEST=SplitViewWithTabDialogBrowserTest.InactiveSplitTabTest
13 lines
739 B
Diff
13 lines
739 B
Diff
diff --git a/components/javascript_dialogs/tab_modal_dialog_manager.cc b/components/javascript_dialogs/tab_modal_dialog_manager.cc
|
|
index 03a1d6e6d2313058596b74be702c794084dbe5f0..bf4732a9e4ca8926138ce567f8b9c8915df2ef6d 100644
|
|
--- a/components/javascript_dialogs/tab_modal_dialog_manager.cc
|
|
+++ b/components/javascript_dialogs/tab_modal_dialog_manager.cc
|
|
@@ -254,6 +254,7 @@ void TabModalDialogManager::CancelDialogs(content::WebContents* web_contents,
|
|
|
|
void TabModalDialogManager::OnVisibilityChanged(
|
|
content::Visibility visibility) {
|
|
+ BRAVE_TAB_MODAL_DIALOG_MANAGER_ON_VISIBILITY_CHANGED
|
|
if (visibility == content::Visibility::HIDDEN) {
|
|
HandleTabSwitchAway(DismissalCause::kTabHidden);
|
|
} else if (pending_dialog_) {
|