cdesouza-chromium
f5c6a0136f
These classes were hoisted and renamed. This has been replaced in Chromium as well. This is a mechanical change for Brave, done with the following script. ``` git grep -lw 'Value::List' | xargs sed -i 's/\bValue::List\b/ListValue/g' git grep -lw 'Value::Dict' | xargs sed -i 's/\bValue::Dict\b/DictValue/g' git cl format ``` Chromium changes: https://chromium.googlesource.com/chromium/src/+/6bc468d481835992696083e99e556516fb7f5f80 ``` commit 6bc468d481835992696083e99e556516fb7f5f80 Author: Avi Drissman <avi@chromium.org> Date: Thu Jan 29 22:14:50 2026 -0800 Remove aliases for base::DictValue and base::ListValue This removes a few last stragglers as well. Fixed: 478100525 Cq-Include-Trybots: luci.chromium.try:win-official,mac-official,linux-official,android-official,android-desktop-x64-official Change-Id: If92142b8ab0562a82c609b71c6b2a7665cea6ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7513889 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Owners-Override: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1577038} ``` Issue: https://github.com/brave/brave-browser/issues/52435
42 lines
1.4 KiB
C++
42 lines
1.4 KiB
C++
/* Copyright (c) 2024 The Brave Authors. All rights reserved.
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
* You can obtain one at https://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "brave/gin/converter_specializations.h"
|
|
|
|
#include <memory>
|
|
#include <utility>
|
|
|
|
#include "content/public/renderer/v8_value_converter.h"
|
|
|
|
namespace gin {
|
|
bool Converter<base::ListValue>::FromV8(v8::Isolate* isolate,
|
|
v8::Local<v8::Value> v8_value,
|
|
base::ListValue* out) {
|
|
std::unique_ptr<base::Value> base_value =
|
|
content::V8ValueConverter::Create()->FromV8Value(
|
|
v8_value, isolate->GetCurrentContext());
|
|
if (!base_value || !base_value->is_list()) {
|
|
return false;
|
|
}
|
|
|
|
*out = std::move(*base_value).TakeList();
|
|
return true;
|
|
}
|
|
|
|
bool Converter<base::DictValue>::FromV8(v8::Isolate* isolate,
|
|
v8::Local<v8::Value> v8_value,
|
|
base::DictValue* out) {
|
|
std::unique_ptr<base::Value> base_value =
|
|
content::V8ValueConverter::Create()->FromV8Value(
|
|
v8_value, isolate->GetCurrentContext());
|
|
if (!base_value || !base_value->is_dict()) {
|
|
return false;
|
|
}
|
|
|
|
*out = std::move(*base_value).TakeDict();
|
|
return true;
|
|
}
|
|
} // namespace gin
|