Emerick Rogul
8aa120bdca
Chromium change: https://source.chromium.org/chromium/chromium/src/+/9cf0e743431df3fc9b60115de3a5eafbd77f24ca commit 9cf0e743431df3fc9b60115de3a5eafbd77f24ca Author: Bryant Chandler <bryantchandler@chromium.org> Date: Fri Mar 28 10:32:33 2025 -0700 Return focus from Chrome to glic on Alt+Shift+G (Windows) This CL uses a Chrome command registered to the shortcut trigger a return of focus from Chrome to the last active glic. There will be a followup CL to make this work on macOS. NO_IFTTT=This isn't included in the context menu Bug: b:392188691
46 lines
1.9 KiB
C++
46 lines
1.9 KiB
C++
// Copyright (c) 2023 The Brave Authors. All rights reserved.
|
|
// This Source Code Form is subject to the terms of the Mozilla Public
|
|
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
// You can obtain one at https://mozilla.org/MPL/2.0/.
|
|
|
|
#include "brave/app/command_utils.h"
|
|
|
|
#include "base/containers/contains.h"
|
|
#include "base/containers/flat_set.h"
|
|
#include "base/test/scoped_feature_list.h"
|
|
#include "brave/components/commands/common/features.h"
|
|
#include "chrome/app/chrome_command_ids.h"
|
|
#include "chrome/browser/ui/views/accelerator_table.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
// Note: If this test fails because an accelerated command isn't present just
|
|
// add the missing command to //brave/app/generate_command_metadata.py
|
|
TEST(CommandUtilsUnitTest, AllAcceleratedCommandsShouldBeAvailable) {
|
|
base::test::ScopedFeatureList features;
|
|
features.InitAndEnableFeature(commands::features::kBraveCommands);
|
|
|
|
auto accelerators = GetAcceleratorList();
|
|
const auto& commands = commands::GetCommands();
|
|
|
|
for (const auto& accelerator : accelerators) {
|
|
EXPECT_TRUE(base::Contains(commands, accelerator.command_id))
|
|
<< "Accelerated command '" << accelerator.command_id
|
|
<< "' was not present in the list of commands.";
|
|
}
|
|
}
|
|
|
|
TEST(CommandUtilsUnitTest, NoTranslationsIncludeAmpersand) {
|
|
base::test::ScopedFeatureList features;
|
|
features.InitAndEnableFeature(commands::features::kBraveCommands);
|
|
|
|
for (const auto& command : commands::GetCommands()) {
|
|
auto translation = commands::GetCommandName(command);
|
|
EXPECT_FALSE(base::Contains(translation, "&"))
|
|
<< translation
|
|
<< " contains an '&' character. If this '&' is meant to be in the "
|
|
"translation then this might be a false positive, in which case the "
|
|
"test should be updated. The test is to ensure keyboard shortcuts "
|
|
"from menus are not included in the name of commands.";
|
|
}
|
|
}
|