cdesouza-chromium 4a41889aca [CodeHealth] Avoid unnecessary EXPECT_STREQ uses (#29418) ...

This PR removes a lot of unnecessary uses of `EXPECT_STREQ` combined
with calls to `c_str()`, and converts  these comparisons simply to
`std::string` comparisons using `EXPECT_EQ`. This is functionally the
same, but it is arguably easier to read in general.

Resolves https://github.com/brave/brave-browser/issues/46600

2025-06-05 21:10:34 +01:00

..

ai_chat

[iwyu] Fixing inclusions for string_util.h pt.1 (#29376)

2025-06-04 16:15:27 +01:00

android

Rename background_video_player_tab_helper into youtube_script_injector_tab_helper (#29233)

2025-05-29 13:51:50 +02:00

autocomplete

Disable building of WebTorrent (#29295)

2025-05-28 16:08:25 -07:00

autoplay

Reland "Fix includes for base::StringPrintf" (#29191)

2025-05-23 15:05:58 +01:00

banners

…

bookmarks/android

…

brave_adaptive_captcha

[Rewards] Remove Rewards 3.0 feature flag (#28199)

2025-05-30 05:54:37 -04:00

brave_ads

[iwyu] Fixing inclusions for string_util.h pt.1 (#29376)

2025-06-04 16:15:27 +01:00

brave_news

Android remote keyed services (#28998)

2025-05-09 21:12:57 +02:00

brave_referrals

…

brave_rewards

[Rewards] Remove rewards-image data source (#29325)

2025-06-05 12:00:59 -04:00

brave_search

Reland "Fix includes for base::StringPrintf" (#29191)

2025-05-23 15:05:58 +01:00

brave_shields

[iwyu] Fixing inclusions for string_util.h pt.1 (#29376)

2025-06-04 16:15:27 +01:00

brave_stats

[CodeHealth] Avoid unnecessary EXPECT_STREQ uses (#29418)

2025-06-05 21:10:34 +01:00

brave_vpn

[iwyu] Fixing inclusions for string_util.h pt.1 (#29376)

2025-06-04 16:15:27 +01:00

brave_wallet

[iwyu] Fixing inclusions for string_util.h pt.1 (#29376)

2025-06-04 16:15:27 +01:00

browsing_data

…

component_updater

…

content_settings

[Cardano] Add Cardano site permission (#29101)

2025-05-28 13:28:32 +07:00

cosmetic_filters

[cr137] components/tab_collections -> components/tab

2025-05-13 15:52:45 -04:00

day_zero_browser_ui_expt

Android onboarding variants (#28426)

2025-04-03 10:52:03 -04:00

debounce

…

decentralized_dns/test

[iwyu] Fixing inclusions for string_number_conversions.h (#29269)

2025-05-28 21:12:41 +01:00

download

[CodeHealth] Avoid unnecessary EXPECT_STREQ uses (#29418)

2025-06-05 21:10:34 +01:00

ephemeral_storage

[CodeHealth] Avoid inefficient std::string(other_string.c_str()) (#29386)

2025-06-04 19:53:44 +01:00

extensions

[iwyu] Fixing inclusions for string_util.h pt.1 (#29376)

2025-06-04 16:15:27 +01:00

farbling

[CodeHealth] Avoid inefficient std::string(other_string.c_str()) (#29386)

2025-06-04 19:53:44 +01:00

first_run

…

gcm_driver

…

geolocation

…

hub/internal/android

[cr137] [Android] Redefine the hub pane selector display layout

2025-05-13 15:53:18 -04:00

importer

Fixed uncatched crash on extension re-import. (#29413)

2025-06-05 19:10:44 +02:00

incognito/android

…

infobars

[CodeHealth] remove brave_l10n::GetLocalizedResourceUTF16String (#28889)

2025-05-01 04:22:24 -07:00

mac

Revert "Allow Mac app to quit when an update is available" (#29202)

2025-05-24 07:39:15 -07:00

metrics

…

misc_metrics

Android remote keyed services (#28998)

2025-05-09 21:12:57 +02:00

net

[iwyu] Fixing inclusions for string_util.h pt.1 (#29376)

2025-06-04 16:15:27 +01:00

new_tab

…

notifications

…

ntp_background

[CodeHealth] Avoid inefficient std::string(other_string.c_str()) (#29386)

2025-06-04 19:53:44 +01:00

ntp_background_images

…

onboarding

[iwyu] Fixing inclusions for string_util.h pt.1 (#29376)

2025-06-04 16:15:27 +01:00

p3a

…

partnercustomizations

…

password_manager

[iwyu] Fixing inclusions for string_number_conversions.h (#29269)

2025-05-28 21:12:41 +01:00

perf

…

permissions

[iwyu] Fixing inclusions for string_util.h pt.1 (#29376)

2025-06-04 16:15:27 +01:00

playlist

[CodeHealth] Avoid unnecessary EXPECT_STREQ uses (#29418)

2025-06-05 21:10:34 +01:00

policy

…

preferences/android/java_templates

…

prefs

…

profile_resetter

…

profiles

Remove Ethereum Remote Client (Crypto Wallets) (#29135)

2025-05-23 16:56:41 -04:00

psst

…

quick_search_engines/android

Add a separate target for quick search engine feature (#26478)

2025-04-23 17:00:28 -04:00

renderer_context_menu

[CodeHealth] remove brave_l10n::GetLocalizedResourceUTF16String (#28889)

2025-05-01 04:22:24 -07:00

request_otr

Reland "Fix includes for base::StringPrintf" (#29191)

2025-05-23 15:05:58 +01:00

resources

[ads] Survey Panelist: Desktop (#28995)

2025-06-02 12:05:39 -05:00

safe_browsing/android/java

…

sandbox

…

script_injector

Reland "Fix includes for base::StringPrintf" (#29191)

2025-05-23 15:05:58 +01:00

search_engines

[cr137] GetPrepopulatedEngines with RegionalCapabilities

2025-05-13 15:52:48 -04:00

sessions

Reland "Fix includes for base::StringPrintf" (#29191)

2025-05-23 15:05:58 +01:00

share/android

…

sharing_hub

…

shell_integrations/buildflags

…

skus

[iwyu] Fixing inclusions for string_util.h pt.1 (#29376)

2025-06-04 16:15:27 +01:00

speedreader

[iwyu] Fixing inclusions for string_number_conversions.h (#29269)

2025-05-28 21:12:41 +01:00

ssl

[cr137] Fixes CertificateTransparencyBrowserTest.

2025-05-13 15:52:56 -04:00

storage_access_api

…

sync

…

tab_group_sync

[Android] Prevent cleaning of tab groups without sync id (#29201)

2025-05-23 23:56:25 +03:00

tab_ui/android

…

tabmodel/android

…

test

[CodeHealth] Avoid unnecessary EXPECT_STREQ uses (#29418)

2025-06-05 21:10:34 +01:00

themes

[CodeHealth] remove brave_l10n::GetLocalizedResourceUTF16String (#28889)

2025-05-01 04:22:24 -07:00

tor

Reland "Fix includes for base::StringPrintf" (#29191)

2025-05-23 15:05:58 +01:00

touch_to_fill/password_manager/android/internal/java/res/layout

…

translate

[CodeHealth] Avoid inefficient std::string(other_string.c_str()) (#29386)

2025-06-04 19:53:44 +01:00

ui

[CodeHealth] Avoid unnecessary EXPECT_STREQ uses (#29418)

2025-06-05 21:10:34 +01:00

url_sanitizer

Use correct profile for Android url sanitizer service (#29206)

2025-05-29 18:25:11 +02:00

user_education

…

web_discovery

[iwyu] Remove superfluous gurl.h inclusions (#29242)

2025-05-27 21:10:52 +01:00

web_package

…

webcompat_reporter

Use correct profile to create webcompat reporter service (#29175)

2025-05-23 00:15:09 +02:00

widevine

[CodeHealth] remove brave_l10n::GetLocalizedResourceUTF16String (#28889)

2025-05-01 04:22:24 -07:00

about_flags.cc

[iwyu] Fixing inclusions for string_util.h pt.1 (#29376)

2025-06-04 16:15:27 +01:00

brave_app_controller_mac_browsertest.mm

…

brave_app_controller_mac.h

…

brave_app_controller_mac.mm

…

brave_autofill_browsertest.cc

…

brave_browser_features.cc

…

brave_browser_features.h

…

brave_browser_main_extra_parts.cc

…

brave_browser_main_extra_parts.h

…

brave_browser_main_parts_mac.h

…

brave_browser_main_parts_mac.mm

…

brave_browser_main_parts.cc

Rename background_video_player_tab_helper into youtube_script_injector_tab_helper (#29233)

2025-05-29 13:51:50 +02:00

brave_browser_main_parts.h

…

brave_browser_process_impl.cc

[iwyu] Remove superfluous gurl.h inclusions (#29242)

2025-05-27 21:10:52 +01:00

brave_browser_process_impl.h

…

brave_browser_process.cc

…

brave_browser_process.h

…

brave_content_browser_client_browsertest.cc

[CodeHealth] Avoid unnecessary EXPECT_STREQ uses (#29418)

2025-06-05 21:10:34 +01:00

brave_content_browser_client_unittest.cc

Remove Ethereum Remote Client (Crypto Wallets) (#29135)

2025-05-23 16:56:41 -04:00

brave_content_browser_client.cc

[Rewards] Remove Rewards 3.0 feature flag (#28199)

2025-05-30 05:54:37 -04:00

brave_content_browser_client.h

…

brave_drm_tab_helper.cc

…

brave_drm_tab_helper.h

…

brave_features_internal_names.h

…

brave_local_state_prefs.cc

Add Tab Focus Mode metrics

2025-04-15 11:28:01 -07:00

brave_local_state_prefs.h

…

brave_prefs_browsertest.cc

Remove Ethereum Remote Client (Crypto Wallets) (#29135)

2025-05-23 16:56:41 -04:00

brave_profile_prefs.cc

Tweak background video playback description in flag page (#29207)

2025-05-29 11:33:22 +02:00

brave_profile_prefs.h

…

brave_resources_browsertest.cc

…

brave_resources_util_unittest.cc

[CodeHealth] remove brave_l10n::GetLocalizedResourceUTF16String (#28889)

2025-05-01 04:22:24 -07:00

brave_scheme_load_browsertest.cc

[CodeHealth] Avoid unnecessary EXPECT_STREQ uses (#29418)

2025-06-05 21:10:34 +01:00

brave_shell_integration_mac.h

…

brave_shell_integration_mac.mm

…

brave_shell_integration_win.cc

…

brave_shell_integration_win.h

…

brave_shell_integration.cc

…

brave_shell_integration.h

…

brave_tab_helpers.cc

Rename background_video_player_tab_helper into youtube_script_injector_tab_helper (#29233)

2025-05-29 13:51:50 +02:00

brave_tab_helpers.h

…

browser_context_keyed_service_factories.cc

Remove Ethereum Remote Client (Crypto Wallets) (#29135)

2025-05-23 16:56:41 -04:00

browser_context_keyed_service_factories.h

…

BUILD.gn

Remove Ethereum Remote Client (Crypto Wallets) (#29135)

2025-05-23 16:56:41 -04:00

default_protocol_handler_utils_win_unittest.cc

…

default_protocol_handler_utils_win.cc

[iwyu] Fixing inclusions for string_util.h pt.1 (#29376)

2025-06-04 16:15:27 +01:00

default_protocol_handler_utils_win.h

…

DEPS

Add containers feature and brave://flag. (#29229)

2025-05-28 21:13:48 +07:00

mac_features.cc

…

mac_features.h

…

sources.gni

Rename background_video_player_tab_helper into youtube_script_injector_tab_helper (#29233)

2025-05-29 13:51:50 +02:00

update_util.cc

…

update_util.h

…