Files
brave-core/android/java
Artem Samoilenko 9cc9abab5f [Android] Rename NoUnderlineClickableSpan to ChromeClickableSpan
Chromium change:
https://chromium.googlesource.com/chromium/src/+/eda1322af61acc3f5cb40191fe897dc93d4b5095

Add underline to links

Based on the a11y team’s request, added underline to links across the product per GAR requirements.
Renamed NoUnderlineClickableSpan to ChromeClickableSpan and removed #setUnderlineText(false).
Updated ~70 render tests that were failing due to this fix.

The following are some of the before & after screenshots:

1. Delete browsing data
Before: https://screenshot.googleplex.com/69tSeP6YBGr95VU
After: https://screenshot.googleplex.com/7WujhWgczf2WmAj

2. Include surrounding text in Google searches
Before: https://screenshot.googleplex.com/9g8VhvttwhTJ79G
After: https://screenshot.googleplex.com/9jPxBG265WErHVk

3. Sad tab
Before: https://screenshot.googleplex.com/4qv7jVva8m9wnP3
After: https://screenshot.googleplex.com/5PwokFga4cw84KN

4. Autofill services
Before: https://screenshot.googleplex.com/Anvz2MZkC3dVEsP
After: https://screenshot.googleplex.com/8arauGBc6JrJQB5

5. Sign-in footer
Before: https://screenshot.googleplex.com/3dQ9kbgWpTvgGX8
After: https://screenshot.googleplex.com/6KBiPUxXyhdxvQc

6. Delete browsing data basic
Before: https://screenshot.googleplex.com/7Xf2kjSVBnjtb2C
After: https://screenshot.googleplex.com/7ZPRWZ7ofpnjEYn

7. Price tracking notifications
Before: https://screenshot.googleplex.com/8yNPhgd4yyjPuiH
After: https://screenshot.googleplex.com/BmhMTVaGjkK427n

8. Safe Browsing
Before: https://screenshot.googleplex.com/6Vtbvea44YQpkyF
After: https://screenshot.googleplex.com/8eHVcHbcjtoYb9H

Bug: 344043844
2025-01-27 09:41:44 -05:00
..
2025-01-27 09:41:36 -05:00