Anthony Tseng
bb1a0b8fab
* [History Embeddings] Hide UI entry points that imply a cloud round-trip
Strip the pieces that either ask the user for feedback we don't send
anywhere or link to a settings page we don't expose:
- cr-feedback-buttons (thumbs up/down) in the history embeddings
results card — no telemetry for an on-device feature.
- "Learn more" link in the chrome://history disclaimer and in the
history side panel — both pointed at historyEmbeddingsSettingsUrl.
- "Manage your history search setting" link in the IPH promo.
- "Learn more" link in the omnibox history embeddings disclaimer
IPH row — pass empty link_text/GURL() so the disclaimer still
renders without a link.
Part of https://github.com/brave/brave-browser/issues/54798
* [History Embeddings] Reword disclaimer and hide chrome://settings/ai
Brave's history semantic search runs entirely on-device (see
brave/browser/history_embeddings/README.md), so:
- IDS_HISTORY_EMBEDDINGS_DISCLAIMER{,_LOGGING_OFF} and
IDS_OMNIBOX_HISTORY_EMBEDDINGS_DISCLAIMER_IPH text about data being
sent to Brave and seen by human reviewers is inaccurate. Add
IDS_BRAVE_HISTORY_EMBEDDINGS_DISCLAIMER (in brave_generated_resources)
and IDS_BRAVE_OMNIBOX_HISTORY_EMBEDDINGS_DISCLAIMER_IPH (in
brave_components_strings) and swap the IDS in the chromium_src
overrides for history_embeddings_utils.cc and
featured_search_provider.cc. Owning the strings outright is resilient
to upstream wording tweaks. Neither override requires a new GN dep:
brave/grit/brave_generated_resources.h is reachable via the existing
//chrome/app:generated_resources transitive dep, and
components/grit/brave_components_strings.h via the existing
brave_components_omnibox_browser_deps injection.
- Force IsHistoryEmbeddingsSettingVisible() to false so the
chrome://settings/ai/historySearch entry — and, transitively, the
whole AI settings page and menu entry — drops out. Brave has no
user-facing toggle for this feature.
Part of https://github.com/brave/brave-browser/issues/54798
15 lines
718 B
Diff
15 lines
718 B
Diff
diff --git a/chrome/browser/resources/history/history_embeddings_promo.html.ts b/chrome/browser/resources/history/history_embeddings_promo.html.ts
|
|
index 1948b83f22cc1fb0d56ebe61f8ba223245b5294f..2bbfaf51bcf39e12dbf03c2f2c30f44927c59cec 100644
|
|
--- a/chrome/browser/resources/history/history_embeddings_promo.html.ts
|
|
+++ b/chrome/browser/resources/history/history_embeddings_promo.html.ts
|
|
@@ -33,9 +33,6 @@ export function getHtml(this: HistoryEmbeddingsPromoElement) {
|
|
</div>
|
|
<div>
|
|
$i18n{historyEmbeddingsDisclaimer}
|
|
- <a href="$i18n{historyEmbeddingsSettingsUrl}" target="_blank">
|
|
- $i18n{historyEmbeddingsPromoSettingsLinkText}
|
|
- </a>
|
|
</div>
|
|
</div>
|
|
</div>
|