We were synchronizing the new browser created during drag-and-drop and it caused the new browser to be dangling in some cases. For e.g. * Drag a non-pinned tab out of a window to create a new window * Don't drop and drag it back to the original window * Open tab search button and see if the dummy pinned tab is gone. => The dummy tab for new window can be dangling, even the browser looks gone.
49 lines
1.3 KiB
C++
49 lines
1.3 KiB
C++
/* Copyright (c) 2022 The Brave Authors. All rights reserved.
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
* You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "brave/browser/ui/brave_browser_window.h"
|
|
|
|
#include <vector>
|
|
|
|
// Provide a base implementation (important for `TestBrowserWindow ` in tests)
|
|
// For real implementation, see `BraveBrowserView`.
|
|
|
|
speedreader::SpeedreaderBubbleView* BraveBrowserWindow::ShowSpeedreaderBubble(
|
|
speedreader::SpeedreaderTabHelper* tab_helper,
|
|
speedreader::SpeedreaderBubbleLocation location) {
|
|
return nullptr;
|
|
}
|
|
|
|
gfx::Rect BraveBrowserWindow::GetShieldsBubbleRect() {
|
|
return gfx::Rect();
|
|
}
|
|
|
|
// static
|
|
BraveBrowserWindow* BraveBrowserWindow::From(BrowserWindow* window) {
|
|
return static_cast<BraveBrowserWindow*>(window);
|
|
}
|
|
|
|
#if defined(TOOLKIT_VIEWS)
|
|
sidebar::Sidebar* BraveBrowserWindow::InitSidebar() {
|
|
return nullptr;
|
|
}
|
|
|
|
void BraveBrowserWindow::ToggleSidebar() {}
|
|
|
|
bool BraveBrowserWindow::HasSelectedURL() const {
|
|
return false;
|
|
}
|
|
|
|
void BraveBrowserWindow::CleanAndCopySelectedURL() {}
|
|
|
|
bool BraveBrowserWindow::ShowBraveHelpBubbleView(const std::string& text) {
|
|
return false;
|
|
}
|
|
#endif // defined(TOOLKIT_VIEWS)
|
|
|
|
bool BraveBrowserWindow::IsInTabDragging() const {
|
|
return false;
|
|
}
|