Claudio DeSouza
c40fa41402
Chromium changes: https://chromium.googlesource.com/chromium/src/+/a7ea861d95f70515cbddad5ea07b29ba144f5659 commit a7ea861d95f70515cbddad5ea07b29ba144f5659 Author: Foromo Daniel Soromou <koretadaniel@chromium.org> Date: Thu Apr 30 08:15:42 2026 -0700 Extract browser navigator into a separate build target NOTE: This change is trivial and do not change any behavior. Extract the browser navigator code and its associated parameters from the monolithic `chrome/browser/ui` build target into a dedicated `chrome/browser/ui/navigator` directory and build configuration. This refactoring establishes a new standalone build file containing dedicated source sets for the navigator component. Consequently, the `browser_navigator_params_headers` source set and related source files are removed from `chrome/browser/ui/BUILD.gn`. Numerous build files across the `chrome/browser` directory are updated to replace the old dependency with the new `//chrome/browser/ui/navigator` target. This modularization decouples UI components, streamlines dependency management, and improves overall build structure. A follow up CL will move the files under c/b/ui/navigator and rename the include places. Bug: none Change-Id: I65c10afadfb1dc3857a3714cdbce6d06201633ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7803848 Reviewed-by: Dana Fried <dfried@chromium.org> Reviewed-by: Kaan Alsan <alsan@chromium.org> Commit-Queue: Foromo Daniel Soromou <koretadaniel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1623210}
159 lines
4.6 KiB
Plaintext
159 lines
4.6 KiB
Plaintext
# Copyright (c) 2021 The Brave Authors. All rights reserved.
|
|
# This Source Code Form is subject to the terms of the Mozilla Public
|
|
# License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
# You can obtain one at https://mozilla.org/MPL/2.0/.
|
|
|
|
import("//brave/components/ai_chat/core/common/buildflags/buildflags.gni")
|
|
import("//brave/components/brave_origin/buildflags/buildflags.gni")
|
|
import("//brave/components/brave_talk/buildflags/buildflags.gni")
|
|
import("//brave/components/brave_wallet/common/buildflags/buildflags.gni")
|
|
import("//brave/components/playlist/core/common/buildflags/buildflags.gni")
|
|
import("//build/config/ui.gni")
|
|
import("//extensions/buildflags/buildflags.gni")
|
|
|
|
assert(toolkit_views)
|
|
|
|
source_set("sidebar") {
|
|
sources = [
|
|
"sidebar.h",
|
|
"sidebar_model.h",
|
|
]
|
|
|
|
public_deps = [
|
|
"//base",
|
|
"//brave/components/sidebar/browser",
|
|
"//components/history/core/browser",
|
|
]
|
|
}
|
|
|
|
source_set("sidebar_impl") {
|
|
sources = [
|
|
"features.cc",
|
|
"features.h",
|
|
"sidebar_controller.cc",
|
|
"sidebar_controller.h",
|
|
"sidebar_model.cc",
|
|
"sidebar_service_factory.cc",
|
|
"sidebar_service_factory.h",
|
|
"sidebar_tab_helper.cc",
|
|
"sidebar_tab_helper.h",
|
|
"sidebar_utils.cc",
|
|
"sidebar_utils.h",
|
|
"sidebar_web_panel_controller.cc",
|
|
"sidebar_web_panel_controller.h",
|
|
]
|
|
|
|
public_deps = [ "//brave/components/sidebar/browser" ]
|
|
|
|
deps = [
|
|
":sidebar",
|
|
"//base",
|
|
"//brave/browser/ui/sidebar/buildflags",
|
|
"//brave/browser/ui/views/frame/split_view",
|
|
"//brave/components/brave_origin/buildflags",
|
|
"//brave/components/brave_talk/buildflags",
|
|
"//brave/components/sidebar/common",
|
|
"//chrome/browser:browser_process",
|
|
"//chrome/browser/favicon",
|
|
"//chrome/browser/first_run",
|
|
"//chrome/browser/history",
|
|
"//chrome/browser/image_fetcher",
|
|
"//chrome/browser/profiles",
|
|
"//chrome/browser/search",
|
|
"//chrome/browser/search_engines",
|
|
"//chrome/browser/ui:ui_features",
|
|
"//chrome/browser/ui/browser_window",
|
|
"//chrome/browser/ui/navigator",
|
|
"//chrome/browser/ui/side_panel",
|
|
"//chrome/browser/ui/side_panel:side_panel_views_dependent",
|
|
"//chrome/browser/ui/tabs:tab_strip",
|
|
"//chrome/browser/ui/views/side_panel",
|
|
"//components/image_fetcher/core",
|
|
"//components/pref_registry",
|
|
"//components/prefs",
|
|
"//components/user_prefs",
|
|
"//ui/base",
|
|
]
|
|
}
|
|
|
|
source_set("browser_tests") {
|
|
testonly = true
|
|
defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
|
|
|
|
sources = [
|
|
"//brave/browser/ui/sidebar/sidebar_browsertest.cc",
|
|
"//brave/browser/ui/views/sidebar/sidebar_container_view_browsertest.cc",
|
|
]
|
|
|
|
deps = [
|
|
":sidebar",
|
|
":sidebar_impl",
|
|
"//base",
|
|
"//brave/app:command_ids",
|
|
"//brave/browser/ui/sidebar/buildflags",
|
|
"//brave/browser/ui/views/frame",
|
|
"//brave/browser/ui/views/frame/split_view",
|
|
"//brave/browser/ui/views/side_panel",
|
|
"//brave/browser/ui/views/sidebar",
|
|
"//brave/components/ai_chat/core/common/buildflags",
|
|
"//brave/components/brave_talk/buildflags",
|
|
"//brave/components/brave_wallet/common/buildflags",
|
|
"//brave/components/playlist/core/common/buildflags",
|
|
"//brave/components/sidebar/browser",
|
|
"//brave/components/sidebar/common",
|
|
"//chrome/browser",
|
|
"//chrome/browser/profiles:profile",
|
|
"//chrome/browser/search_engines",
|
|
"//chrome/browser/ui",
|
|
"//chrome/browser/ui:ui_features",
|
|
"//chrome/browser/ui/browser_window",
|
|
"//chrome/browser/ui/side_panel:side_panel_views_dependent",
|
|
"//chrome/common:constants",
|
|
"//chrome/test:test_support",
|
|
"//chrome/test:test_support_ui",
|
|
"//components/prefs",
|
|
"//content/test:test_support",
|
|
"//ui/display:test_support",
|
|
"//ui/events",
|
|
"//ui/events:test_support",
|
|
"//ui/gfx",
|
|
]
|
|
|
|
if (enable_ai_chat) {
|
|
deps += [ "//brave/components/ai_chat/core/common" ]
|
|
}
|
|
|
|
if (enable_playlist) {
|
|
deps += [ "//brave/components/playlist/core/common" ]
|
|
}
|
|
}
|
|
|
|
source_set("unit_tests") {
|
|
testonly = true
|
|
|
|
sources = [ "sidebar_unittest.cc" ]
|
|
|
|
deps = [
|
|
":sidebar",
|
|
":sidebar_impl",
|
|
"//base",
|
|
"//brave/common",
|
|
"//brave/components/ai_chat/core/common/buildflags",
|
|
"//brave/components/brave_origin/buildflags",
|
|
"//brave/components/brave_talk/buildflags",
|
|
"//brave/components/playlist/core/common/buildflags",
|
|
"//brave/components/sidebar/browser",
|
|
"//chrome/browser/ui",
|
|
"//chrome/test:test_support",
|
|
"//components/prefs",
|
|
"//components/sync_preferences:test_support",
|
|
"//content/test:test_support",
|
|
"//testing/gmock",
|
|
"//testing/gtest",
|
|
]
|
|
|
|
if (enable_playlist) {
|
|
deps += [ "//brave/components/playlist/core/common" ]
|
|
}
|
|
}
|