This class was still using the deprecated version that is set to be deleted. This change migrates this class to use Oilpan GC for memory management. Chromium changes: https://chromium.googlesource.com/chromium/src/+/61e491610dac67129273aa96549603483c59759f commit 61e491610dac67129273aa96549603483c59759f Author: Andreas Haas <ahaas@chromium.org> Date: Wed Jul 30 03:35:32 2025 -0700 [gin] Delete DeprecatedWrappable This CL deletes gin::DeprecatedWrappable, and classes and data structures related to gin::DeprecatedWrappable. Additionally it removes internal fields of JS wrapper objects that were only used by gin::DeprecatedWrappable, but are not needed anymore with the new gin::Wrappable. Bug: 345640553 Change-Id: Ideb4424048e62fec6c6a7ee5fd60a4635f6ef1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6799157 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#1494071}
120 lines
3.8 KiB
C++
120 lines
3.8 KiB
C++
/* Copyright (c) 2022 The Brave Authors. All rights reserved.
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
* You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
#include "brave/components/speedreader/renderer/speedreader_js_handler.h"
|
|
|
|
#include <utility>
|
|
|
|
#include "base/check.h"
|
|
#include "brave/components/speedreader/common/speedreader.mojom.h"
|
|
#include "brave/components/speedreader/renderer/speedreader_render_frame_observer.h"
|
|
#include "content/public/renderer/render_frame.h"
|
|
#include "gin/converter.h"
|
|
#include "gin/object_template_builder.h"
|
|
#include "gin/wrappable.h"
|
|
#include "mojo/public/cpp/bindings/associated_remote.h"
|
|
#include "third_party/blink/public/common/associated_interfaces/associated_interface_provider.h"
|
|
#include "third_party/blink/public/platform/scheduler/web_agent_group_scheduler.h"
|
|
#include "third_party/blink/public/web/blink.h"
|
|
#include "third_party/blink/public/web/web_local_frame.h"
|
|
#include "v8/include/cppgc/allocation.h"
|
|
#include "v8/include/v8-context.h"
|
|
#include "v8/include/v8-cppgc.h"
|
|
|
|
namespace {
|
|
constexpr const char kSpeedreader[] = "speedreader";
|
|
}
|
|
|
|
namespace speedreader {
|
|
|
|
SpeedreaderJSHandler::SpeedreaderJSHandler(
|
|
base::WeakPtr<SpeedreaderRenderFrameObserver> owner)
|
|
: owner_(std::move(owner)) {}
|
|
|
|
SpeedreaderJSHandler::~SpeedreaderJSHandler() = default;
|
|
|
|
// static
|
|
void SpeedreaderJSHandler::Install(
|
|
base::WeakPtr<SpeedreaderRenderFrameObserver> owner,
|
|
v8::Local<v8::Context> context) {
|
|
DCHECK(owner);
|
|
CHECK(owner->render_frame());
|
|
v8::Isolate* isolate =
|
|
owner->render_frame()->GetWebFrame()->GetAgentGroupScheduler()->Isolate();
|
|
v8::HandleScope handle_scope(isolate);
|
|
|
|
if (context.IsEmpty()) {
|
|
return;
|
|
}
|
|
|
|
v8::Context::Scope context_scope(context);
|
|
v8::Local<v8::Object> global = context->Global();
|
|
|
|
// check object existence
|
|
v8::Local<v8::Value> speedreader_value =
|
|
global->Get(context, gin::StringToV8(isolate, kSpeedreader))
|
|
.ToLocalChecked();
|
|
if (!speedreader_value->IsUndefined()) {
|
|
return;
|
|
}
|
|
|
|
SpeedreaderJSHandler* handler =
|
|
cppgc::MakeGarbageCollected<SpeedreaderJSHandler>(
|
|
isolate->GetCppHeap()->GetAllocationHandle(), std::move(owner));
|
|
|
|
v8::PropertyDescriptor desc(handler->GetWrapper(isolate).ToLocalChecked(),
|
|
false);
|
|
desc.set_configurable(false);
|
|
|
|
global
|
|
->DefineProperty(isolate->GetCurrentContext(),
|
|
gin::StringToV8(isolate, kSpeedreader), desc)
|
|
.Check();
|
|
}
|
|
|
|
gin::ObjectTemplateBuilder SpeedreaderJSHandler::GetObjectTemplateBuilder(
|
|
v8::Isolate* isolate) {
|
|
return gin::Wrappable<SpeedreaderJSHandler>::GetObjectTemplateBuilder(isolate)
|
|
.SetMethod("showOriginalPage", &SpeedreaderJSHandler::ShowOriginalPage)
|
|
.SetMethod("ttsPlayPause", &SpeedreaderJSHandler::TtsPlayPause);
|
|
}
|
|
|
|
void SpeedreaderJSHandler::ShowOriginalPage(v8::Isolate* isolate) {
|
|
DCHECK(isolate);
|
|
if (!owner_) {
|
|
return;
|
|
}
|
|
|
|
mojo::AssociatedRemote<speedreader::mojom::SpeedreaderHost> speedreader_host;
|
|
owner_->render_frame()->GetRemoteAssociatedInterfaces()->GetInterface(
|
|
&speedreader_host);
|
|
|
|
if (speedreader_host.is_bound()) {
|
|
speedreader_host->OnShowOriginalPage();
|
|
}
|
|
}
|
|
|
|
const gin::WrapperInfo* SpeedreaderJSHandler::wrapper_info() const {
|
|
return &kWrapperInfo;
|
|
}
|
|
|
|
void SpeedreaderJSHandler::TtsPlayPause(v8::Isolate* isolate,
|
|
int paragraph_index) {
|
|
DCHECK(isolate);
|
|
if (!owner_) {
|
|
return;
|
|
}
|
|
|
|
mojo::AssociatedRemote<speedreader::mojom::SpeedreaderHost> speedreader_host;
|
|
owner_->render_frame()->GetRemoteAssociatedInterfaces()->GetInterface(
|
|
&speedreader_host);
|
|
|
|
if (speedreader_host.is_bound()) {
|
|
speedreader_host->OnTtsPlayPause(paragraph_index);
|
|
}
|
|
}
|
|
|
|
} // namespace speedreader
|