Emerick Rogul
75268839ce
Chromium change: https://source.chromium.org/chromium/chromium/src/+/e3f001526b14f073e8e517986673ed8a4877fc1a commit e3f001526b14f073e8e517986673ed8a4877fc1a Author: Lei Zhang <thestig@chromium.org> Date: Wed Aug 31 05:14:51 2022 +0000 Enable -Wshadow on Linux. In net/third_party/quiche/BUILD.gn, a build config containing -Wno-shadow accidentally affected its transitive dependencies. As a result, many files introduced shadow variables without triggering -Wshadow warnings. Make the -Wno-shadow config private to the quiche dir for Linux builds, which makes -Wshadow the default for first-party code. Then selectively add temporary -Wno-shadow warnings to build configs that contain files with shadow variables. This prevents developers from adding shadow variables in a large portion of the code base, and makes it easier to finish fixing this issue. Bug: 1344231