The following upstream change registeres VKEY_ESCAPE accelerator for
ProjectPanelsView. This happens on browser window creation before our
AcceleratorService is loaded. Once loaded it triggers
BraveBrowserView::OnAcceleratorsChanged which attemps to register
VKEY_ESCAPE accelerator and in the process finds that the accelerator is
already registered, tries to delete the previous registration and hits a
DCHECK because the accelerator wasn't registered by the view. This
happens because upstream FocusManager::IsAcceleratorRegistered checks if
the accelerator is registered for any target. This change allows us to
check if an accelerator is registered for a specific target.
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/e3acbc26dfa39e4341e20e350fec6b679a11467f
commit e3acbc26dfa39e4341e20e350fec6b679a11467f
Author: Chase Hartsell <chazzy@google.com>
Date: Wed Jan 28 16:02:49 2026 -0800
[projects] Close panel on outside click and Esc
Closing the panel on keyboard focus loss is not implemented yet, as that
will come in a later CL once we fix the focus order for when the panel
is open. This patch also adds the interactive UI tests to the larger
test target so they actually get run.
This patch also removes the observer code from the tab groups view,
since this caused a UAF bug that wasn't caught as the interactive UI
tests were disabled. The displaying of tab groups within the list will
be added back in a future CL.
Demo: http://go/scrcast/NDkwMDI5NDMyMzMzOTI2NHxmZWRjNmMyNC0wMQ
Bug: 475301221, 478258410
Max Karolinskiy
d3471831b1