This class is now called `gin::DeprecatedWrappable`. There seems to be
some work to introduce a new class, but for now it is reverted.
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/3c15226886207c98dffc33a20b6a3dfd7df7a21c
commit 3c15226886207c98dffc33a20b6a3dfd7df7a21c
Author: Andreas Haas <ahaas@chromium.org>
Date: Wed Jul 2 05:57:48 2025 -0700
[gin] Rename gin::Wrappable to gin::DeprecatedWrappable
This is the first CL of a sequence of CLs to refactor gin::Wrappable
such that it is based on cppgc. In a follow-up CL we will re-introduce
`gin::Wrappable` again, and then port all uses from
`gin::DeprecatedWrappable` to `gin::Wrappable`.
BYPASS_LARGE_CHANGE_WARNING
Bug: 345640553
Change-Id: Iad028a1cec93aa8ade3b35c8099f8de5081f88fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6513641
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Owners-Override: Rick Byers <rbyers@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1481539}
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/f99163fe2d3428680834db3f141a6d83590561f0
commit f99163fe2d3428680834db3f141a6d83590561f0
Author: Nina Satragno <nsatragno@chromium.org>
Date: Wed Jul 2 08:36:22 2025 -0700
Revert "[gin] Introduce gin::Wrappable based on cppgc"
This reverts commit dfbe3b4a57ddbfbfc74ab261b51db2ed87f754c2.
Reason for revert: WrappableTest.WrapAndUnwrap failing on Linux
UBSan tests
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/7971/overview
Bug: 345640553
Original change's description:
> [gin] Introduce gin::Wrappable based on cppgc
>
> This CL implements the new `gin::Wrappable` based on cppgc, and ports
> the tests in `wrappable_unittest` from `gin::DeprecatedWrappable` to
> `gin::Wrappable`.
>
> The new implementation of `gin::Wrappable` has sightly different
> semantics than the old one. In the old one it was possible to call
> `Converter<WrappableSubClass>::FromV8()` with any JSObject, and the
> JSObject would either get unwrapped if it wrapped an object of type
> `WrappableSubClass`, or it would return nullptr. The new implementation
> would either return nullptr or crash in a DCHECK if the JSObject wrapped
> an object which is not of type `WrappableSubClass`.
>
> Bug: 345640553
> Change-Id: Ia32e2d82f0383afb56382e9fe78fd94677b00fe8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6519611
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Commit-Queue: Andreas Haas <ahaas@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1481565}
Bug: 345640553
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I6499b57f278ce600d03e2d3bbeaee1df04ba3512
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6701047
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1481635}
Claudio DeSouza
b4dd3a37f7