Claudio DeSouza d3be5ab9f1 [cr149] Using SetHighlightedElement ...

This change migrates from `SetHighlightedButton` to
`SetHighlightedElement`, which expects an element id.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/b382a3d424be203195b983b3d37b258786c839f8
https://chromium.googlesource.com/chromium/src/+/5c61647fa6331ad61b0173fb2780e3ce732445dd

commit b382a3d424be203195b983b3d37b258786c839f8
Author: Maks Orlovich <morlovich@chromium.org>
Date:   Fri Apr 24 11:59:39 2026 -0700

    Finish SetHighlightedButton->Element migration.

    The final user (the CrOS input overlay for games) was working around a
    bug in SetAnchorView not updating the highlight unless it also changed
    the widget (or was being set for the first time). So testcase + fix that
    bug, and remove the now unneeded call.

    With that done, the now unused SetHighlightedButton and corresponding
    code are also removed, as is some of the necessary state. The ability to
    highlight views::Buttons is still around, however, since they may be the
    anchor.

    Bug: 489349570
    Change-Id: I48f49ce05f07379db8dbf3b6614b85a66a2b165a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7789255
    Reviewed-by: Dana Fried <dfried@chromium.org>
    Commit-Queue: Maks Orlovich <morlovich@chromium.org>
    Reviewed-by: Cici Ruan <cuicuiruan@google.com>
    Cr-Commit-Position: refs/heads/main@{#1620373}

commit 5c61647fa6331ad61b0173fb2780e3ce732445dd
Author: Maks Orlovich <morlovich@chromium.org>
Date:   Tue Mar 10 15:57:49 2026 -0700

    Migrate ContentSettingsImageView to SetHighlightedElement.

    This required giving all of them an ElementIdentifier, which we will
    need for the WebUI impl anyway. To support multiple implementations the
    naming was placed in the Model, and the view made to use it
    consistently.

    Loosely inspired by caraitto@'s
    https://chromium-review.googlesource.com/c/chromium/src/+/7591203

    Bug: 489349570
    Change-Id: I6993f6acd2edd1d20a12ec951a4a2e2dfee4a625
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7649608
    Reviewed-by: Andy Paicu <andypaicu@chromium.org>
    Reviewed-by: Kaan Alsan <alsan@chromium.org>
    Commit-Queue: Maks Orlovich <morlovich@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1597382}

2026-05-22 16:57:23 -04:00

..

ai_chat

[cr149] ContentSettingPermissionResolver dropped from request data

2026-05-22 16:25:11 -04:00

android

[cr149] //chrome/browser/lifetime modularised

2026-05-22 16:25:10 -04:00

autocomplete

…

autofill/android

…

autoplay

…

banners

…

bluetooth

…

bookmarks/android

…

brave_account

…

brave_adaptive_captcha

…

brave_ads

[cr149] BrowserList was deleted

2026-05-22 16:25:09 -04:00

brave_news

…

brave_origin

[Origin] Defer policy init signal until BraveProfilePolicyProvider refreshes (#36495)

2026-05-20 07:22:43 -04:00

brave_referrals

…

brave_rewards

[cr149] //chrome/browser/first_run modularised

2026-05-22 16:25:06 -04:00

brave_search

Add feature + params for backup results service (#36339)

2026-05-12 13:56:24 -07:00

brave_shields

[cr149] Fixing kLearnMoreLink override and others

2026-05-22 16:25:05 -04:00

brave_stats

[cr149] //chrome/browser/first_run modularised

2026-05-22 16:25:06 -04:00

brave_vpn

[cr149] FindLastActive returning BrowserWindowInterface

2026-05-22 16:18:09 -04:00

brave_wallet

[cr149] FindLastActive returning BrowserWindowInterface

2026-05-22 16:18:09 -04:00

browsing_data

[cr149] BrowserList was deleted

2026-05-22 16:25:09 -04:00

component_updater

…

containers

Remove constexpr from struct initialization in test. (#36654)

2026-05-22 16:09:16 +02:00

content_settings

Change farbling seed per container. (#36474)

2026-05-20 13:53:21 +07:00

cosmetic_filters

[cr149] FindLastActive returning BrowserWindowInterface

2026-05-22 16:18:09 -04:00

custom_search_engines/android

[Android][Custom Search Engines] Design improvements (#36248)

2026-05-07 22:49:33 +01:00

customize_menu/android

…

day_zero_browser_ui_expt

…

debounce

…

decentralized_dns/test

…

download

…

email_aliases

Fix flaky EmailAliasesBrowserTest.ContextMenuAuthorizedManage (#36306)

2026-05-12 14:06:07 -04:00

ephemeral_storage

[cr149] BrowserList was deleted

2026-05-22 16:25:09 -04:00

extensions

[cr149] Update BraveUpdateClientConfig ctor calls

2026-05-22 16:25:03 -04:00

farbling

[cr149] WebString::FromUTF8 renamed to FromUTF8

2026-05-22 16:24:56 -04:00

first_run/android

Show new onboarding by default (#36349)

2026-05-12 18:07:13 +02:00

gcm_driver

…

geolocation

…

global_privacy_control

…

hid

…

history_embeddings

Drop WebContents → BindCallback registry on BravePassageEmbeddingsSevice (#36458)

2026-05-21 03:06:01 +01:00

hub/internal/android/java

[Android] Fix shred button spacing from screen edge in tab switcher (#36065)

2026-04-30 17:13:45 -04:00

importer

…

incognito/android

…

infobars

[cr149] FindLastActive returning BrowserWindowInterface

2026-05-22 16:18:09 -04:00

mac

…

metrics

Fix intermittent VariationsBrowserTest.BraveSeedApplied failure (#35722)

2026-05-01 18:40:31 -04:00

misc_metrics

[cr149] BrowserListObserver deleted

2026-05-22 16:24:57 -04:00

net

[query-filter] Enable query filter component integration (#36222)

2026-05-21 12:37:41 +02:00

new_tab

…

notifications

Wallet notifications (#35992)

2026-05-11 09:55:12 +07:00

ntp_background

[infobar] Refactor BraveConfirmInfoBar (2/N): cleanups (#36344)

2026-05-14 09:12:03 +09:00

ntp_background_images

…

ntp_customization

…

onboarding

…

p3a

[cr149] Fixes BraveWindowTracker dangling pointer.

2026-05-22 16:25:01 -04:00

partnercustomizations

…

password_entry_edit

…

password_manager

…

perf

…

permissions

[cr149] ContentSettingPermissionResolver dropped from request data

2026-05-22 16:25:11 -04:00

playlist

[cr149] FindLastActiveWithProfile returning BWI

2026-05-22 16:24:59 -04:00

policy

Account/Email Aliases: add profile-scoped enabled predicates (#36262)

2026-05-07 23:02:37 -07:00

preferences/android/java_templates

…

prefs

…

profile_resetter

…

profiles

[OSCrypt][Sync] Migrate to async OSCrypt (#36121)

2026-05-07 13:57:19 +03:00

psst

[PSST] Add consent dialog UI (#36529)

2026-05-21 11:11:50 +02:00

quick_search_engines/android

[Android] Exclude auto-discovered search engines from quick search engines (#36589)

2026-05-21 15:23:05 +01:00

regional_capabilities

…

renderer_context_menu

…

request_otr

…

resources

[cr149] ESLint fixes for reactive properties

2026-05-22 16:18:07 -04:00

safe_browsing/android/java/src/org/chromium/chrome/browser/safe_browsing/settings

…

sandbox

…

script_injector

…

search_engines

[cr149] BrowserList was deleted

2026-05-22 16:25:09 -04:00

serp_metrics

Smart NTT [virtual]:serp_metrics should return default values (#36407)

2026-05-14 00:40:00 +01:00

sessions

…

share/android

…

sharing_hub

…

shell_integrations/buildflags

…

signin/services/android

[cr149][Android] Remove SigninManager.revokeSyncConsent()

2026-05-22 16:25:10 -04:00

skus

…

speedreader

[cr149] BrowserList was deleted

2026-05-22 16:25:09 -04:00

ssl

…

storage_access_api

…

sync

[cr149] FindLastActive returning BrowserWindowInterface

2026-05-22 16:18:09 -04:00

tab_group_sync

…

test

…

themes

…

tor

[cr149] BrowserList was deleted

2026-05-22 16:25:09 -04:00

translate

…

ui

[cr149] Using SetHighlightedElement

2026-05-22 16:57:23 -04:00

updater

…

upgrade_when_idle

[cr149] //chrome/browser/lifetime modularised

2026-05-22 16:25:10 -04:00

url_sanitizer

…

web_discovery

…

web_package

…

webcompat_reporter

…

widevine

[cr149] ContentSettingPermissionResolver dropped from request data

2026-05-22 16:25:11 -04:00

workspaces

Workspaces - phase 1 (#36059)

2026-05-20 09:14:00 -07:00

about_flags.cc

[cr149] ManifestV2ExperimentManager moved to //extensions

2026-05-22 16:24:59 -04:00

brave_app_controller_mac_browsertest.mm

[cr149] FindLastActive returning BrowserWindowInterface

2026-05-22 16:18:09 -04:00

brave_app_controller_mac.h

…

brave_app_controller_mac.mm

…

brave_autofill_browsertest.cc

…

brave_browser_features.cc

…

brave_browser_features.h

…

brave_browser_main_extra_parts_p3a.cc

…

brave_browser_main_extra_parts_p3a.h

…

brave_browser_main_extra_parts.cc

[cr149] Fixes BraveWindowTracker dangling pointer.

2026-05-22 16:25:01 -04:00

brave_browser_main_extra_parts.h

[cr149] Fixes BraveWindowTracker dangling pointer.

2026-05-22 16:25:01 -04:00

brave_browser_main_parts_mac.h

…

brave_browser_main_parts_mac.mm

…

brave_browser_main_parts.cc

[cr149] FindLastActive returning BrowserWindowInterface

2026-05-22 16:18:09 -04:00

brave_browser_main_parts.h

…

brave_browser_process_impl.cc

Skip stats usage pings on Brave Origin branded builds (#36547)

2026-05-22 11:52:15 -04:00

brave_browser_process_impl.h

Skip stats usage pings on Brave Origin branded builds (#36547)

2026-05-22 11:52:15 -04:00

brave_browser_process.cc

…

brave_browser_process.h

Skip stats usage pings on Brave Origin branded builds (#36547)

2026-05-22 11:52:15 -04:00

brave_content_browser_client_browsertest.cc

…

brave_content_browser_client_unittest.cc

…

brave_content_browser_client.cc

Change farbling seed per container. (#36474)

2026-05-20 13:53:21 +07:00

brave_content_browser_client.h

Change farbling seed per container. (#36474)

2026-05-20 13:53:21 +07:00

brave_drm_tab_helper.cc

[cr149] FindLastActive returning BrowserWindowInterface

2026-05-22 16:18:09 -04:00

brave_drm_tab_helper.h

…

brave_global_features.cc

…

brave_global_features.h

…

brave_local_state_prefs.cc

Skip stats usage pings on Brave Origin branded builds (#36547)

2026-05-22 11:52:15 -04:00

brave_local_state_prefs.h

…

brave_prefs_browsertest.cc

Refactor query filter to follow modularization. (#36169)

2026-05-06 17:37:58 +02:00

brave_profile_prefs.cc

[Android] Add browser history removal to the existing Shred feature (#36191)

2026-05-11 17:53:45 +02:00

brave_profile_prefs.h

…

brave_resources_browsertest.cc

…

brave_resources_util_unittest.cc

…

brave_scheme_load_browsertest.cc

…

brave_shell_integration_mac.h

…

brave_shell_integration_mac.mm

…

brave_shell_integration_win.cc

…

brave_shell_integration_win.h

…

brave_shell_integration.cc

…

brave_shell_integration.h

…

brave_tab_helpers.cc

…

brave_tab_helpers.h

…

browser_context_keyed_service_factories.cc

Workspaces - phase 1 (#36059)

2026-05-20 09:14:00 -07:00

browser_context_keyed_service_factories.h

…

BUILD.gn

Skip stats usage pings on Brave Origin branded builds (#36547)

2026-05-22 11:52:15 -04:00

default_protocol_handler_utils_win_unittest.cc

…

default_protocol_handler_utils_win.cc

…

default_protocol_handler_utils_win.h

…

DEPS

Decouple PolicyService::Observer from AdsServiceImpl (#36437)

2026-05-15 17:41:37 -04:00

sources.gni

[cr149] Unused feed v2 sources deleted

2026-05-22 16:25:11 -04:00

update_util.cc

…

update_util.h

…